[Bug 26591] New: Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

Summary: Slingplayer 2 crashes when clicking on "Log in" when
                    compiled with gcc -O0
           Product: Wine
           Version: 1.3.16
          Platform: x86-64
               URL: http://download.slingmedia.com/player/pc/SlingPlayer-2
                    .0.4-Setup.exe
        OS/Version: Linux
            Status: NEW
          Keywords: download
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=33852)
 --> (http://bugs.winehq.org/attachment.cgi?id=33852)
wine-1.3.16-74-g7ee63f0 and gcc -O0 console output

Slingplayer 2 crashes when clicking on "Log in" in the main window.  It
attempts to open a HTML page to log in to your account via the website.

=>0 0x7d52ce3f BindStatusCallback_create+0x2ba(This=0x74b3418, obj=0x32de18,
body=0x32ddf0) [/home/test/wine-git/dlls/msxml3/httprequest.c:503] in msxml3
(0x0032ddc8)

This only occurs when compiling Wine with gcc -O0.  It works fine with gcc -O1
and the precompiled .deb (which I believe to be -O2).

Workaround is to use native msxml3 OR compile with gcc -Ox where x>0.

Bug also does not exist with Wine-1.3.0 or Wine-1.2 with gcc -O3, but I cannot
recall this bug occurring before so could be a regression (perhaps even in
gcc).

Console output attached.

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |msxml3

--- Comment #1 from Ken Sharp  2011-03-29 15:25:15 CDT ---
Leaving everything else compiled as -O1 but editing the msxml3 Makefile to
read...

CFLAGS          = -g -O0 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0

...the error returns.

I should add:

$ gcc --version
gcc (Ubuntu/Linaro 4.4.4-14ubuntu5) 4.4.5

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

--- Comment #2 from Ken Sharp  2011-03-29 15:26:32 CDT ---
Created an attachment (id=33854)
 --> (http://bugs.winehq.org/attachment.cgi?id=33854)
gcc -c -Q -O1 --help=optimizers > /tmp/O1-opts ; grep "enabled" /tmp/O1-opts >
/tmp/O1-opts-enabled

List of -O1 enabled options.

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33854|application/octet-stream    |text/plain
          mime type|                            |

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33854|0                           |1
        is obsolete|                            |

--- Comment #3 from Ken Sharp  2011-03-29 15:32:42 CDT ---
Created an attachment (id=33855)
 --> (http://bugs.winehq.org/attachment.cgi?id=33855)
Additional O1 options over O0

A bit more useful than the last attachment.

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

--- Comment #4 from Austin English  2011-03-29 15:36:33 CDT ---
Can you try compiling 1.2 / 1.3 with -O0 and see if the error returns?

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

--- Comment #5 from Nikolay Sivov  2011-03-29 15:47:17 CDT ---
Mmm, does it help if you adjust error handling a bit here:

---
hr = IMoniker_BindToStorage(moniker, pbc, NULL, &IID_IStream, (void**)&stream);
IMoniker_Release(moniker);
if (stream) IStream_Release(stream);
---

Change that to let's say

---
- if (stream) IStream_Release(stream)
+ if (hr == S_OK) IStream_Release(stream)
---

There's a failure path in urlmon that doesn't reset stream pointer, could be a
problem.

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

--- Comment #6 from Ken Sharp  2011-03-29 17:00:35 CDT ---
(In reply to comment #4)
> Can you try compiling 1.2 / 1.3 with -O0 and see if the error returns?

I forgot to add compiling 1.3 with -O0 has the same problem, but I can't
remember now if the same is true of 1.2, however...

(In reply to comment #5)
> Mmm, does it help if you adjust error handling a bit <...>

It certainly does!  With the change above there is no crash when compiling with
-O0.

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

--- Comment #7 from Nikolay Sivov  2011-03-31 03:11:25 CDT ---
Good, thanks for test.

Does log in function really work with this change or it just doesn't crash?
Attach +msxml,+tid please.

The place to fix could be urlmon, it needs some tests.

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

--- Comment #8 from Ken Sharp  2011-03-31 12:21:13 CDT ---
Created an attachment (id=33882)
 --> (http://bugs.winehq.org/attachment.cgi?id=33882)
wine-1.3.16-214-g209e106 and gcc -O0 +msxml +tid (6.1 MB)

No, sadly the login page never loads thanks to Bug 18557 which you meet when
working around this bug.  Trace attached.

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

--- Comment #9 from Nikolay Sivov  2011-03-31 12:28:50 CDT ---
As expected it's relative:

---
002f:trace:msxml:httprequest_open (0xbcfdac0)->(L"GET" L"Scripts/Common.js"
{VT_BOOL: 0}) 
---

Our implementation doesn't support relative url for this method yet. Some tests
are here though, so there's an understanding how it's supposed to work at
least.

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

--- Comment #10 from Nikolay Sivov  2011-04-01 09:53:55 CDT ---
Could you confirm that b26aa09f58d7f015a061e73db0b43ebbf6539fa1 fixes a crash?

(it doesn't fix relative path case of course, so request still shouldn't work).

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
             Blocks|                            |18557
         Resolution|                            |FIXED

--- Comment #11 from Ken Sharp  2011-04-01 13:02:10 CDT ---
Yup.  Crash gone in latest git, reverting
b26aa09f58d7f015a061e73db0b43ebbf6539fa1 brings it back.

Fixed.

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2011-04-15 12:49:54 CDT ---
Closing bugs fixed in 1.3.18.

[Bug 26591] Slingplayer 2 crashes when clicking on "Log in" when compiled with gcc -O0

http://bugs.winehq.org/show_bug.cgi?id=26591

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |b26aa09f58d7f015a061e73db0b
                   |                            |43ebbf6539fa1