[Bug 25417] New: Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Summary: Black & White: Ignores mouse button clicks
           Product: Wine
           Version: 1.3.6
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-ddraw
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The application 'Black & White' does not register either left or right mouse
button clicks. The scroll wheel is responded to normally.

Bisecting revealed the culprit commit as commit
"7e3985e1fea60da73bae2b9465b94e5d110909fc: ddraw: Setup the device window in
SetCooperativeLevel()."

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Itzamna  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Difficulty|---                         |Minutes

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]

--- Comment #1 from Jeff Zaroyko  2010-12-04 18:51:44 CST ---
Adding author of commit as cc.

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Difficulty|Minutes                     |---

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
           Platform|x86-64                      |All
            Version|1.3.6                       |1.3.7
     Ever Confirmed|0                           |1

--- Comment #2 from Wylda  2010-12-18 13:45:34 CST ---

Confirming, the commit is correctly bisected. Adjusting the version, because
the commit is: wine-1.3.6-283-g7e3985e.

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from joaopa  2011-02-25 16:09:47 CST ---
Duplicate of bug 25969

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Henri Verbeet  2011-03-02 03:59:59 CST ---
*** Bug 26277 has been marked as a duplicate of this bug. ***

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

--- Comment #5 from Zdenek Behan  2011-03-02 05:11:09 CST ---
In bug 26277, I posted a patch that fixes this.

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Ben Klein  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

James Le Cuirot  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Vinothan "Darael" Shankar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |neversaymonkey+winebugs@gma
                   |                            |il.com

--- Comment #6 from Vinothan "Darael" Shankar  2011-06-02 10:40:43 CDT ---
(In reply to comment #5)
> In bug 26277, I posted a patch that fixes this.

That patch now fails, and my meagre skills are not enough to get it to apply
properly.  Did I mention they were meagre?

In any case, the patch fails to apply to two out of three files - output is:

darael@jagat:~/src/wine$ patch -p1 < wine-button-click.patch 
patching file dlls/wined3d/device.c
Hunk #1 FAILED at 1773.
1 out of 1 hunk FAILED -- saving rejects to file dlls/wined3d/device.c.rej
patching file dlls/wined3d/swapchain.c
Hunk #1 succeeded at 854 (offset 314 lines).
patching file dlls/wined3d/wined3d_private.h
Hunk #1 FAILED at 1784.
1 out of 1 hunk FAILED -- saving rejects to file
dlls/wined/wined3d_private.h.rej

The patch fails on Wine 1.3.21, and I also tried it on the latest git revision
just in case - no joy.

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

--- Comment #7 from Vinothan "Darael" Shankar  2011-06-02 11:35:51 CDT ---
I don't know if it helps, but I've bisected the revision that broke the patch
to "0e0e5c3e381faa7090835dfa81b19cb85220b218: wined3d: Get rid of the
IWineD3DDevice typedefs".

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

--- Comment #8 from Wylda  2011-06-21 06:18:35 CDT ---
> I don't know if it helps, but I've bisected the revision that broke...

Probably not or you hit different bug. See comment #0 & comment #2, it's
different commit.

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

--- Comment #9 from Pawel Drewniak  2011-06-22 11:26:34 CDT ---
Created an attachment (id=35234)
 --> (http://bugs.winehq.org/attachment.cgi?id=35234)
new version of the patch

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Pawel Drewniak  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Pawel Drewniak  2011-06-22 11:27:16 CDT ---
(In reply to comment #9)
> Created an attachment (id=35234)

--> (http://bugs.winehq.org/attachment.cgi?id=35234) [details]
> new version of the patch

Please check if it works, I currently have some issues with B&W

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

--- Comment #11 from Pawel Drewniak  2011-06-22 12:25:54 CDT ---
(In reply to comment #10)
> (In reply to comment #9)
> > Created an attachment (id=35234)

--> (http://bugs.winehq.org/attachment.cgi?id=35234) [details] [details]
> > new version of the patch
>
> Please check if it works, I currently have some issues with B&W

Just checked, the patch is ok

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |7e3985e1fea60da73bae2b9465b
                   |                            |94e5d110909fc

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Jonathan Dumaine  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Jonathan Dumaine  2011-08-16 15:30:23 CDT ---
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > Created an attachment (id=35234)

--> (http://bugs.winehq.org/attachment.cgi?id=35234) [details] [details]
[details]
> > > new version of the patch
> >
> > Please check if it works, I currently have some issues with B&W
>
> Just checked, the patch is ok

Failed to build in 1.3.26#8c00ee0beff

make results in:

swapchain.c:859: warning: implicit declaration of function
‘IWineD3DDeviceImpl_SetupFullscreenWindow’
swapchain.c:859: error: ‘IWineD3DDevice’ undeclared (first use in this
function)
swapchain.c:859: error: (Each undeclared identifier is reported only once
swapchain.c:859: error: for each function it appears in.)
swapchain.c:859: error: expected expression before ‘)’ token

Which is the function that was patched.

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Damian Ivanov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Damian Ivanov  2011-08-19 08:41:40 CDT ---
For me it builds, I set the the fuzz factor for patch a bit higher.
I made a wine package for openSUSE 11.3, 11.4, Factory and Tumbleweed including
the 3 patches for Black and White (Bugs: bug 14939 (texture bug), bug 15984
(crash bug) and bug 25417 (mouse bug)).
https://build.opensuse.org/package/show?package=wine&project=home%3Adami...
the source and .rpm's at
http://download.opensuse.org/repositories/home:/damianator/
Fixes also bugs: 6955, 20395, 17423, 20296, 16831 and more

Cheers,
Damian

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

--- Comment #14 from Henri Verbeet  2011-11-02 06:36:35 CDT ---
Does this still happen with current git / 1.3.31?

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

--- Comment #15 from Zdenek Behan  2011-11-02 15:52:56 CDT ---
In 1.3.31/HEAD, it actually crashes for me, seems like unrelated regression.
I'm going to see if i can bisect that, revert it individually, and check if my
patch still matters.

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

--- Comment #16 from Zdenek Behan  2011-11-02 20:22:24 CDT ---
(In reply to comment #14)
> Does this still happen with current git / 1.3.31?

OK, the crash is not a regression, rather some bizarre cd protection problem.

The bug is still present both in current latest release and git HEAD and still
fixed by http://bugs.winehq.org/attachment.cgi?id=35234

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Igor Mammedov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Igor Mammedov  2011-11-19 18:41:35 CST ---
version 1.3.33 is still affected by this bug.
Just checked on 1.3.33 + patch http://bugs.winehq.org/attachment.cgi?id=35234,
issue is resolved with this patch.

Could it be merged into mainline, please?

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

--- Comment #18 from Damian Ivanov  2011-12-04 22:35:22 CST ---
patch do not compile with 1.3.34

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

--- Comment #19 from Igor Mammedov  2011-12-14 16:49:02 CST ---
Created attachment 37976
  --> http://bugs.winehq.org/attachment.cgi?id=37976
wined3d: Fixes some windows to receive mouse clicks

modified to build on current git head 447384e7b89

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Igor Mammedov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37976|wined3d: Fixes some windows |1.3.34 wined3d: Fixes some
        description|to receive mouse clicks     |windows to receive mouse
                   |                            |clicks

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

--- Comment #20 from Henri Verbeet  2012-01-27 11:48:56 CST ---
It may be worth a try to see if this is similar to bug 29301. I.e., if not
touching the window styles in wined3d_device_setup_fullscreen_window() makes it
any better.

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from GyB  2012-03-18 12:12:48 CDT ---
Any change on this issue with Wine-1.4 or 1.5.0?
I've recently found that mouse clicks in certain games work since 1.4.
Previously, the mouse buttons were unusable with those games.

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

--- Comment #22 from [e-mail] 2012-12-26 11:49:02 CST ---
Created attachment 42961
  --> http://bugs.winehq.org/attachment.cgi?id=42961
New Version of the Patch, new context

actually this is untested and I'm not experienced patchmaker at all but the
patch seemed to fail only for a slight change in Context ["Null"] and was easy
to be applied manually
Greets

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #23 from [e-mail] 2013-03-12 19:15:06 CDT ---
I'm running B&W with Wine 1.5.25 and mouse is working fine! No patch needed for
that.

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #24 from Henri Verbeet  2013-04-03 02:49:36 CDT ---
Reported FIXED.

[Bug 25417] Black & White: Ignores mouse button clicks

http://bugs.winehq.org/show_bug.cgi?id=25417

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #25 from Alexandre Julliard  2013-04-12 13:46:26 CDT ---
Closing bugs fixed in 1.5.28.