[Bug 25063] New: _pclose should wait for the command processor to terminate and return it's exit status

http://bugs.winehq.org/show_bug.cgi?id=25063

Summary: _pclose should wait for the command processor to
                    terminate and return it's exit status
           Product: Wine
           Version: 1.3.6
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msvcrt
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

_pclose should close the the stream, wait for the command processor to
terminate and return it's exit status, but it just closes the the stream and
returns whatever MSVCRT_fclose() returns.

Borut

[Bug 25063] _pclose should wait for the command processor to terminate and return it's exit status

http://bugs.winehq.org/show_bug.cgi?id=25063

--- Comment #1 from Borut Ražem  2010-11-14 11:35:20 CST ---
Created an attachment (id=31935)
 --> (http://bugs.winehq.org/attachment.cgi?id=31935)
wine-1.3.7 dlls/msvcrt/process.c patch

The attached patch stores the popen child process handle into the fp2handle
array, waits for the child process to terminate and returns the child process
exit status at pclose.

Borut

[Bug 25063] _pclose should wait for the command processor to terminate and return it's exit status

http://bugs.winehq.org/show_bug.cgi?id=25063

Borut Ražem  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.6                       |1.3.7

[Bug 25063] _pclose should wait for the command processor to terminate and return it's exit status

http://bugs.winehq.org/show_bug.cgi?id=25063

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.7                       |1.3.6

[Bug 25063] _pclose should wait for the command processor to terminate and return it's exit status

http://bugs.winehq.org/show_bug.cgi?id=25063

--- Comment #2 from Borut Ražem  2010-11-14 16:11:21 CST ---
Created an attachment (id=31942)
 --> (http://bugs.winehq.org/attachment.cgi?id=31942)
wine-1.3.7 dlls/msvcrt/process.c patch with lock

Functions msvcrt_add_handle() and msvcrt_get_remove_handle() in the previous
patch are not thread safe, so I added a locking mechanism. I (re)used the
_POPEN_LOCK, since it seems that it is not used anywhere else.

Borut

[Bug 25063] _pclose should wait for the command processor to terminate and return it's exit status

http://bugs.winehq.org/show_bug.cgi?id=25063

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #3 from Austin English  2010-11-14 17:31:04 CST ---
Please send patches to [e-mail].

Thanks!

[Bug 25063] _pclose should wait for the command processor to terminate and return it's exit status

http://bugs.winehq.org/show_bug.cgi?id=25063

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Jerome Leclanche  2011-02-05 00:07:46 CST ---
A patch was sent, but was not committed.
http://www.winehq.org/pipermail/wine-patches/2010-November/096237.html

[Bug 25063] _pclose should wait for the command processor to terminate and return it's exit status

http://bugs.winehq.org/show_bug.cgi?id=25063

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |a968a1ad6dccd85548b62b43d7a
                   |                            |0e41d2a4058d5
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #5 from Piotr Caban  2013-01-18 12:34:27 CST ---
Fixed by commit: a968a1ad6dccd85548b62b43d7a0e41d2a4058d5.

[Bug 25063] _pclose should wait for the command processor to terminate and return it's exit status

http://bugs.winehq.org/show_bug.cgi?id=25063

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  2013-01-18 14:57:03 CST ---
Closing bugs fixed in 1.5.22.