https://bugs.winehq.org/show_bug.cgi?id=52025
Bug ID: 52025 Summary: Custom color configuration is reseted if custom theme is applied Product: Wine Version: 6.21 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: uxtheme Assignee: wine-bugs@winehq.org Reporter: joseskvolpe@gmail.com Distribution: ---
Regression result: 3762a11c81455edee65881702c5c26ae5d3081b3 is the first bad commit commit 3762a11c81455edee65881702c5c26ae5d3081b3 Author: Zhiyi Zhang zzhang@codeweavers.com Date: Thu Nov 4 14:44:47 2021 +0800
uxtheme: Fix loading a different theme when theming is on.
When a theme is already active and a user tries to activate another theme, the new theme configuration should be written to the registry so that it's still in effect after a wine reboot.
Fix a regression introduced in d290362.
Signed-off-by: Zhiyi Zhang zzhang@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
dlls/uxtheme/system.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Wine 6.20 -> 6.21
Procedure: 1 - Open winecfg 2 - Apply a custom theme, theme used on this test was VLT by evgkursai: https://www.deviantart.com/evgkursai/art/VLT-2-0-VS-36103075 3 - Change any color and apply. On this test, i've changed "Selection Background" ("Fundo da Seleção" in portuguese-brazilian) color 4 - Close winecfg 5 - Open winecfg again
https://bugs.winehq.org/show_bug.cgi?id=52025
Josesk Volpe joseskvolpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |3762a11c81455edee65881702c5 | |c26ae5d3081b3 Distribution|--- |ArchLinux
https://bugs.winehq.org/show_bug.cgi?id=52025
Josesk Volpe joseskvolpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=52025
--- Comment #1 from Josesk Volpe joseskvolpe@gmail.com --- I've also found another regression regarding theming that appears in other commit, in wich some text labels don't display correctly with some msstyles themes. I'm making another regression test to report this bug.
https://bugs.winehq.org/show_bug.cgi?id=52025
Josesk Volpe joseskvolpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Custom color configuration |Regression: Custom color |is reseted if custom theme |configuration is reseted if |is applied |custom theme is applied
https://bugs.winehq.org/show_bug.cgi?id=52025
Josesk Volpe joseskvolpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression: Custom color |Regression: Custom color |configuration is reseted if |configuration resets if |custom theme is applied |custom theme is applied
https://bugs.winehq.org/show_bug.cgi?id=52025
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1
--- Comment #2 from Zhiyi Zhang zzhang@codeweavers.com --- Confirmed. I will look into it.
https://bugs.winehq.org/show_bug.cgi?id=52025
--- Comment #3 from Zhiyi Zhang zzhang@codeweavers.com --- Created attachment 71047 --> https://bugs.winehq.org/attachment.cgi?id=71047 fix
https://bugs.winehq.org/show_bug.cgi?id=52025
--- Comment #4 from Josesk Volpe joseskvolpe@gmail.com --- Tested and i confirm this patch fix the issue :3
https://bugs.winehq.org/show_bug.cgi?id=52025
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |ea71625cf177f2ad38d4520383e | |91a4a6152a550 Resolution|--- |FIXED
--- Comment #5 from Zhiyi Zhang zzhang@codeweavers.com --- Fixed by ea71625cf177f2ad38d4520383e91a4a6152a550
https://bugs.winehq.org/show_bug.cgi?id=52025
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.23.
https://bugs.winehq.org/show_bug.cgi?id=52025
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression: Custom color |Custom color configuration |configuration resets if |resets if custom theme is |custom theme is applied |applied Keywords| |regression