[Bug 52980] New: conhost.exe:tty - test_tty_input() fails in most locales on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52980

Bug ID: 52980
           Summary: conhost.exe:tty - test_tty_input() fails in most
                    locales on Windows
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: programs
          Assignee: [e-mail]
          Reporter: [e-mail]

conhost.exe:tty - test_tty_input() fails in most locales on Windows.
Specifically it fails in German, French, Portuguese (Brazil and Portugal), and
Spanish (the mixed locale, mx-MX, uses a Spanish keyboard layout).

For instance in Portuguese (Brazil):

tty.c:1521: Test failed: 2f: wVirtualKeyCode = 12, expected 11
tty.c:1521: Test failed: 2f: wVirtualScanCode = 38 expected 1d
tty.c:1521: Test failed: 2f: dwControlKeyState = 109
tty.c:1521: Test failed: 2f: dwControlKeyState = 9
[...]
tty.c:1521: Test failed: 3f: dwControlKeyState = 100
tty.c:1544: Test failed: 2f: wVirtualKeyCode = dd, expected db
tty.c:1544: Test failed: 2f: wVirtualScanCode = 1b expected 1a
tty.c:1544: Test failed: 2f: wVirtualKeyCode = dd, expected db
tty.c:1544: Test failed: 2f: wVirtualScanCode = 1b expected 1a

https://test.winehq.org/data/patterns.html#conhost.exe:tty

The test also fails on cw-gtx560 and cw-rx460, maybe because their keyboard
layout is not completely standard due to the KVM. Besides the usual failures on
lines 1521 and 1544, those get a few related earlier failures:

tty.c:1505: Test failed: 61: wVirtualScanCode = 4f expected 1e
tty.c:1505: Test failed: 61: wVirtualScanCode = 4f expected 1e
tty.c:1508: Test failed: 64: wVirtualScanCode = 4b expected 20
tty.c:1508: Test failed: 64: wVirtualScanCode = 4b expected 20

[Bug 52980] conhost.exe:tty - test_tty_input() fails in most locales on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52980

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

[Bug 52980] conhost.exe:tty - test_tty_input() fails in most locales on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52980

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 52980] conhost.exe:tty - test_tty_input() fails in most locales on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52980

Eric Pouech  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Eric Pouech  ---
likely fixed by fe9151fc06b213d874bd80116e546b779a5ed453
François, I let you confirm & close if ok

[Bug 52980] conhost.exe:tty - test_tty_input() fails in most locales on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52980

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |5a8350120c27f4bcb5f53817dec
                   |                            |4a6f5964e06b2
         Resolution|---                         |FIXED

--- Comment #2 from François Gouget  ---
Yep, this is clearly fixed. Thanks.
The commit id is wrong though. I think you meant:

commit 5a8350120c27f4bcb5f53817dec4a6f5964e06b2
Author:     Eric Pouech 
AuthorDate: Mon Oct 24 15:24:35 2022 +0200
Commit:     Alexandre Julliard 
CommitDate: Mon Oct 24 18:50:36 2022 +0200

conhost/tests: Fix some tests on input sequences.

Correctly handling keyboards (French, German...) which report right-alt
    as ctrl+alt in VkKeyScan().

Splitting escape_test input tests into pure virtual keys on one hand,
    and modified char key on the other.
    Generating the virtual codes for the later instead of hardcoding the
    results (bound to generic US keyboard).

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52980
    Signed-off-by: Eric Pouech

commit bdad6f2c853045602ab3995ec3490bee3d0a60fb
Author: Eric Pouech 
Date:   Mon Oct 24 15:24:33 2022 +0200

conhost/tests: Fix tests for some keyboard layouts.

Some keyboards (French, German and some others) report the right alt key
    (which is some cases the right-shift one) as ctrl+alt.
    Add proper handling for ctrl+alt return from VkKeyScan().

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52980
    Signed-off-by: Eric Pouech

Marking resolved.

[Bug 52980] conhost.exe:tty - test_tty_input() fails in most locales on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52980

--- Comment #3 from Eric Pouech  ---
yes, I likely picked the sha1 of the git MR

[Bug 52980] conhost.exe:tty - test_tty_input() fails in most locales on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52980

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 8.0-rc1.