https://bugs.winehq.org/show_bug.cgi?id=55161
Bug ID: 55161 Summary: IrfanView full screen mode creates an unneeded and uncalled for permanent overlaying panel Product: Wine Version: 8.6 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: aros@gmx.com Distribution: ---
Created attachment 74729 --> https://bugs.winehq.org/attachment.cgi?id=74729 Panel
Steps to reproduce:
1) Download https://www.irfanview.info/files/iview460.zip 2) Run 3) Open any image 4) Press Enter or View -> Full screen 5) Press Enter once again (to leave full screen mode)
Result:
At this point at the bottom of the screen a 100px high permanent on top of the screen panel will appear.
This panel must _not_ exist.
What's worse if you run any other Windows application in parallel and you exit IrfanView, this panel will continue to be shown until wineserver exits.
This is a regression, sorry I cannot bisect at the moment.
https://bugs.winehq.org/show_bug.cgi?id=55161
--- Comment #1 from Artem S. Tashkinov aros@gmx.com --- Created attachment 74730 --> https://bugs.winehq.org/attachment.cgi?id=74730 Graphics settings:
Wine settings:
Windows version: 7
Graphics settings:
https://bugs.winehq.org/show_bug.cgi?id=55161
--- Comment #2 from Artem S. Tashkinov aros@gmx.com --- Actually this is reproducible with a new fresh Wine prefix with no settings at all.
I don't remember when it regressed but the bug has been present in the past at least five releases including Wine 8.11 which I'm running right now.
https://bugs.winehq.org/show_bug.cgi?id=55161
--- Comment #3 from Artem S. Tashkinov aros@gmx.com --- The panel is there even in Wine 8.0.1.
https://bugs.winehq.org/show_bug.cgi?id=55161
--- Comment #4 from Artem S. Tashkinov aros@gmx.com --- OK, the panel is not there in Wine 7.20.
That's quite a long regression window but somehow I haven't paid attention to this bug earlier. I'm sorry.
https://bugs.winehq.org/show_bug.cgi?id=55161
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
https://bugs.winehq.org/show_bug.cgi?id=55161
Alex Henrie alexhenrie24@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alexhenrie24@gmail.com, | |zzhang@codeweavers.com Status|UNCONFIRMED |NEW Regression SHA1| |8459a5272a5b16bf99d058aade0 | |1c946a71c94f8 URL| |https://www.irfanview.info/ | |files/iview460.zip Version|8.6 |7.22 Ever confirmed|0 |1
--- Comment #5 from Alex Henrie alexhenrie24@gmail.com --- I can confirm. `git bisect` says:
8459a5272a5b16bf99d058aade01c946a71c94f8 is the first bad commit commit 8459a5272a5b16bf99d058aade01c946a71c94f8 Author: Zhiyi Zhang zzhang@codeweavers.com Date: Mon Nov 14 22:19:26 2022 +0800
explorer: Use a valid taskbar position when the taskbar is hidden.
Some applications use FindWindowA() with class Shell_TrayWnd to find the taskbar window on Windows. Then GetWindowRect() is called to get the taskbar window rectangle. Finally, the taskbar window rectangle is subtracted from the primary screen rectangle to calculate the work area. Without a valid taskbar window position, these applications end up getting an incorrect work area and going down the wrong path. So use the same position and size as the host system panel for explorer taskbar when it's hidden.
programs/explorer/systray.c | 15 +++++++++------ programs/explorer/tests/explorer.c | 1 - 2 files changed, 9 insertions(+), 7 deletions(-)
https://bugs.winehq.org/show_bug.cgi?id=55161
--- Comment #6 from Artem S. Tashkinov aros@gmx.com --- Zhiyi Zhang,
Would be great if you looked into this.
Thanks!
https://bugs.winehq.org/show_bug.cgi?id=55161
--- Comment #7 from Zhiyi Zhang zzhang@codeweavers.com --- (In reply to Artem S. Tashkinov from comment #6)
Zhiyi Zhang,
Would be great if you looked into this.
Thanks!
I will take a look when I have time.
https://bugs.winehq.org/show_bug.cgi?id=55161
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs@winehq.org |zzhang@codeweavers.com
--- Comment #8 from Zhiyi Zhang zzhang@codeweavers.com --- I am taking a look at this.
https://bugs.winehq.org/show_bug.cgi?id=55161
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Assignee|zzhang@codeweavers.com |wine-bugs@winehq.org Fixed by SHA1| |118810ad3bac91bfeea81e44080 | |59d48c158e8c5 Status|NEW |RESOLVED
--- Comment #9 from Zhiyi Zhang zzhang@codeweavers.com --- Fixed by 118810ad3bac91bfeea81e4408059d48c158e8c5
(118810ad3ba...)|BISECTING:src/wine$ git bisect fixed 118810ad3bac91bfeea81e4408059d48c158e8c5 is the first fixed commit commit 118810ad3bac91bfeea81e4408059d48c158e8c5 Author: RĂ©mi Bernon rbernon@codeweavers.com Date: Thu Jun 22 21:05:15 2023 +0200
explorer: Support standalone systray window mode.
programs/explorer/systray.c | 77 ++++++++++++++++++++++++++++++-------- programs/explorer/tests/explorer.c | 3 ++ 2 files changed, 64 insertions(+), 16 deletions(-)
https://bugs.winehq.org/show_bug.cgi?id=55161
--- Comment #10 from Artem S. Tashkinov aros@gmx.com --- This is indeed fixed in 9.0-rc1/rc2 except there's a new bug.
https://bugs.winehq.org/show_bug.cgi?id=55161
--- Comment #11 from Zhiyi Zhang zzhang@codeweavers.com --- (In reply to Artem S. Tashkinov from comment #10)
This is indeed fixed in 9.0-rc1/rc2 except there's a new bug.
Please open a new report for the new bug. Thanks.
https://bugs.winehq.org/show_bug.cgi?id=55161
--- Comment #12 from Artem S. Tashkinov aros@gmx.com --- (In reply to Zhiyi Zhang from comment #11)
(In reply to Artem S. Tashkinov from comment #10)
This is indeed fixed in 9.0-rc1/rc2 except there's a new bug.
Please open a new report for the new bug. Thanks.
Bug 56056.
https://bugs.winehq.org/show_bug.cgi?id=55161
Artem S. Tashkinov aros@gmx.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |56056
https://bugs.winehq.org/show_bug.cgi?id=55161
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #13 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.0-rc3.