[Bug 15367] New: "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Summary: "Using help" or "Help on help"  crashes winhlp32
           Product: Wine
           Version: 1.1.4
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

winhlp32 crashes if user selects "Using help" or "Help on help" menu element in
any (wine) application, e.g. notepad or winhlp32.

Steps to reproduce:
1. Start wine application:
% wine notepad
2. Select "Help" -> "Using help"
3. See backtrace in console

wine: Unhandled page fault on read access to 0x00000028 at address 0x7ec6ede7

See attachment for full error log.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #1 from Arseny Solokha   2008-09-22 04:11:29 ---
Created an attachment (id=16213)
 --> (http://bugs.winehq.org/attachment.cgi?id=16213)
Crash log

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #2 from Austin English   2008-09-22 08:55:12 ---
Is this a regression?

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

WindowsHater  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from WindowsHater   2008-09-25 07:30:39 ---
hm, that's WEIRD.

which app were you using when it crashes? notepad?
tell me and I'll try it out.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |download

--- Comment #4 from Austin English   2008-09-25 10:17:55 ---
Confirming. Shows in notepad.

Attaching a +winhelp.

Anyone know if this is a regression?

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16213|0                           |1
        is obsolete|                            |

--- Comment #5 from Austin English   2008-09-25 10:18:35 ---
Created an attachment (id=16268)
 --> (http://bugs.winehq.org/attachment.cgi?id=16268)
+winhelp in (yesterday's) git

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #6 from Arseny Solokha   2008-09-26 04:14:49 ---
(In reply to comment #3)
> hm, that's WEIRD.
>
> which app were you using when it crashes? notepad?

notepad
winhlp32 itself
progman

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #7 from Austin English   2008-09-26 09:06:00 ---
(In reply to comment #6)
> (In reply to comment #3)
> > hm, that's WEIRD.
> >
> > which app were you using when it crashes? notepad?
>
> notepad
> winhlp32 itself
> progman

$ wine notepad

go to:
help
help on help
CRASH

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Eric Pouech  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Eric Pouech   2008-09-26 14:03:52 ---
for the sake of record, this is the fix
http://www.winehq.org/pipermail/wine-patches/2008-September/062041.html
not sure if it'll ever be committed

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

nathan.n  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.2.0

--- Comment #9 from Austin English   2008-12-24 10:01:18 ---
Still present in git. It's got a patch, and we really shouldn't have bugs in
apps we provide, so nominating for 1.2.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Dylan Smith   2009-03-07 21:34:08 ---
(In reply to comment #8)
> for the sake of record, this is the fix
> http://www.winehq.org/pipermail/wine-patches/2008-September/062041.html
> not sure if it'll ever be committed

Did you ask why it wasn't accepted?

Perhaps it wasn't clear that you understood what was happening?

Specifically it is Globals.active_win->page that is NULL in this case.

What happens is that winhlp32.exe is executed, but no hlp file is specified on
the command line, only the -x flag which hides winhlp32 and prevents
GetFileOpenName from being called to get the hlp file to display.  At this
point no page has been open, so Globals.active_win->page is NULL.

Next the notepad process sends a WM_COPYDATA message to the winhlp32 process by
calling WinHelpA.  This is what causes MACRO_HelpOn to try to open
"winhelp.hlp", however assumes Globals.active_win->page is not NULL, so it
crashes.

All of this seems like normal behaviour, except MACRO_HelpOn should check if
Globals.active_win->page is NULL.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Markus Elfring  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Dmitry Timoshkov   2009-06-17 01:56:51 ---
*** Bug 18972 has been marked as a duplicate of this bug. ***

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #12 from Austin English   2009-07-12 13:21:41 ---
Still present in git. I added an appinstall test:
http://code.google.com/p/winezeug/source/diff?spec=svn562&r=562&form...

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Owen Rudge  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Owen Rudge   2009-07-21 22:53:27 ---
I have submitted a fix for this to wine-patches:

http://www.winehq.org/pipermail/wine-patches/2009-July/076237.html

It is effectively the same as Eric's patch, although with slightly better
explanation, and a minor difference in that it checks MACRO_CurrentWindow() (as
the majority of other routines in that file do) rather than Globals.active_win,
which conceivably could be different.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #14 from Owen Rudge   2009-07-22 10:38:44 ---
OK, patch is now in git, this bug should now be resolved.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #15 from Jerome Leclanche   2009-07-22 12:58:50 ---
(In reply to comment #14)
> OK, patch is now in git, this bug should now be resolved.

It doesn't crash anymore, but the application freezes and becomes unresponsive.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #16 from Owen Rudge   2009-07-22 13:07:54 ---
Is an error message or a backtrace printed in the console? Exactly what steps
did you take to get this result?

For me, opening winhlp32.exe, cancelling the Open dialog, and choosing Help on
Help gives a "cannot find winhelp.hlp" error message, as it should.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #17 from Austin English   2009-07-22 13:14:03 ---
I haven't tested myself yet, but apparently the test now succeeds:
http://austinenglish.com/logs/appinstall-2009-07-22/builtin-gui-result.txt
winhlp32.exe didn't crash. Bug 15367 TODO_FIXED.

I'll test this afternoon when I get home.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #18 from Jerome Leclanche   2009-07-22 13:22:31 ---
(In reply to comment #16)
> Is an error message or a backtrace printed in the console? Exactly what steps
> did you take to get this result?
>
> For me, opening winhlp32.exe, cancelling the Open dialog, and choosing Help on
> Help gives a "cannot find winhelp.hlp" error message, as it should.

No output, it just freezes.
I tried with a fresh WINEPREFIX and it does not happen, it only happens if
"Allow the window manager to decorate the windows" is not ticked.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #19 from Owen Rudge   2009-07-22 13:27:02 ---
> I tried with a fresh WINEPREFIX and it does not happen, it only happens if
> "Allow the window manager to decorate the windows" is not ticked.

Hmm, having done a little test on OS X now, and it seems to work with the
option enabled and disabled. I don't currently have access to a Linux box. What
window manager are you using?

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #20 from Jerome Leclanche   2009-07-22 13:37:07 ---
(In reply to comment #19)
> > I tried with a fresh WINEPREFIX and it does not happen, it only happens if
> > "Allow the window manager to decorate the windows" is not ticked.
>
> Hmm, having done a little test on OS X now, and it seems to work with the
> option enabled and disabled. I don't currently have access to a Linux box. What
> window manager are you using?

Kwin.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #21 from Austin English   2009-07-22 17:20:38 ---
(In reply to comment #15)
> (In reply to comment #14)
> > OK, patch is now in git, this bug should now be resolved.
>
> It doesn't crash anymore, but the application freezes and becomes unresponsive.

Works fine for me in gnome.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #22 from Austin English   2009-08-02 18:21:19 ---
(In reply to comment #19)
> > I tried with a fresh WINEPREFIX and it does not happen, it only happens if
> > "Allow the window manager to decorate the windows" is not ticked.
>
> Hmm, having done a little test on OS X now, and it seems to work with the
> option enabled and disabled. I don't currently have access to a Linux box. What
> window manager are you using?

I didn't notice the comment about that option. I can confirm this on Gnome,
sorta.

Testing on my Karmic laptop (haven't tested desktop), in a fresh WINEPREFIX,
running 'notepad, help, help on help', then choosing no at the next dialog
works fine.

If I turn off window decorations, I get a crash in winhlp32. Notepad continues
to work fine.

Backtrace coming up next.

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16268|0                           |1
        is obsolete|                            |

--- Comment #23 from Austin English   2009-08-02 18:24:22 ---
Created an attachment (id=22787)
 --> (http://bugs.winehq.org/attachment.cgi?id=22787)
backtrace

Though, perhaps this should be a new bug...

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

--- Comment #24 from Rob Shearman   2009-11-08 07:09:23 ---
Patch sent which fixes this:
http://www.winehq.org/pipermail/wine-patches/2009-November/081019.html

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #25 from Austin English   2009-11-11 21:21:54 ---
(In reply to comment #24)
> Patch sent which fixes this:
> http://www.winehq.org/pipermail/wine-patches/2009-November/081019.html

Works fine in git. Thanks Rob!

[Bug 15367] "Using help" or "Help on help" crashes winhlp32

http://bugs.winehq.org/show_bug.cgi?id=15367

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #26 from Alexandre Julliard   2009-11-13 12:43:12 ---
Closing bugs fixed in 1.1.33.