[Bug 56445] New: ArmA: Cold War Assault (and other DX8 titles) crashes in wined3d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56445

Bug ID: 56445
           Summary: ArmA: Cold War Assault (and other DX8 titles) crashes
                    in wined3d
           Product: Wine
           Version: 9.4
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: f6a1844dbed91b441ad69e7b15b5be242d063e87
      Distribution: ---

Created attachment 76205
  --> https://bugs.winehq.org/attachment.cgi?id=76205
terminal output

The affected games crash usually under 1 minute once a mission was started.

Reverting commit f6a1844dbed91b441ad69e7b15b5be242d063e87
fixes the crash for me.

I tried the patches from here but they didn't help:
https://gitlab.winehq.org/wine/wine/-/merge_requests/5328

Can be reproduced with any of the following demo versions.
Just start the available mission that the demo offers and wait until the game
crashes.

Delta Force: BlackHawk Down demo:
https://archive.org/download/DeltaForceBlackHawkDownDemo/DFBHDD.zip

Empire Earth 2 demo:
https://www.moddb.com/games/empire-earth-2/downloads/empire-earth-2-demo-1-1

Operation Flashpoint early demo:
https://archive.org/download/opflashdemo/opflashdemo.exe

wine-9.4-146-g552cc456d18

OpenGL vendor string: NVIDIA Corporation
OpenGL renderer string: NVIDIA GeForce GTX 1660 SUPER/PCIe/SSE2
OpenGL core profile version string: 4.6.0 NVIDIA 550.40.55

[Bug 56445] d3d8 applications run out of memory after f6a1844dbe (ArmA: Cold War Assault, Final Fantasy XI Online)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56445

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|ArmA: Cold War Assault (and |d3d8 applications run out
                   |other DX8 titles) crashes   |of memory after f6a1844dbe
                   |in wined3d                  |(ArmA: Cold War Assault,
                   |                            |Final Fantasy XI Online)

--- Comment #1 from Zeb Figura  ---
Thanks, that was a very stupid error which should be fixed by
https://gitlab.winehq.org/wine/wine/-/merge_requests/5347.

Hopefully that's the only leak I introduced...

[Bug 56445] d3d8 applications run out of memory after f6a1844dbe (ArmA: Cold War Assault, Final Fantasy XI Online)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56445

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Zeb Figura  ---
*** Bug 56446 has been marked as a duplicate of this bug. ***

[Bug 56445] d3d1-9 applications run out of memory after f6a1844dbe (ArmA: Cold War Assault, Final Fantasy XI Online, Far Cry 3)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56445

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|d3d8 applications run out   |d3d1-9 applications run out
                   |of memory after f6a1844dbe  |of memory after f6a1844dbe
                   |(ArmA: Cold War Assault,    |(ArmA: Cold War Assault,
                   |Final Fantasy XI Online)    |Final Fantasy XI Online,
                   |                            |Far Cry 3)

[Bug 56445] d3d1-9 applications run out of memory after f6a1844dbe (ArmA: Cold War Assault, Final Fantasy XI Online, Far Cry 3)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56445

--- Comment #3 from Béla Gyebrószki  ---
(In reply to Zeb Figura from comment #1)
> Thanks, that was a very stupid error which should be fixed by
> https://gitlab.winehq.org/wine/wine/-/merge_requests/5347.

The patch works for me. I tested with a handful of games that are known to be
affected (both DX8 and DX11 titles). Thank you.

[Bug 56445] d3d1-9 applications run out of memory after f6a1844dbe (ArmA: Cold War Assault, Final Fantasy XI Online, Far Cry 3)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56445

--- Comment #4 from Zeb Figura  ---
Well, I accidentally added a line disabling support for the extension
altogether in that patch. Sometimes the cure is just as bad as the disease.

Fortunately, it seems to also work without that line, at least for me.

[Bug 56445] d3d1-9 applications run out of memory after f6a1844dbe (ArmA: Cold War Assault, Final Fantasy XI Online, Far Cry 3)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56445

Vijay Kamuju  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
      Fixed by SHA1|                            |c38df594f5c35ef28986cfd1340
                   |                            |ecfd3eb5969b0

--- Comment #5 from Vijay Kamuju  ---
Fix committed - marking this as closed.
https://source.winehq.org/git/wine.git/commit/c38df594f5c35ef28986cfd1340ecf...

[Bug 56445] d3d1-9 applications run out of memory after f6a1844dbe (ArmA: Cold War Assault, Final Fantasy XI Online, Far Cry 3)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56445

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 9.5.