https://bugs.winehq.org/show_bug.cgi?id=45292
Bug ID: 45292 Summary: SuperTux does not start Product: Wine Version: 3.9 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: tobbi.bugs@googlemail.com Distribution: ---
When I try to start SuperTux 0.5.1 with wine 3.9 it doesn't start at all. The only thing I can see in the terminal is the following:
$ 00ec:fixme:msvcp:_Locinfo__Locinfo_ctor_cat_cstr (0x33f178 1 C) semi-stub 00ec:fixme:msvcp:_Locinfo__Locinfo_ctor_cat_cstr (0x33efc8 1 C) semi-stub 00ec:fixme:msvcp:_Locinfo__Locinfo_ctor_cat_cstr (0x33f168 1 C) semi-stub 00ec:fixme:vcruntime:__telemetry_main_return_trigger (0x370000) 00ec:fixme:vcruntime:__telemetry_main_return_trigger (0x5d0000) 00ec:fixme:vcruntime:__telemetry_main_return_trigger (0x380000)
This is the installer that I used: https://mega.nz/#!AIlh3CDD!9tJWEsYDcnVmXaSHLnbxpIj75bm9MRsiGOjF7-p0EJo
SHA256(SuperTux-v0.5.1-win32.msi)= ff8581d538ce930cf6b01a102867f5aed362d7a1335083c6d7b57487ea45a00d
If there's anything else you need, feel free to tell me.
https://bugs.winehq.org/show_bug.cgi?id=45292
Tobias (:Tobbi) Markus tobbi.bugs@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|SuperTux does not start |SuperTux 0.5.1 does not | |start
https://bugs.winehq.org/show_bug.cgi?id=45292
Tobias (:Tobbi) Markus tobbi.bugs@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Hardware|x86 |x86-64 OS|Linux |Mac OS X
https://bugs.winehq.org/show_bug.cgi?id=45292
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.supertux.org/dow | |nload.html Keywords| |download, source Status|UNCONFIRMED |RESOLVED CC| |z.figura12@gmail.com Resolution|--- |INVALID
--- Comment #1 from Zebediah Figura z.figura12@gmail.com --- Looks like an application bug; it's treating a return value of 0 from CreateDirectory as failure (when in reality the directory already exists):
https://github.com/SuperTux/supertux/blob/master/src/util/file_system.cpp#L5...
I'd file a bug there.
https://bugs.winehq.org/show_bug.cgi?id=45292
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net Summary|SuperTux 0.5.1 does not |SuperTux 0.5.1 does not |start |start (application bug) URL|http://www.supertux.org/dow |https://github.com/SuperTux |nload.html |/supertux/releases/download | |/v0.5.1/SuperTux-v0.5.1-win | |32.msi
--- Comment #2 from Anastasius Focht focht@gmx.net --- Hello folks,
confirming.
Boost documentation for reference:
https://www.boost.org/doc/libs/1_61_0/libs/filesystem/doc/reference.html#cre...
--- quote --- bool create_directory(const path& p); bool create_directory(const path& p, system::error_code& ec);
Effects: Establishes the postcondition by attempting to create the directory p resolves to, as if by ISO/IEC 9945 mkdir() with a second argument of S_IRWXU|S_IRWXG|S_IRWXO. Creation failure because p resolves to an existing directory shall not be treated as an error.
Postcondition: is_directory(p)
Returns: true if a new directory was created, otherwise false.
Throws: As specified in Error reporting. --- quote ---
Boost source:
https://github.com/boostorg/filesystem/blob/6f31d4e07c3c2cd290f39e85385398cd...
Git blame in SuperTux code shows this:
https://github.com/SuperTux/supertux/commit/ebae41b10354bfd71d91de1dd503d900... ("Support unicode usernames on Windows ")
Gotta love the granularity of this changeset. You don't don't push commits that change multiple completely unrelated things but rather prefer small, atomic commits.
They should also use an exception handler here to ignore exceptions thrown by boost's create_directory if the requested directory exists or where path p exists but it wasn't possible for the user to write to the parent directory. Only re-throw on hard-error.
The Github page for the project also hosts the released binaries, no need for for some questionable MEGA site link
https://github.com/SuperTux/supertux/releases
Regards
https://bugs.winehq.org/show_bug.cgi?id=45292
joaopa jeremielapuree@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr
--- Comment #3 from joaopa jeremielapuree@yahoo.fr --- Surely it is an application bug, but winetricks vcrun2017 workarounds the bugs. So, native windows does not complain about that.
https://bugs.winehq.org/show_bug.cgi?id=45292
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |msvcrt Status|RESOLVED |UNCONFIRMED Resolution|INVALID |---
--- Comment #4 from Zebediah Figura z.figura12@gmail.com --- My initial quick analysis was wrong, it's not a bug in SuperTux. That program checks if a directory exists before creating it:
https://github.com/SuperTux/supertux /blob/efcb7886ba4fdc568557c610f7fcf45723aedfef/src/supertux/main.cpp#L273
Unfortunately, our _stat64i32 returns ENOENT when it shouldn't.
https://bugs.winehq.org/show_bug.cgi?id=45292
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|SuperTux 0.5.1 does not |SuperTux 0.5.1 does not |start (application bug) |start
https://bugs.winehq.org/show_bug.cgi?id=45292
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Component|msvcrt |ucrtbase
--- Comment #5 from Zebediah Figura z.figura12@gmail.com --- ucrtbase shouldn't fail stat() when the final character is a path separator. msvcrt does, but ucrtbase shouldn't. I guess we can use ucrtbase's behaviour in both cases.
https://bugs.winehq.org/show_bug.cgi?id=45292
Piotr Caban piotr.caban@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr.caban@gmail.com
--- Comment #6 from Piotr Caban piotr.caban@gmail.com --- It should be fixed by c5cb5e24a30d98aa329e87c3c9e709b16cf43233 commit. Please retest.
https://bugs.winehq.org/show_bug.cgi?id=45292
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |c5cb5e24a30d98aa329e87c3c9e | |709b16cf43233
--- Comment #7 from Gijs Vermeulen gijsvrm@gmail.com --- (In reply to Piotr Caban from comment #6)
Fixed by: 96721e4291378f0c2dfe6948df95691752250b95
(I reproduced the crash before this commit and confirmed that it now works after that commit.)
https://bugs.winehq.org/show_bug.cgi?id=45292
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 3.13.
-
wine-bugs＠winehq.org