[Bug 11893] New: GdipBitmapUnLockBit does not accept null rect pointer

http://bugs.winehq.org/show_bug.cgi?id=11893

Summary: GdipBitmapUnLockBit does not accept null rect pointer
           Product: Wine
           Version: CVS/GIT
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: gdiplus
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

native gdiplus GdipBitmapUnLockBit accepts null pointer to its rect argument
and interprets it as rect for the whole bitmap.

[Bug 11893] GdipBitmapUnLockBit does not accept null rect pointer

http://bugs.winehq.org/show_bug.cgi?id=11893

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Nikolay Sivov   2008-05-17 08:01:04 ---
(In reply to comment #0)
> native gdiplus GdipBitmapUnLockBit accepts null pointer to its rect argument
> and interprets it as rect for the whole bitmap.

Your report seems to be a little quest:
1. GdipBitmapUnLockBit doesn't exist.
2. GdipBitmapUnLockBits doesn't have a rect argument.
3. I hope GdipBitmapLockBits is what you meant.)

If it's so you're right. I tested it on native and it actually behave like you
described.

Please try attached patch (diffed with current git if it's important).
Does it affect any real application or this report is a result of your own
development?

[Bug 11893] GdipBitmapUnLockBit does not accept null rect pointer

http://bugs.winehq.org/show_bug.cgi?id=11893

--- Comment #2 from Nikolay Sivov   2008-05-17 08:02:09 ---
Created an attachment (id=13118)
 --> (http://bugs.winehq.org/attachment.cgi?id=13118)
patch+test case

[Bug 11893] GdipBitmapUnLockBit does not accept null rect pointer

http://bugs.winehq.org/show_bug.cgi?id=11893

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, testcase

[Bug 11893] GdipBitmapUnLockBit does not accept null rect pointer

http://bugs.winehq.org/show_bug.cgi?id=11893

--- Comment #3 from Nikolay Sivov   2008-05-21 16:49:40 ---
Patch committed (commit 36a7f31752bf9ac1eb1a4db649dc375ca8ad88fe)

Please check it again.

[Bug 11893] GdipBitmapUnLockBit does not accept null rect pointer

http://bugs.winehq.org/show_bug.cgi?id=11893

bill lam  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from bill lam   2008-05-22 00:34:25 ---
I tested and confirm resolved.

[Bug 11893] GdipBitmapUnLockBit does not accept null rect pointer

http://bugs.winehq.org/show_bug.cgi?id=11893

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard   2008-05-23 10:38:10 ---
Closing bugs fixed in 1.0-rc2.

[Bug 11893] GdipBitmapUnLockBit does not accept null rect pointer

http://bugs.winehq.org/show_bug.cgi?id=11893

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified