[Bug 33701] New: Explorer crashes when extracting the World of Warcraft icon

http://bugs.winehq.org/show_bug.cgi?id=33701

Bug #: 33701
           Summary: Explorer crashes when extracting the World of Warcraft
                    icon
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Since patch e44f0c8f2de480679abde7883a5161ef9526ed81 (presumably, didn't verify
yet), explorer crashes on Wine startup when World of Warcraft is installed. The
crash occurs when explorer is trying to extract the icon from World of Warcraft
Launcher.exe. Removing C:\users\public\Desktop\World of Warcraft.lnk gets rid
of the icon and the crash.

The last lines before the crash in a +relay log are:
0023:Call shell32.ExtractIconExW(0023eca0 L"C:\Program Files (x86)\World of
Warcraft\World of Warcraft Launcher.exe",00000000,0023e878,00000000,00000001)
ret=7f0009e9c8ba
0023:Call user32.PrivateExtractIconExW(0023eca0 L"C:\Program Files
(x86)\World of Warcraft\World of Warcraft
Launcher.exe",00000000,0023e878,00000000,00000001) ret=7f00113d518c
0023:Call KERNEL32.UnhandledExceptionFilter(0023d0b0) ret=7f0011406ab5
wine: Unhandled page fault on read access to 0x004c3638 at address
0x7f00096397fa (thread 0023), starting debugger...

[Bug 33701] Explorer crashes when extracting the World of Warcraft icon

http://bugs.winehq.org/show_bug.cgi?id=33701

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Regression SHA1|                            |e44f0c8f2de480679abde7883a5
                   |                            |161ef9526ed81

--- Comment #1 from Stefan Dösinger  2013-06-02 08:58:23 CDT ---
Confirming that e44f0c8f2de480679abde7883a5161ef9526ed81 introduced the
regression.

The problem seems to happen with a 64 bit build only. Using a 32 bit build of
notepad to browse to the wow install folder with the file open dialog and
settting the file types to all files shows the wow icon just fine. A 64 bit
build of notepad crashes in the same way as explorer.

Other than the crash with WoW the new desktop icons look really nice btw :-)

[Bug 33701] Explorer crashes when extracting the World of Warcraft icon

http://bugs.winehq.org/show_bug.cgi?id=33701

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 33701] Explorer crashes when extracting the World of Warcraft icon

http://bugs.winehq.org/show_bug.cgi?id=33701

--- Comment #2 from Hans Leidekker  2013-06-03 02:40:39 CDT ---
(In reply to comment #0)
> The last lines before the crash in a +relay log are:
> 0023:Call shell32.ExtractIconExW(0023eca0 L"C:\Program Files (x86)\World of
> Warcraft\World of Warcraft Launcher.exe",00000000,0023e878,00000000,00000001)
> ret=7f0009e9c8ba
> 0023:Call user32.PrivateExtractIconExW(0023eca0 L"C:\Program Files
> (x86)\World of Warcraft\World of Warcraft
> Launcher.exe",00000000,0023e878,00000000,00000001) ret=7f00113d518c
> 0023:Call KERNEL32.UnhandledExceptionFilter(0023d0b0) ret=7f0011406ab5
> wine: Unhandled page fault on read access to 0x004c3638 at address
> 0x7f00096397fa (thread 0023), starting debugger...

Did you get a backtrace?

[Bug 33701] Explorer crashes when extracting the World of Warcraft icon

http://bugs.winehq.org/show_bug.cgi?id=33701

--- Comment #3 from Stefan Dösinger  2013-06-03 11:14:24 CDT ---
Created attachment 44641
  --> http://bugs.winehq.org/attachment.cgi?id=44641
Backtrace

This is a backtrace generated when trying to view the broken icon with
notepad's file open dialog.

[Bug 33701] Explorer crashes when extracting the World of Warcraft icon

http://bugs.winehq.org/show_bug.cgi?id=33701

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |ba40509f90ac45a78a4eee018a5
                   |                            |b19162aaded9f
             Status|NEW                         |RESOLVED
          Component|-unknown                    |user32
         Resolution|                            |FIXED

--- Comment #4 from Hans Leidekker  2013-06-07 04:08:48 CDT ---
Fixed by ba40509f90ac45a78a4eee018a5b19162aaded9f.

[Bug 33701] Explorer crashes when extracting the World of Warcraft icon

http://bugs.winehq.org/show_bug.cgi?id=33701

--- Comment #5 from Stefan Dösinger  2013-06-07 05:30:35 CDT ---
I can confirm that the crash is fixed, both in notepad and explorer. Thanks for
looking into it!

[Bug 33701] Explorer crashes when extracting the World of Warcraft icon

http://bugs.winehq.org/show_bug.cgi?id=33701

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  2013-06-07 15:01:43 CDT ---
Closing bugs fixed in 1.6-rc1.