[Bug 29337] New: Starcraft Campaign Editor shows Wine icon instead of map icon

http://bugs.winehq.org/show_bug.cgi?id=29337

Bug #: 29337
           Summary: Starcraft Campaign Editor shows Wine icon instead of
                    map icon
           Product: Wine
           Version: 1.3.34
          Platform: All
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: user32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 37954
  --> http://bugs.winehq.org/attachment.cgi?id=37954
Wine icon instead of map icon

The Starcraft Campaign Editor shows a Wine icon instead of a map icon in the
upper-left corner.

[Bug 29337] Starcraft Campaign Editor shows Wine icon instead of map icon

http://bugs.winehq.org/show_bug.cgi?id=29337

--- Comment #1 from Alex Henrie  2011-12-12 22:08:28 CST ---
Created attachment 37955
  --> http://bugs.winehq.org/attachment.cgi?id=37955
Possible patch

This patch makes Wine downscale the window's big icon rather than using the
Wine icon. The problem is that using this method, the red X on the icon is not
readable. According to MSDN, if hIconSm is null "the system searches the icon
resource specified by the hIcon member for an icon of the appropriate size to
use as the small icon."[1] I couldn't figure out how to make Wine do this.

[1]
http://msdn.microsoft.com/en-us/library/windows/desktop/ms633577%28v=vs.85%2...

[Bug 29337] Starcraft Campaign Editor shows Wine icon instead of map icon

http://bugs.winehq.org/show_bug.cgi?id=29337

--- Comment #2 from Alex Henrie  2011-12-12 22:10:27 CST ---
Created attachment 37956
  --> http://bugs.winehq.org/attachment.cgi?id=37956
Downscaled map icon

With the patch I posted, the map icon appears but is not readable.

[Bug 29337] Starcraft Campaign Editor shows Wine icon instead of map icon

http://bugs.winehq.org/show_bug.cgi?id=29337

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|user32                      |-unknown
           Platform|All                         |Other

[Bug 29337] Starcraft Campaign Editor shows Wine icon instead of map icon

http://bugs.winehq.org/show_bug.cgi?id=29337

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 29337] Starcraft Campaign Editor shows Wine icon instead of map icon

http://bugs.winehq.org/show_bug.cgi?id=29337

--- Comment #3 from Austin English  2013-12-05 21:51:08 CST ---
This is your friendly reminder that there has been no bug activity for 2 years.
Is this still an issue in current (1.7.7 or newer) wine? If so, please attach
the terminal output in 1.7.7 (see http://wiki.winehq.org/FAQ#get_log).

[Bug 29337] Starcraft Campaign Editor shows Wine icon instead of map icon

http://bugs.winehq.org/show_bug.cgi?id=29337

--- Comment #4 from Alex Henrie  2013-12-06 13:12:22 CST ---
Created attachment 46760
  --> http://bugs.winehq.org/attachment.cgi?id=46760
Wine 1.7.7 log

As requested, here is the log from Wine 1.7.7. There's not much to see.

[Bug 29337] Starcraft Campaign Editor shows Wine icon instead of map icon

http://bugs.winehq.org/show_bug.cgi?id=29337

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46760|application/octet-stream    |text/plain
          mime type|                            |

[Bug 29337] Starcraft Campaign Editor shows Wine icon instead of map icon

http://bugs.winehq.org/show_bug.cgi?id=29337

--- Comment #5 from Alex Henrie  2013-12-06 13:22:10 CST ---
And yes, the problem still exists in Wine 1.7.7.

[Bug 29337] Starcraft Campaign Editor shows Wine icon instead of map icon

https://bugs.winehq.org/show_bug.cgi?id=29337

--- Comment #6 from Austin English  ---
Is this still an issue in 1.7.36?

[Bug 29337] Starcraft Campaign Editor shows Wine icon instead of map icon

https://bugs.winehq.org/show_bug.cgi?id=29337

--- Comment #7 from Alex Henrie  ---
(In reply to Austin English from comment #6)
> Is this still an issue in 1.7.36?

Yes. And there is no difference in the console output between 1.7.7 and 1.7.36.

[Bug 29337] Starcraft Campaign Editor shows Wine icon instead of map icon

https://bugs.winehq.org/show_bug.cgi?id=29337

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |f920dfd6984ca9227900d0f0406
                   |                            |afb3ceb892cc5
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Alex Henrie  ---
Fixed by:
https://source.winehq.org/git/wine.git/commitdiff/3d4db9f28f13a360e87a1a0572...
https://source.winehq.org/git/wine.git/commitdiff/5579967c537255bb17c0e0630d...
https://source.winehq.org/git/wine.git/commitdiff/f920dfd6984ca9227900d0f040...

[Bug 29337] Starcraft Campaign Editor shows Wine icon instead of map icon

https://bugs.winehq.org/show_bug.cgi?id=29337

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.43.