[Bug 36915] New: Among the Sleep crashes when starting a new game (Oculusplugin.dll needs to be disabled)

http://bugs.winehq.org/show_bug.cgi?id=36915

Bug ID: 36915
           Summary: Among the Sleep crashes when starting a new game
                    (Oculusplugin.dll needs to be disabled)
           Product: Wine
           Version: 1.7.22
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: winex11.drv
          Assignee: [e-mail]
          Reporter: [e-mail]

Created attachment 49022
  --> http://bugs.winehq.org/attachment.cgi?id=49022
terminal output

The game uses Unity3d and supports Oculus Rift/Virtual Reality (disabled by
default in the options menu).
When you start a new game from the menu the game crashes once the level is
loaded.

The same crash with Wine 1.2.3/1.4.1/1.6.2/1.7.22.
Setting up virtual desktop mode doesn't help.
Workaround: disable 'Oculusplugin.dll' in winecfg. The dll can be found under
../Among the Sleep_data/Plugins directory.

Demo exists on Steam:
http://store.steampowered.com/app/250620/

Fedora 20
X.Org X Server 1.14.4
Nvidia binary drivers 340.24
XFCE 4.10

[Bug 36915] Among the Sleep crashes when starting a new game (Oculusplugin.dll needs to be disabled)

http://bugs.winehq.org/show_bug.cgi?id=36915

--- Comment #1 from Béla Gyebrószki  ---
Created attachment 49023
  --> http://bugs.winehq.org/attachment.cgi?id=49023
winedbg backtrace

I had to attach winedbg to the already running game to get a backtrace:

Backtrace:
=>0 0x7dfca847 clip_cursor_notify+0x37(hwnd=0x2005e, new_clip_hwnd=(nil))
[/home/gyebro/sources/wine-git/dlls/winex11.drv/mouse.c:466] in winex11
(0x094ce438)
...

[Bug 36915] Among the Sleep crashes when starting a new game (Oculusplugin.dll needs to be disabled)

http://bugs.winehq.org/show_bug.cgi?id=36915

--- Comment #2 from Bruno Jesus  ---
Change the line from file dlls/winex11.drv/mouse.c:
466        else if (hwnd == data->clip_hwnd)

To:
466        else if (data && hwnd == data->clip_hwnd)

It may help you move forward (or crash a little bit later), but it's very weird
that x11drv_init_thread_data was not called previously to fill the "data"
variable.

[Bug 36915] Among the Sleep crashes when starting a new game (Oculusplugin.dll needs to be disabled)

http://bugs.winehq.org/show_bug.cgi?id=36915

--- Comment #3 from Béla Gyebrószki  ---
(In reply to Bruno Jesus from comment #2)
> Change the line from file dlls/winex11.drv/mouse.c:
> 466	    else if (hwnd == data->clip_hwnd)
>
> To:
> 466	    else if (data && hwnd == data->clip_hwnd)
>
> It may help you move forward (or crash a little bit later), but it's very
> weird that x11drv_init_thread_data was not called previously to fill the
> "data" variable.

Instead of crashing the game is freezing now when starting a new game. Bruno,
do you need a debug log with specific debug channels enabled?

[Bug 36915] Among the Sleep crashes when starting a new game (Oculusplugin.dll needs to be disabled)

http://bugs.winehq.org/show_bug.cgi?id=36915

--- Comment #4 from Bruno Jesus  ---
(In reply to Béla Gyebrószki from comment #3)
> Instead of crashing the game is freezing now when starting a new game.
> Bruno, do you need a debug log with specific debug channels enabled?

Sorry, no idea =/

[Bug 36915] Among the Sleep crashes when starting a new game (Oculusplugin.dll needs to be disabled)

https://bugs.winehq.org/show_bug.cgi?id=36915

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]

--- Comment #5 from Béla Gyebrószki  ---
Still present in wine-1.7.37-260-g4c1791f

The patch from wine-staging fixes the issue:
https://github.com/wine-compholio/wine-staging/blob/master/patches/winex11-T...

Fedora 21
XFCE 4.10
XOrg 1.16.3
Nvidia binary drivers 340.76
Among the Sleep v1.3.1 (GOG version)

[Bug 36915] Among the Sleep crashes when starting a new game (Oculusplugin.dll needs to be disabled)

https://bugs.winehq.org/show_bug.cgi?id=36915

--- Comment #6 from Sebastian Lackner  ---
This bug also affects the game Slender - The Arrival (GOG version) after
applying the patch to version 2.0.1.2.

[Bug 36915] Among the Sleep crashes when starting a new game (Oculusplugin.dll needs to be disabled)

https://bugs.winehq.org/show_bug.cgi?id=36915

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |0f3fa3965bf1c680760822b3893
                   |                            |c80e2a98128e8
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Béla Gyebrószki  ---
Thank you Sebastian for pushing the patch in, I almost forgot about this bug.
The crash is fixed by
http://source.winehq.org/git/wine.git/commit/0f3fa3965bf1c680760822b3893c80e...

[Bug 36915] Among the Sleep crashes when starting a new game (Oculusplugin.dll needs to be disabled)

https://bugs.winehq.org/show_bug.cgi?id=36915

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.49.