[Bug 19784] New: cmd doesn't handle ( ) scoping; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

Summary: cmd doesn't handle ( ) scoping; breaks firefox build
           Product: Wine
           Version: 1.1.27
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

bug 15359 and bug 19778 are examples of fancy syntax in firefox's
build scripts that wine's cmd doesn't handle yet.  
Here's one more example:

FOO="bar"
if "%FOO%"=="bar" (
  echo "yup"
) else (
  echo "nope"
)

On both systems, this prints "yup".  But on Wine, it goes on to print

C:>) else (
File not found
C:>echo "nope"
"nope"
C:>)
File not found

[Bug 19784] cmd doesn't handle ( ) scoping; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

--- Comment #1 from Dan Kegel   2009-08-18 21:44:52 ---
Sorry, the first line of the batch file was mistyped, should be

set FOO=bar
if "%FOO%"=="bar" (
  echo "yup"
) else (
  echo "nope"
)

[Bug 19784] cmd doesn't handle ( ) scoping; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

--- Comment #2 from Dan Kegel   2010-01-01 15:41:39 ---
There is partial support for ( and ) in cmd; see
WCMD_ReadAndParseLine in wcmdmain.c

http://source.winehq.org/git/wine.git/?a=blob;f=programs/cmd/wcmdmain.c;hb=H...

and in fact if you type just ( by itself on the
commandline, wine's cmd prompts you properly for
more lines.  It just doesn't seem to handle ('s inside if
statements properly.

[Bug 19784] cmd doesn't handle ( ) scoping; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

--- Comment #3 from Dan Kegel   2010-01-01 15:43:38 ---
I take that back; ( works inside if.  It's the else part that's broken.

[Bug 19784] cmd doesn't handle "else" properly; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|cmd doesn't handle ( )      |cmd doesn't handle "else"
                   |scoping; breaks firefox     |properly; breaks firefox
                   |build                       |build

[Bug 19784] cmd doesn't handle "else" properly; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Dan Kegel   2010-01-01 16:37:56 ---
*** Bug 21142 has been marked as a duplicate of this bug. ***

[Bug 19784] cmd doesn't handle "else" properly; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

--- Comment #5 from Dan Kegel   2010-01-01 18:04:29 ---
Created an attachment (id=25493)
 --> (http://bugs.winehq.org/attachment.cgi?id=25493)
typo fix

This seems to do the trick.

[Bug 19784] cmd doesn't handle "else" properly; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|programs                    |cmd

[Bug 19784] cmd doesn't handle "else" properly; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, source, testcase

--- Comment #6 from Dan Kegel   2010-01-03 21:50:35 ---
Fix and test sent,
http://www.winehq.org/pipermail/wine-patches/2010-January/083445.html

[Bug 19784] cmd doesn't handle "else" properly; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

Jason Edmeades  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Jason Edmeades   2010-01-06 18:26:39 ---
Adding myself to the cmd bugs

[Bug 19784] cmd doesn't handle "else" properly; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

--- Comment #8 from Dan Kegel   2010-02-11 15:31:27 ---
Patch sent again, 
http://www.winehq.org/pipermail/wine-patches/2010-February/084804.html

[Bug 19784] cmd doesn't handle "else" properly; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

--- Comment #9 from Dan Kegel   2010-02-18 01:22:12 ---
Third time's a charm?
http://www.winehq.org/pipermail/wine-patches/2010-February/085014.html

[Bug 19784] cmd doesn't handle "else" properly; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

Paul Vriens  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Paul Vriens   2010-02-19 07:31:45 ---
Patch has been committed: 8110dde8ae405081459b62ae2dbf0710c8332b6b

[Bug 19784] cmd doesn't handle "else" properly; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Dan Kegel   2010-03-04 17:09:40 ---
Marking fixed.

[Bug 19784] cmd doesn't handle "else" properly; breaks firefox build

http://bugs.winehq.org/show_bug.cgi?id=19784

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard   2010-03-05 12:43:06 ---
Closing bugs fixed in 1.1.40.