http://bugs.winehq.org/show_bug.cgi?id=29412
Bug #: 29412 Summary: Right click on system tray icon not work with Qt Product: Wine Version: 1.3.35 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: alpha_one_x86@first-world.info Classification: Unclassified
Hello, the right click on system tray icon don't show menu under wine with Qt 4.8 (work under windows). Example application: http://files.first-world.info/ultracopier/tp/Ultracopier-0.3.0.0-portable-wi...
Thanks to fix it.
http://bugs.winehq.org/show_bug.cgi?id=29412
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source CC| |adys.wh@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=29412
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW URL| |http://files.first-world.in | |fo/ultracopier/tp/Ultracopi | |er-0.3.0.0-portable-win32.z | |ip CC| |00cpxxx@gmail.com Ever Confirmed|0 |1
--- Comment #1 from Bruno Jesus 00cpxxx@gmail.com 2012-10-19 22:30:02 CDT --- I can confirm this issue in wine-git, does not work with and without virtual desktop. Does work in XP.
https://bugs.winehq.org/show_bug.cgi?id=29412
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Abandoned?
--- Comment #2 from Ken Sharp imwellcushtymelike@gmail.com --- Is this still an issue in Wine 1.7.45 or later?
https://bugs.winehq.org/show_bug.cgi?id=29412
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #3 from super_man@post.com --- (In reply to Ken Sharp from comment #2)
Is this still an issue in Wine 1.7.45 or later?
yes the issue is still valid.
The program prints this, which could be related to the issue
fixme:systray:wine_notify_icon unhandled tray message: 4
wine 1.7.55
https://bugs.winehq.org/show_bug.cgi?id=29412
Roman Pisl rpisl@seznam.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rpisl@seznam.cz
--- Comment #4 from Roman Pisl rpisl@seznam.cz --- Created attachment 53758 --> https://bugs.winehq.org/attachment.cgi?id=53758 Systray fix for Qt
Hello, I created this patch that fixes the issue for me on Linux. Tested on Wine version 1.9.4 and Qt version 5.5.
https://bugs.winehq.org/show_bug.cgi?id=29412
Roman Pisl rpisl@seznam.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #53758|0 |1 is obsolete| |
--- Comment #5 from Roman Pisl rpisl@seznam.cz --- Created attachment 53759 --> https://bugs.winehq.org/attachment.cgi?id=53759 Systray fix for Qt - fixed NOTIFYICON_VERSION_4
This is a new version of the patch since the previous didn't work for NOTIFYICON_VERSION_4 correctly. Ultracopier with Qt 4.8 works now as expected.
https://bugs.winehq.org/show_bug.cgi?id=29412
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #6 from winetest@luukku.com --- (In reply to Roman Pisl from comment #5)
Created attachment 53759 [details] Systray fix for Qt - fixed NOTIFYICON_VERSION_4
This is a new version of the patch since the previous didn't work for NOTIFYICON_VERSION_4 correctly. Ultracopier with Qt 4.8 works now as expected.
The patch merges cleanly against wine 1.9.20-git. Also it fixes the issue mentioned here.
I don't know about the correctness of the patch even it fixes the issue. You should sent it over wine-patches mailing list for review so it can be merged into wine.
https://bugs.winehq.org/show_bug.cgi?id=29412
Roman Pisl rpisl@seznam.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #53759|0 |1 is obsolete| |
--- Comment #7 from Roman Pisl rpisl@seznam.cz --- Created attachment 55843 --> https://bugs.winehq.org/attachment.cgi?id=55843 Last version of the patch
I already sent attached patch to wine-patches, but it was rejected. Unfortunately, I don't have time and skills to make it better. It works well for our purpose.
https://bugs.winehq.org/show_bug.cgi?id=29412
--- Comment #8 from winetest@luukku.com --- I already found 3 duplicate bugs of this.
bug 40917 bug 41402 bug 35281
This bug is defitenily not abandoned and should contain keywoard patch.
Also component field should be set. Which seems to be shell32.
https://bugs.winehq.org/show_bug.cgi?id=29412
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|Abandoned? |patch CC| |frederic.delanoy@gmail.com Summary|Right click on system tray |Right click on system tray |icon not work with Qt |icon not work
https://bugs.winehq.org/show_bug.cgi?id=29412
--- Comment #9 from Frédéric Delanoy frederic.delanoy@gmail.com --- I can confirm the patch works with Battle.net on XFCE (xfwm).
https://bugs.winehq.org/show_bug.cgi?id=29412
--- Comment #10 from Frédéric Delanoy frederic.delanoy@gmail.com --- *** Bug 40917 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=29412
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=35281
https://bugs.winehq.org/show_bug.cgi?id=29412
--- Comment #11 from Roman Pisl rpisl@seznam.cz --- I split the patch and re-sent it to wine-patches. I'm convinced it is correct. Sources of information: MSDN (NOTIFYICONDATA structure, Shell_NotifyIcon function) and debugging info (messages from Windows API) from our application.
https://bugs.winehq.org/show_bug.cgi?id=29412
--- Comment #12 from Roman Pisl rpisl@seznam.cz --- Also good source of information for patch review is qsystemtrayicon_win.cpp from the Qt framework.
https://bugs.winehq.org/show_bug.cgi?id=29412
--- Comment #13 from winetest@luukku.com --- Just don't give up if it doesnt go in at 1st attempts.
https://bugs.winehq.org/show_bug.cgi?id=29412
--- Comment #14 from winetest@luukku.com --- Do you think this patch could fix also bug 34585?
I don't know what programs I should test to replicate the issue. I have nothing extra installed really. Just default linux programs.
https://bugs.winehq.org/show_bug.cgi?id=29412
--- Comment #15 from Roman Pisl rpisl@seznam.cz --- I never observed behaviour described in bug 34585 either in clean wine or with the patch (it is an old bug report). I have been testing the patch with several tray applications at the same time and found nothing unexpected so far.
https://bugs.winehq.org/show_bug.cgi?id=29412
--- Comment #16 from winetest@luukku.com --- This bug should be fixed with the following commits
6d7a32a1075999be44f312210766d992a09c735f 9f774ada6c4f5b1bd3ac56bd47f342758028e97a fcad721081ebd60aa6e9dfcc177a6a45b9d7d072 fb70cdb41910cae2bea946702d2dce92f9645963 df8ec3a37125159dbceb1a092d2a109d7aa77727
Also Alexandre added couple of helper functions as commits
b147bd63e39c73ffd5711c2c3209726271a6345f 2e3aa622641238bf5a416ad350779c33a7be4ada
Maybe these patches should be considered next wine stable release.
Great job. I would like to see more work from Roman to get committed.
https://bugs.winehq.org/show_bug.cgi?id=29412
--- Comment #17 from Roman Pisl rpisl@seznam.cz --- I just tested your commits and both ultracopier and our application work as expected. Thank you for merging!
https://bugs.winehq.org/show_bug.cgi?id=29412
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dimesio@earthlink.net
https://bugs.winehq.org/show_bug.cgi?id=29412
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED
--- Comment #18 from Frédéric Delanoy frederic.delanoy@gmail.com --- Works for me too, marking resolved.
https://bugs.winehq.org/show_bug.cgi?id=29412
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #19 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.9.22.