[Bug 20585] New: JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

Summary: JPEG lack of support should not be critical, similar
                    to HTML rendering
           Product: Wine
           Version: 1.1.32
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Quick example with the World of Warcraft Launcher.exe:

adys@azura:$ wine Launcher.exe
err:wincodecs:JpegDecoder_CreateInstance Trying to load JPEG picture, but JPEG
supported not compiled in.
fixme:ole:CoCreateInstance no instance created for interface
{9edde9e7-8dee-47ea-99df-e6faf2ed44bf} of class
{9456a480-e88b-43ea-9e73-0b2d9b71b1ca}, hres is 0x80004005
err:ole:OleLoadPicture IPersistStream_Load failed

The application will show a dialogue "Launcher could not be executed for some
reason."

A neat enhancement would be to have a "disabled" state, very similar to a
disabled HTML rendering.

Of course, an application which relies on JPEG rendering could not be expected
to work properly. This would however fix the issue for many applications which
just load a jpeg on the side.

Untested with png.

[Bug 20585] JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

--- Comment #1 from Vincent Povirk   2009-11-05 11:12:14 ---
This would probably not be difficult, even in the general case. We could create
a dummy decoder object that returns a picture of some text that says X file
decoding is not available.

However, I'm not convinced it's better than simply reporting a failure to the
application.

[Bug 20585] JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #2 from Vitaliy Margolen   2009-11-05 19:55:38 ---
> err:wincodecs:JpegDecoder_CreateInstance Trying to load JPEG picture, but JPEG
> supported not compiled in.

Not compiled in and library not available run-time are two totally different
things. If it's not compiled in - your Wine is broken. This can't be fixed.

[Bug 20585] JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Vitaliy Margolen   2009-11-05 19:56:15 ---
Closing.

[Bug 20585] JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

--- Comment #4 from Jerome Leclanche   2009-11-06 01:41:24 ---
(In reply to comment #3)
> Closing.

It's not compiled in on purpose, this bug was intended to discuss the
possibility to improve the handling of that support.

[Bug 20585] JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

--- Comment #5 from Jeff Zaroyko   2009-11-06 01:57:40 ---
(In reply to comment #4)
> (In reply to comment #3)
> > Closing.
>
> It's not compiled in on purpose, this bug was intended to discuss the
> possibility to improve the handling of that support.

Why?  It's a waste of time.  Seems pointless to add unnecessary lines of code
for an intentionally broken setup.

[Bug 20585] JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

--- Comment #6 from Jerome Leclanche   2009-11-06 02:12:09 ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Closing.
> >
> > It's not compiled in on purpose, this bug was intended to discuss the
> > possibility to improve the handling of that support.
>
> Why?  It's a waste of time.  Seems pointless to add unnecessary lines of code
> for an intentionally broken setup.

Then why have the --without-jpeg configure option at all?

[Bug 20585] JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

--- Comment #7 from Vincent Povirk   2009-11-06 08:33:08 ---
If you don't compile in the optional dependencies (or Wine can't load them at
runtime), the right thing is for the operations that depend on them to fail and
print a message to the console. That way, you can still build a functional Wine
for apps that don't need these features, without putting any hacks in Wine.

[Bug 20585] JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

--- Comment #8 from Vitaliy Margolen   2009-11-06 08:35:42 ---
If you can point me to a version of Windows without support for JPEG you can
reopen this bug.

The fact that Wine let you do something bad doesn't mean you have to do it. If
you compile Wine without support for feature X don't expect programs that use
this feature to work.

[Bug 20585] JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

--- Comment #9 from Jerome Leclanche   2009-11-06 09:33:40 ---
(In reply to comment #8)
> If you can point me to a version of Windows without support for JPEG you can
> reopen this bug.
>
> The fact that Wine let you do something bad doesn't mean you have to do it. If
> you compile Wine without support for feature X don't expect programs that use
> this feature to work.

And I'm not. However, a program that just loads a jpg file somewhere in the
background shouldn't just force quit because it's missing.

[Bug 20585] JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

--- Comment #10 from Dmitry Timoshkov   2009-11-07 06:48:44 ---
(In reply to comment #6)
> Then why have the --without-jpeg configure option at all?

All --without-xxx swicthes exist for packgers who know that their application
doesn't use that feature and want on save on the space of a compiled Wine
binary.

[Bug 20585] JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

Yuriy Postrekhin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Yuriy Postrekhin   2009-12-08 19:41:10 ---
I solved the problem.
If yoy look careful it says that it cannot load windowcodecs.dll
Just download the library (for some reason I got WindowsCodecs.dll), and put it
in WoW folder as windowcodecs.dll and it should work.
Good luck.

[Bug 20585] JPEG lack of support should not be critical, similar to HTML rendering

http://bugs.winehq.org/show_bug.cgi?id=20585

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |windowscodecs