[Bug 17502] New: Portal: Prelude 1.1.5 installer has improper placement of directory selection text
http://bugs.winehq.org/show_bug.cgi?id=17502
Summary: Portal: Prelude 1.1.5 installer has improper placement of directory selection text Product: Wine Version: 1.1.15 Platform: PC URL: http://www.portalprelude.com/download.php#exe_1_1_5 OS/Version: Linux Status: UNCONFIRMED Severity: trivial Priority: P2 Component: richedit AssignedTo: wine-bugs@winehq.org ReportedBy: arethusa26@gmail.com CC: dylan.ah.smith@gmail.com
Created an attachment (id=19602) --> (http://bugs.winehq.org/attachment.cgi?id=19602) Portal: Prelude 1.1.5 installer before revert
With today's Git (wine-1.1.15-221-g79cc416), the heading text in the directory selection phase of the Portal: Prelude 1.1.5 installer does not appear properly. The problem was identified as a regression:
1a3551b630eae2418692f21790fcc7fc973f5366 is first bad commit commit 1a3551b630eae2418692f21790fcc7fc973f5366 Author: Dylan Smith dylan.ah.smith@gmail.com Date: Mon Feb 2 01:32:20 2009 -0500
richedit: Use width from EM_SETTARGETDEVICE for wrapping.
The width for EM_SETTARGETDEVICE is used by some applications to set the wrapping width to a certain distance in twips. This can be used even though the target device is ignored.
:040000 040000 efbf63783320529c2de51eefdbaa1bde15bb209f a237f70a5fff488280157b2876c2f44b223185e5 M dlls
Reverting this commit in HEAD rectified the drawing issue.
http://bugs.winehq.org/show_bug.cgi?id=17502
--- Comment #1 from Andrew Nguyen arethusa26@gmail.com 2009-02-22 04:51:31 --- Created an attachment (id=19603) --> (http://bugs.winehq.org/attachment.cgi?id=19603) Portal: Prelude 1.1.5 installer after revert
http://bugs.winehq.org/show_bug.cgi?id=17502
Andrew Nguyen arethusa26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=17502
Dylan Smith dylan.ah.smith@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED Ever Confirmed|0 |1
--- Comment #2 from Dylan Smith dylan.ah.smith@gmail.com 2009-02-24 01:46:43 --- It seems as if I missed the initialization for nAvailWidth when creating the patch that caused the regression. I created a patch that initializes the value to fix the regression, and I submitted the patch to the wine-patches mailing list.
richedit: Added missing initialization of nAvailWidth for ME_TextEditor. (Bug 17502) http://www.winehq.org/pipermail/wine-patches/2009-February/069841.html
Thanks for catching this bug.
http://bugs.winehq.org/show_bug.cgi?id=17502
--- Comment #3 from Dylan Smith dylan.ah.smith@gmail.com 2009-02-24 11:26:29 --- (In reply to comment #2)
richedit: Added missing initialization of nAvailWidth for ME_TextEditor. (Bug 17502) http://www.winehq.org/pipermail/wine-patches/2009-February/069841.html
My patch that fixes the bug is in the git tree as commit b9b9835f9368c83e15451e04c8e0781012ac4a2f.
Please test and mark the bug as resolved if it works for you.
http://bugs.winehq.org/show_bug.cgi?id=17502
Andrew Nguyen arethusa26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED
--- Comment #4 from Andrew Nguyen arethusa26@gmail.com 2009-02-25 04:41:14 --- Problem seems to be fixed, thanks.
http://bugs.winehq.org/show_bug.cgi?id=17502
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alexandre Julliard julliard@winehq.org 2009-02-27 16:31:50 --- Closing bugs fixed in 1.1.16.
-
wine-bugs＠winehq.org