http://bugs.winehq.org/show_bug.cgi?id=16590
Summary: USP10: Lines not breaking properly Product: Wine Version: 1.1.11 Platform: All OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P3 Component: usp10 AssignedTo: wine-bugs@winehq.org ReportedBy: epp.8@osu.edu
Created an attachment (id=18116) --> (http://bugs.winehq.org/attachment.cgi?id=18116) Filepicker in Wine with builtin usp10.dll
Wine's implementation of USP10 doesn't break lines correctly. I first hit this bug in the Audiosurf filepicker, but I'd imagine it's found elsewhere, as well. Rather than each item having its own line, it's all on one line with no spaces between. Overriding with the native dll displays proper behavior. I made a relay and trawled through it; I'd imagine the culprit is probably ScriptBreak() in dlls/usp10/usp10.c.
Attached is a picture of the behavior that Wine produces (I imagine that the proper behavior is self-evident :).
http://bugs.winehq.org/show_bug.cgi?id=16590
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hans@meelstraat.net
--- Comment #1 from Hans Leidekker hans@meelstraat.net 2008-12-22 03:23:55 --- Please attach a WINEDEBUG=+uniscribe trace.
http://bugs.winehq.org/show_bug.cgi?id=16590
--- Comment #2 from Wyatt Epp epp.8@osu.edu 2008-12-22 06:18:29 --- Created an attachment (id=18123) --> (http://bugs.winehq.org/attachment.cgi?id=18123) tgz of `WINEDEBUG=+uniscribe wine Audiosurf.exe &> uniscribe-log` 3.6 MB
3.6 MB uncompressed; Didn't trim it at all. The app may not have terminated properly, and I didn't switch directories (that added about 100,000 lines to it for each change), but the relevant stuff should be there.
http://bugs.winehq.org/show_bug.cgi?id=16590
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other
http://bugs.winehq.org/show_bug.cgi?id=16590
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|USP10: Lines not breaking |Audiosurf: Lines not |properly |breaking properly
--- Comment #3 from Lei Zhang thestig@google.com 2008-12-22 12:25:21 --- Same problem with the demo on steam?
http://bugs.winehq.org/show_bug.cgi?id=16590
Chad J gamerchad@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gamerchad@gmail.com
--- Comment #4 from Chad J gamerchad@gmail.com 2008-12-24 02:42:40 --- (In reply to comment #3)
Same problem with the demo on steam?
I tried it with the demo on steam, and yeah the problem is there too. x86_64 Gentoo Linux, Wine 1.1.11
http://bugs.winehq.org/show_bug.cgi?id=16590
--- Comment #5 from Hans Leidekker hans@meelstraat.net 2008-12-27 13:34:23 --- Created an attachment (id=18244) --> (http://bugs.winehq.org/attachment.cgi?id=18244) usp10: Handle CR/LF in ScriptItemize.
Please try this patch.
http://bugs.winehq.org/show_bug.cgi?id=16590
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=16590
Wyatt Epp epp.8@osu.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #18116|0 |1 is obsolete| |
--- Comment #6 from Wyatt Epp epp.8@osu.edu 2008-12-28 19:15:45 --- Created an attachment (id=18285) --> (http://bugs.winehq.org/attachment.cgi?id=18285) Result with usp10_crlf.diff applied
Tried the patch with 1.1.11 and it's definitely closer than before: lines are actually breaking; just in the wrong place. It's truncating the last two characters and the first two on each line after the first are in the same place.
http://bugs.winehq.org/show_bug.cgi?id=16590
Wyatt Epp epp.8@osu.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #18123|0 |1 is obsolete| |
--- Comment #7 from Wyatt Epp epp.8@osu.edu 2008-12-28 19:18:41 --- Created an attachment (id=18286) --> (http://bugs.winehq.org/attachment.cgi?id=18286) Updated WINDEBUG=+uniscribe log
Uncompresses to 9.6 MB
http://bugs.winehq.org/show_bug.cgi?id=16590
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #18244|0 |1 is obsolete| |
--- Comment #8 from Hans Leidekker hans@meelstraat.net 2008-12-29 15:43:20 --- Created an attachment (id=18313) --> (http://bugs.winehq.org/attachment.cgi?id=18313) usp10: Handle CR/LF in ScriptItemize + fix for ScriptBreak.
Please try this patch instead of the previous one.
http://bugs.winehq.org/show_bug.cgi?id=16590
Wyatt Epp epp.8@osu.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #18285|0 |1 is obsolete| |
--- Comment #9 from Wyatt Epp epp.8@osu.edu 2008-12-29 19:32:02 --- Created an attachment (id=18318) --> (http://bugs.winehq.org/attachment.cgi?id=18318) New patch, new snapshot.
Getting closer. :) It looks like it's actually drawing the ends of the lines; just not where they belong. Everything now has its first characters, so that, at least, is fixed but for the rest of the line being shifted left.
Thank you for your continued support.
http://bugs.winehq.org/show_bug.cgi?id=16590
Wyatt Epp epp.8@osu.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #18286|0 |1 is obsolete| |
--- Comment #10 from Wyatt Epp epp.8@osu.edu 2008-12-29 19:37:32 --- Created an attachment (id=18319) --> (http://bugs.winehq.org/attachment.cgi?id=18319) Further updated WINDEBUG=+uniscribe log
8.3 MB uncompressed.
Oh yeah, forgot to mention, the latest patch also seems to have fixed what I imagine was a regression in the last patch-- the game was crashing every time a song finished.
http://bugs.winehq.org/show_bug.cgi?id=16590
himynameiszachandiamapirate@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #11 from himynameiszachandiamapirate@gmail.com 2009-01-17 11:45:32 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=16590
himynameiszachandiamapirate@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |himynameiszachandiamapirate@ | |gmail.com
--- Comment #12 from himynameiszachandiamapirate@gmail.com 2009-02-28 12:03:21 --- This is fixed for me in 1.1.16. Can anyone else confirm?
Also, thank you so much for your work, besides the windowed render bug this game is pretty much flawless now. Thank you!
http://bugs.winehq.org/show_bug.cgi?id=16590
--- Comment #13 from Austin English austinenglish@gmail.com 2009-02-28 16:50:24 --- Wyatt, can you confirm?
http://bugs.winehq.org/show_bug.cgi?id=16590
--- Comment #14 from Wyatt Epp epp.8@osu.edu 2009-03-07 04:35:06 --- I'm not currently Audiosurf capable (stuck in driver hell), but I'll see if I can't poke someone I know to test for me.
http://bugs.winehq.org/show_bug.cgi?id=16590
--- Comment #15 from Austin English austinenglish@gmail.com 2009-09-08 11:41:07 --- Is this still an issue in current (1.1.29 or newer) wine?
http://bugs.winehq.org/show_bug.cgi?id=16590
--- Comment #16 from Nikolay Sivov bunglehead@gmail.com 2010-01-09 09:27:25 --- (In reply to comment #8)
Created an attachment (id=18313)
--> (http://bugs.winehq.org/attachment.cgi?id=18313) [details]
usp10: Handle CR/LF in ScriptItemize + fix for ScriptBreak.
Please try this patch instead of the previous one.
This patch was committed as 8a5eae2122478f5f057b1f696523157003d0dbcc. So this is fixed probably.
http://bugs.winehq.org/show_bug.cgi?id=16590
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #17 from Austin English austinenglish@gmail.com 2011-10-01 13:48:17 CDT --- (In reply to comment #16)
(In reply to comment #8)
Created an attachment (id=18313) [details] usp10: Handle CR/LF in ScriptItemize + fix for ScriptBreak.
Please try this patch instead of the previous one.
This patch was committed as 8a5eae2122478f5f057b1f696523157003d0dbcc. So this is fixed probably.
Probably fixed, no activity since.
http://bugs.winehq.org/show_bug.cgi?id=16590
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #18 from Alexandre Julliard julliard@winehq.org 2011-10-10 13:12:43 CDT --- Closing bugs fixed in 1.3.30.
-
wine-bugs＠winehq.org