[Bug 20442] New: visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

Summary: visio 2003 & 2007 crash after 2nd double click on
                    element
           Product: Wine
           Version: 1.1.31
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=24279)
 --> (http://bugs.winehq.org/attachment.cgi?id=24279)
visio debut output

Hi,

After installing visio on a clean prefix, visio 2003 sp3 & 2007 sp1 starts ok.

When u drag and drop an element, and double click on it to name it its ok for
the first time, but if u repeat and double click againg on that element , or
another one, and name it, the application crashes.

I tried on visio 2003 sp3 and 2007 sp1, both have the same error.

I tried without dlls overrides and with dlls overrides (riched20 , native
application gdiplus, mshtml, usp10...) both cases fails with same error.

I attach WINEDEBUG=+tid,+seh,+heap,+relay from visio 2003 sp3 on a clean
wineprefix.

Regards

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

--- Comment #1 from Jaime   2009-10-22 12:10:14 ---
The error appeared on wine 1.1.21

Visio works flawlessly on Wine 1.1.20 with this dlls overriders:

http://ubuntulife.files.wordpress.com/2008/09/wine_visio.png

Regards

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24279|text/plain                  |application/octet-stream
          mime type|                            |

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

chris ahrendt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from chris ahrendt   2010-01-08 19:23:59 ---
happens with latest git

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

Raid  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Raid   2010-01-23 19:03:19 ---
*** This bug has been confirmed by popular vote. ***

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

Raid  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Raid   2010-01-23 19:45:04 ---
Have you tried editing a shape a few times? Crashes when you leave the edit box
the second time.

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

--- Comment #5 from chris ahrendt   2010-01-23 20:15:23 ---
(In reply to comment #4)
> Have you tried editing a shape a few times? Crashes when you leave the edit box
> the second time.

Yes... also double clicking...  and dragging and dropping sometimes

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

Benoit Schneider  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Benoit Schneider   2010-02-23 09:47:11 ---
Hi everyone,

I confirm what say Jaime it's look working find with wine 1.1.20 and the DLL
configuration.

Regards

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

Alexander Scott-Johns  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexander.scott.johns+wineb
                   |                            |[e-mail]

--- Comment #7 from Alexander Scott-Johns   2010-02-24 09:40:56 ---
(In reply to comment #1)
> The error appeared on wine 1.1.21
>
> Visio works flawlessly on Wine 1.1.20 with this dlls overriders:

If this is a regression, please perform a regression test, as described in
http://wiki.winehq.org/RegressionTesting

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

--- Comment #8 from Jaime   2010-03-02 15:18:27 ---
Regresion test result:

43f5b64f06fcd2a835bea41f27cd49074478d7b3 is the first bad commit
commit 43f5b64f06fcd2a835bea41f27cd49074478d7b3
Author: Aric Stewart 
Date:   Thu May 7 14:28:00 2009 -0500

msctf: Implement ITfThreadMgr::Activate and ITfThreadMgr::Deactivate.

:040000 040000 c1c45959dd52df6053c0f572f398f38df1ba8759
bbe2c7189c931728673e72ca7c620e78b7256147 M      dlls

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

--- Comment #9 from Jaime   2010-03-02 15:36:38 ---
As a workaround, adding msctf (native) to the libraries on winecfg (see comment
#1) makes visio 2003 SP3 works again on wine 1.1.39

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

--- Comment #10 from Nikolay Sivov   2010-03-02 15:39:25 ---
(In reply to comment #8)
> Regresion test result:
>
> 43f5b64f06fcd2a835bea41f27cd49074478d7b3 is the first bad commit
> commit 43f5b64f06fcd2a835bea41f27cd49074478d7b3
> Author: Aric Stewart 
> Date:   Thu May 7 14:28:00 2009 -0500

Did you try to revert?

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

--- Comment #11 from Jaime   2010-03-02 15:55:31 ---
 2-3 chunks failed when reverting so i didn't compiled it.

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Nikolay Sivov   2010-03-02 16:08:34 ---
(In reply to comment #11)
> 2-3 chunks failed when reverting so i didn't compiled it.

Ok, it's better to revert by hand then to be sure. I'll CC Aric.

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

--- Comment #13 from Aric Stewart   2010-03-02 16:16:43 ---
(In reply to comment #8)
> Regresion test result:
>
> 43f5b64f06fcd2a835bea41f27cd49074478d7b3 is the first bad commit
> commit 43f5b64f06fcd2a835bea41f27cd49074478d7b3
> Author: Aric Stewart 
> Date:   Thu May 7 14:28:00 2009 -0500
> msctf: Implement ITfThreadMgr::Activate and ITfThreadMgr::Deactivate.
>
> :040000 040000 c1c45959dd52df6053c0f572f398f38df1ba8759
> bbe2c7189c931728673e72ca7c620e78b7256147 M      dlls

Could you generate a +msctf log for me?

-aric

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

--- Comment #14 from Jaime   2010-03-02 16:34:30 ---
Created an attachment (id=26583)
 --> (http://bugs.winehq.org/attachment.cgi?id=26583)
msctf trace

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

--- Comment #15 from Aric Stewart   2010-03-03 08:12:04 ---
(In reply to comment #14)
> Created an attachment (id=26583)

--> (http://bugs.winehq.org/attachment.cgi?id=26583) [details]
> msctf trace

I am still investigating what is going on here, but it looks like something
with the msctf ThreadMgr message pump is causing issue.

I can stop the crash by commenting out

else if (IsEqualIID(iid, &IID_ITfMessagePump))
    {
        *ppvOut = &This->MessagePumpVtbl;
    }

at line 263 of threadmgr.c

I will keep looking. strangely I get the crash in a different place under
winedbg than logging than running normally.

-aric

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

--- Comment #16 from Aric Stewart   2010-03-18 10:42:51 ---
The issue appears to be that without any implementation of
ITfDisplayAttributeMgr Visio was only half initializing the MSCTF state and so
crashing at strange later times.

I have submitted a stub implementation of ITfDisplayAttributeMgr which corrects
this issue.

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

--- Comment #17 from Jaime   2010-04-12 02:32:10 ---
Yeah! it is fixed in 1.1.42. Good work!

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #18 from Dmitry Timoshkov   2010-04-12 02:39:06 ---
Reported fixed.

[Bug 20442] visio 2003 & 2007 crash after 2nd double click on element

http://bugs.winehq.org/show_bug.cgi?id=20442

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Alexandre Julliard   2010-04-16 13:02:45 ---
Closing bugs fixed in 1.1.43.