https://bugs.winehq.org/show_bug.cgi?id=51853
Bug ID: 51853 Summary: Logos 9 Bible Software - Printing Option Available - Does Not Print Product: Wine Version: 6.19 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: franksauer@cox.net Distribution: ---
The same behavior that we experienced with Logos 8 seems to be back in Logos 9.9 running Wine 6.19
https://bugs.winehq.org/show_bug.cgi?id=48716
https://bugs.winehq.org/show_bug.cgi?id=51853
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |printing Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO
--- Comment #1 from Ken Sharp imwellcushtymelike@gmail.com --- If it's fixed then it can't be the same bug. Please provide the console output.
https://wiki.winehq.org/FAQ#How_can_I_get_a_debugging_log_.28a.k.a._terminal...
https://bugs.winehq.org/show_bug.cgi?id=51853
Frank franksauer@cox.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |franksauer@cox.net
--- Comment #2 from Frank franksauer@cox.net --- Created attachment 70926 --> https://bugs.winehq.org/attachment.cgi?id=70926 Requested Log
I have since updated to Wine Staging 6.20 and the Printer Properties are now accessible and changes are able to be made and saved.
Clicking Print still does nothing - whether to PDF or the Printer - Logos is the only app that seems to have this issue
https://bugs.winehq.org/show_bug.cgi?id=51853
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW
--- Comment #3 from Ken Sharp imwellcushtymelike@gmail.com ---
024c:fixme:path:parse_url failed to parse L"System.Printing"
Interesting. Thanks for the log.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #4 from Frank franksauer@cox.net --- No problem - The link to the previous Version of Logos (Logos 8) that I posted, was from a use perspective - the exact same issue. Clicking Print would do nothing, then something changed and it worked perfectly
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #5 from Frank franksauer@cox.net --- Ok...
Seems something somewhere has changed.
With Wine set to Windows 10 - this is the problem. I even did a fully clean install and still nothing would happen when printing to PDF, nor to my printer - both of which worked fine previously.
So, I decided to change some OS settings - changing the Wine install to Windows 7 - both print perfectly now....
Hopefully this helps - as I always ran under Windows 10 previously
https://bugs.winehq.org/show_bug.cgi?id=51853
m0rvj johnpgoodman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |johnpgoodman@gmail.com
--- Comment #6 from m0rvj johnpgoodman@gmail.com --- Which version of Wine and Logos are you using now Frank? I'm seeing a crash with 6.21 immediately when I select print.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #7 from Frank franksauer@cox.net --- (In reply to m0rvj from comment #6)
Which version of Wine and Logos are you using now Frank? I'm seeing a crash with 6.21 immediately when I select print.
Currently still on 6.20.
So you're getting a crash with Win 7 for the prefix?
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #8 from m0rvj johnpgoodman@gmail.com --- I'm on 6.21 I get a crash whether set to win7 or win10. The crash is as I select print. Guess I need to do a regression test.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #9 from m0rvj johnpgoodman@gmail.com --- Created attachment 71004 --> https://bugs.winehq.org/attachment.cgi?id=71004 Terminal output print not registered
What works? I've done a few tests. Going back to the combination of Wine 6.17 and Logos 9.7.0.0025 on Kubuntu 21.10 I have printing to cups PDF printer working. This is as far as I ever got.
What breaks? 2 separate issues... 1) Now on the same system Kubuntu 21.10 with Wine 6.17 and Logos 9.8.0.0010 it no longer prints with the attached terminal output. There is no crash but nothing prints. This must mean a change within the Logos code has caused issues?
2) A separate issue is that Logos 9.7.0.0025 and Logos 9.8.0.0010 both crash when clicking print on wine 6.21 before the print dialog even appears.This will need to be attached in a separate Log. This is presumably a regression which can be found with a bisect. A task for my to do list.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #10 from m0rvj johnpgoodman@gmail.com --- Created attachment 71005 --> https://bugs.winehq.org/attachment.cgi?id=71005 Terminal output from print crash
This terminal output was from Logos 9.7.0.0025 running on wine 6.21. Kubuntu 21.10. I got an instant crash when selecting print from the resource panel. This is issue 2 mentioned above which I suspect is a regression.
System.AccessViolationException\n at MS.Internal.PrintWin32Thunk.Win32ApiThunk.UnsafeNativeMethods.InvokeOpenPrinter(System.String, IntPtr*, MS."... 0158:fixme:advapi:DeregisterEventSource (00000000CAFE4242) stub
Unhandled Exception: System.AccessViolationException: Attempted to read or write protected memory etc
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #11 from m0rvj johnpgoodman@gmail.com --- Created attachment 71010 --> https://bugs.winehq.org/attachment.cgi?id=71010 Regression test log
This is the result of the regression test searching for the crash when clicking on the print item in the panel menu. Prior to this commit you can open the print dialog without a crash.
commit da0db2eb79a666921327bcb6d73ad082e9f5e82d Author: Huw Davies huw@codeweavers.com Date: Wed Oct 27 08:14:46 2021 +0100
winspool: Build with msvcrt.
Signed-off-by: Huw Davies huw@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
configure | 1 - configure.ac | 1 - dlls/winspool.drv/Makefile.in | 3 +- dlls/winspool.drv/cups.c | 47 ++++++------- dlls/winspool.drv/info.c | 157 ++++++++++++++++++++++-------------------- dlls/winspool.drv/wspool.c | 16 ++--- dlls/winspool.drv/wspool.h | 17 +++-- include/config.h.in | 3 - 8 files changed, 121 insertions(+), 124 deletions(-)
https://bugs.winehq.org/show_bug.cgi?id=51853
m0rvj johnpgoodman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |huw@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #12 from m0rvj johnpgoodman@gmail.com --- Created attachment 71012 --> https://bugs.winehq.org/attachment.cgi?id=71012 no print regression test result
The attached is the completion of 2 sets of regression tests. The first looked for the crash on clicking print in the panel menu. While doing this I noticed a point at which there was no crash but in fact printing no longer happened when clicking the final print button in the print dialog. For this reason I went back and did the regression test from that point looking at the behaviour of clicking print. So this second commit appears to be a regression that stops Logos from being able to print even though it was the first one which introduced the crash. Hopefully that makes sense.
Print fails without crash regression commit: commit afc7c0c9d1dabe8a01af3518025d67245318c7dc Author: Jacek Caban jacek@codeweavers.com Date: Mon Sep 13 13:48:52 2021 +0200
winspool: Use configuration file for DeviceCapabilitiesW.
Signed-off-by: Jacek Caban jacek@codeweavers.com Signed-off-by: Huw Davies huw@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
dlls/winspool.drv/info.c | 228 ++++++++++++++++++++++++++++++++--------------- 1 file changed, 155 insertions(+), 73 deletions(-)
Crash on selecting print regression commit: commit da0db2eb79a666921327bcb6d73ad082e9f5e82d Author: Huw Davies huw@codeweavers.com Date: Wed Oct 27 08:14:46 2021 +0100
winspool: Build with msvcrt.
Signed-off-by: Huw Davies huw@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
configure | 1 - configure.ac | 1 - dlls/winspool.drv/Makefile.in | 3 +- dlls/winspool.drv/cups.c | 47 ++++++------- dlls/winspool.drv/info.c | 157 ++++++++++++++++++++++-------------------- dlls/winspool.drv/wspool.c | 16 ++--- dlls/winspool.drv/wspool.h | 17 +++-- include/config.h.in | 3 - 8 files changed, 121 insertions(+), 124 deletions(-)
https://bugs.winehq.org/show_bug.cgi?id=51853
m0rvj johnpgoodman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jacek@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #13 from m0rvj johnpgoodman@gmail.com --- Regression still present for 7.0rc1 would be great to get printing back for the stable release!
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #14 from m0rvj johnpgoodman@gmail.com --- Clicking print in the dialog now results in the following terminal output messages:
0108:err:module:open_builtin_file failed to load .so lib "/tmp/.mount_wine64hSn2f6/lib64/wine/msxml3.dll.so" 0108:err:ole:apartment_add_dll couldn't load in-process dll L"C:\windows\system32\msxml3.dll" 0108:err:ole:com_get_class_object no class object {f6d90f11-9c73-11d3-b32e-00c04f990bb4} could be created for context 0x1 0108:fixme:wtsapi:WTSQuerySessionInformationW Unimplemented class 8 0108:fixme:wtsapi:WTSRegisterSessionNotification Stub 0000000000050088 0x00000000 011c:fixme:d3d:wined3d_check_device_format_conversion output 0x1a625ee0, device_type WINED3D_DEVICE_TYPE_HAL, src_format WINED3DFMT_B8G8R8A8_UNORM, dst_format WINED3DFMT_B8G8R8X8_UNORM stub! 0108:fixme:uiautomation:UiaReturnRawElementProvider (0000000000050088, 0, fffffffc, 000000001DC29830): stub! 0108:fixme:wtsapi:WTSUnRegisterSessionNotification Stub 0000000000050088
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #15 from m0rvj johnpgoodman@gmail.com --- n.b. in wine 7.0rc1 there is no crash which means the second regression is fixed.
The first caused by this commit still stands. Print fails without crash regression commit: commit afc7c0c9d1dabe8a01af3518025d67245318c7dc Author: Jacek Caban jacek@codeweavers.com Date: Mon Sep 13 13:48:52 2021 +0200
winspool: Use configuration file for DeviceCapabilitiesW.
Signed-off-by: Jacek Caban jacek@codeweavers.com Signed-off-by: Huw Davies huw@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
dlls/winspool.drv/info.c | 228 ++++++++++++++++++++++++++++++++--------------- 1 file changed, 155 insertions(+), 73 deletions(-)
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #16 from m0rvj johnpgoodman@gmail.com --- I'm so confused. The packages from winehq for ubuntu version 7.0rc1 fix the crash but printing does not happen. I downloaded the latest git and checked out 7.0rc1 and built it. When I build it myself I get a crash still. That shouldn't happen, they should be the same!
Anyway assuming something in 7.0rc1 has fixed the crash, we can focus on the lack of printing. Looking at the regression commit it appears to me that there is an error in the return variable in info.c line 1824 which reads: ret = config->pDrvDeviceCapabilities(NULL /* FIXME */, pDevice, fwCapability, pOutput, pDevMode);
However I think pPort should be the second return variable not pDevice.
I also note that in line 1814 int ret was previously INT ret. So the return values will all be 4 bytes out? (I'm new to C so please forgive any ignorance here.)
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #17 from m0rvj johnpgoodman@gmail.com --- Less confused the crash is fixed in 7.0rc1-staging.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #18 from m0rvj johnpgoodman@gmail.com --- So I patched up to staging and rebuilt. Again with my home compiled version it crashes when opening the print dialog but when I use the winehq build it opens the dialog but fails to print. Can anyone advise what may be different between my src tree and the prebuilt one?
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #19 from m0rvj johnpgoodman@gmail.com --- Apologies, I seem to have been caught out by the launch script. When I thought I was running on 7.0rc1-staging, the script was picking up a wine app image of v6.5. This has caused me a lot of confusion.
So in short both regressions are still present in 7.0rc1 and staging.
Comment 16 above should be relevant. I'll try to investigate further tomorrow.
I very much hope we can solve it for the 7 release.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #20 from m0rvj johnpgoodman@gmail.com --- Created attachment 71276 --> https://bugs.winehq.org/attachment.cgi?id=71276 crash opening print dialog wine 7.0rc1-staging
Just attaching latest terminal output from crash.
https://bugs.winehq.org/show_bug.cgi?id=51853
Huw Davies huw.davies@physics.ox.ac.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |huw.davies@physics.ox.ac.uk
--- Comment #21 from Huw Davies huw.davies@physics.ox.ac.uk --- The comments in this bug have got so complicated that it's hard to follow what works and what doesn't. Please try to summarize the actual issue again.
For now please stick to using regular Wine and not wine-staging.
If you're finding a difference between your own builds and packaged ones then please attach config.log.
A possible reason why you might find a difference in this case is the lack of cups development files, so please check you have those installed.
When doing a bisect, be sure to run "git clean -f" after you've compiled at each step (this will remove any stale build targets, most notably PE libraries when moving back through a commit which created them).
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #22 from m0rvj johnpgoodman@gmail.com --- Thanks for the guidance Huw... I'm trying to learn all this as I go.
Apologies for my to my mistake with the launch script. I thought that wine 7.0rc1 was being used but actually the environment variable was redirecting me to an older version in an appImage. Having realised my mistake (sorry) I can summarize the situation accurately.
Printing was working until this commit afc7c0c9d1dabe8a01af3518025d67245318c7dc, following the commit you could still get all the way to clicking print in the print dialog but it would not actually print.
There was a second regression da0db2eb79a666921327bcb6d73ad082e9f5e82d following which, even choosing print from the panel menu causes a crash right away. See comment 20 for the terminal crash output.
1st regression commit afc7c0c9d1dabe8a01af3518025d67245318c7dc 2nd regression commit da0db2eb79a666921327bcb6d73ad082e9f5e82d
In comment 16 I was trying to identify what might be the problem with the 1st regression. Having little expertise in this but a keen interest to learn and help. It seems that previously the function took the data, reformatted it and returned it. Following the commit it looks like the port is omitted?
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #23 from Huw Davies huw.davies@physics.ox.ac.uk --- Could you please supply a step-by-step guide to reproducing this? I've already got the app installed, so I don't need installation instructions.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #24 from m0rvj johnpgoodman@gmail.com --- Created attachment 71379 --> https://bugs.winehq.org/attachment.cgi?id=71379 Reproducing Bug
Step 1 is to open a resource which can be printed. The Lexham English Bible is included in the free package and can quickly be opened by typing 'leb' in the command box and selecting it from the search results. It can also be opened from the library panel. See picture attached.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #25 from m0rvj johnpgoodman@gmail.com --- Created attachment 71380 --> https://bugs.winehq.org/attachment.cgi?id=71380 Step 2
Step 2 is to open the panel menu by clicking the three spots on the top right of the Lexham English Bible panel. From the menu select 'Print'.
This should open up a print dialog.
Prior to 1st regression commit afc7c0c9d1dabe8a01af3518025d67245318c7dc
It is possible to print. On my system I can't print via my HP Officejet 8600 but I can print via the cups PDF driver. I will attach a printout in the final step.
Following that 1st 1st regression commit afc7c0c9d1dabe8a01af3518025d67245318c7dc it will open the dialog but when you click print (see step 3) nothing happens.
Following the 2nd regression commit da0db2eb79a666921327bcb6d73ad082e9f5e82d clicking print in this menu doesn't open a print dialog, there is just a crash.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #26 from m0rvj johnpgoodman@gmail.com --- Created attachment 71381 --> https://bugs.winehq.org/attachment.cgi?id=71381 Step 3
This shows the print dialog. It is worth selecting just one verse on the left or you have multiple pages potentially. Then I have selected the cups PDF printer and having rolled back both regressions I can print. I'll attached the printed output in step 4. With just the first regression I can click print but nothing happens.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #27 from m0rvj johnpgoodman@gmail.com --- Created attachment 71382 --> https://bugs.winehq.org/attachment.cgi?id=71382 Printed output
This is an example of 1 verse being printed. I've tried many examples and the main body of the page prints fine, even to multi pages. The footer is always a bit garbled. I guess fixing that would be a feature improvement and is not related to the regression.
I hope that clarifies everything?
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #28 from Huw Davies huw.davies@physics.ox.ac.uk --- I'm stuck on step 1. When I type in 'leb' I only see the items listed under 'Tools' and 'Search'.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #29 from m0rvj johnpgoodman@gmail.com --- Created attachment 71383 --> https://bugs.winehq.org/attachment.cgi?id=71383 library view
It could be opened from the library view instead? Sometimes the command box is not responsive if the install was recent because the databases require indexing which can take a while. This attachment highlights the library panel.
It could also be that you don't have a resource in your library to print? In which case you'd need to 'buy' the free package and have it download the resources? The link to the free resources is here: https://www.logos.com/product/194909/logos-9-basic
Sorry that's one huge difficulty with non-libre software!
Thanks so much for this btw... we are really so grateful.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #30 from Huw Davies huw.davies@physics.ox.ac.uk --- Getting this running with my own version of Wine is proving problematic. Could you generate a +relay,+winspool,+psdrv,+print,+seh log of the issue when running on wine-7.0-rc2 ?
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #31 from m0rvj johnpgoodman@gmail.com --- These will be past the filesize limit... I will email links to you.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #32 from m0rvj johnpgoodman@gmail.com --- Created attachment 71393 --> https://bugs.winehq.org/attachment.cgi?id=71393 Log from crash
Output from: WINEDEBUG=+relay,+winspool,+psdrv,+print,+seh /home/john/wine-versions/linux-amd64/7.0rc2/bin/wine64 "${LOGOS_EXE}" >> /tmp/logoswinedebuglog7.0rc2.txt 2>&1
approx 3mb bzip2
To keep it brief I ran: echo "****Ready to Click Print - manual marker****" > /tmp/logoswinedebuglog7.0rc2.txt just before I pressed the print shortcut.
I've emailed the longer log from the first regression but this one is under 10mb so can be attached.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #33 from Huw Davies huw.davies@physics.ox.ac.uk --- Created attachment 71506 --> https://bugs.winehq.org/attachment.cgi?id=71506 Patch to fix crash
Does the attached patch fix the crash? If so, I believe the first regression should also be fixed.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #34 from m0rvj johnpgoodman@gmail.com --- Huw, thanks that works for me. I'm so grateful you've managed to do this in time for the 7 release!
I can now print to PDF again. I've messaged Frank to see if he can test it too because he had it printing from his actual printer which doesn't work for me. I'll let you know what he says. From my point of view that patch fixes the regression.
I could open up another bug to track the missing characters in the footers and printing to my hp officejet 8600?
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #35 from Frank franksauer@cox.net --- (In reply to m0rvj from comment #34)
Huw, thanks that works for me. I'm so grateful you've managed to do this in time for the 7 release!
I can now print to PDF again. I've messaged Frank to see if he can test it too because he had it printing from his actual printer which doesn't work for me. I'll let you know what he says. From my point of view that patch fixes the regression.
I could open up another bug to track the missing characters in the footers and printing to my hp officejet 8600?
I downloaded the file you posted on Telegram John, but I don't install via the script, so I don't have Logo.sh to edit. So I can't point to the PrintFix directories.
If there is a work around for those of us who do a straight install, I'll test it out - otherwise, we may need it built as an update to the current install.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #36 from Frank franksauer@cox.net --- I was able to get it to test (had to use full paths for every command)
I can confirm that both Printing to PDF and to my Network Printer both work perfectly under Windows 7.
Under Windows 10 - the crash is gone, but clicking Print does nothing for PDF, nor my Printer.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #37 from m0rvj johnpgoodman@gmail.com --- So that confirms the regressions are fixed. I can confirm that setting win10 as the windows version prevents it from working but I've also just tried this with the pre-regression version and the same was true. I think Huw you can safely include the patch for 7 final. We need your advice on how to log bugs for the outstanding issues with print? 1) It needs to work with win10 set. 2) The footers need fixing. 3) Printing to some printers needs resolving.
But these would be enhancements not regressions.
https://bugs.winehq.org/show_bug.cgi?id=51853
Huw Davies huw.davies@physics.ox.ac.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |da0db2eb79a666921327bcb6d73 | |ad082e9f5e82d Resolution|--- |FIXED Status|NEW |RESOLVED Fixed by SHA1| |4fcd040d903fc62c1e53b5eeb60 | |91869b925a8f5
--- Comment #38 from Huw Davies huw.davies@physics.ox.ac.uk --- Fixed by commit 4fcd040d903fc62c1e53b5eeb6091869b925a8f5
https://bugs.winehq.org/show_bug.cgi?id=51853
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #39 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.0-rc5.
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #40 from Frank franksauer@cox.net --- This remains an issue with the prefix set to Win10 (which is required to run updates and may become the minimal supported OS in the near future) - Any ideas on how we can allow this to function with the Prefix set to Win10?
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #41 from Frank franksauer@cox.net --- (In reply to Frank from comment #40)
This remains an issue with the prefix set to Win10 (which is required to run updates and may become the minimal supported OS in the near future) - Any ideas on how we can allow this to function with the Prefix set to Win10?
By issue remaining - we can open the Print Dialog, but clicking print does nothing if Win10 is set, with Win7, clicking Print works fine
https://bugs.winehq.org/show_bug.cgi?id=51853
--- Comment #42 from Austin English austinenglish@gmail.com --- (In reply to Frank from comment #41)
(In reply to Frank from comment #40)
This remains an issue with the prefix set to Win10 (which is required to run updates and may become the minimal supported OS in the near future) - Any ideas on how we can allow this to function with the Prefix set to Win10?
By issue remaining - we can open the Print Dialog, but clicking print does nothing if Win10 is set, with Win7, clicking Print works fine
Open a separate issue for that.