[Bug 27762] New: EVE Online Singularity build crashes on start due to changes in winsock
http://bugs.winehq.org/show_bug.cgi?id=27762
Summary: EVE Online Singularity build crashes on start due to changes in winsock Product: Wine Version: 1.3.23 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: winsock AssignedTo: wine-bugs@winehq.org ReportedBy: phoenix@mail.ru
What to do:
1) Get client at http://content.eveonline.com/EVE_Premium_Setup_273475_m.exe and install it 2) Get Tranquility (live server) -> Singularity (test server) patch at http://content.eveonline.com/test/evepremiumpatch273475-276337_test_m.exe and apply it to installed client 3) Attempt to launch client ./wine "C:\Program Files\CCP\Singularity\eve.exe" /server:singularity
Result: EVE crashes during splash screen. Regression tests blame following commit:
3581d2c6d176fe922ee4c8b05768f18c59c93008 is the first bad commit commit 3581d2c6d176fe922ee4c8b05768f18c59c93008 Author: Hans Leidekker hans@codeweavers.com Date: Tue Jun 14 10:31:26 2011 +0200
ws2_32: Accept NULL lpNumberOfBytesSent for overlapped calls to WSASend/To.
:040000 040000 1d6630a90f16d8837bc0245c99b6fe0148e6094b 0e47b51bc6d283e1b0bccf8b18758b2c6d38fe19 M dlls
I checked with head on it and previous commit and confirmed that EVE Singularity build under wine crashes only after this commit.
Currently it doesn't influence vast majority of EVE players, but when EVE's developer deploys test patch to live server, impact will be much more significant.
http://bugs.winehq.org/show_bug.cgi?id=27762
Anton Vorobyov phoenix@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |phoenix@mail.ru
--- Comment #1 from Anton Vorobyov phoenix@mail.ru 2011-07-11 08:55:11 CDT --- Added some metadata and my email to cc
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #2 from Anton Vorobyov phoenix@mail.ru 2011-07-11 09:01:56 CDT --- Can't add commit author to cc, does anybody know his address he uses for bugzilla?
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #3 from Anton Vorobyov phoenix@mail.ru 2011-07-11 09:26:22 CDT --- There's already some info on this issue, and fix for this bug is available:
http://www.eveonline.com/ingameboard.asp?a=topic&threadID=1521316&pa... http://jan.saell.org/blog/wp-content/uploads/2011/06/overlapped2.zip
It applies cleanly onto 1.3.24 and resolves crash.
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #4 from Dan Kegel dank@kegel.com 2011-07-11 10:39:09 CDT --- Created an attachment (id=35520) --> (http://bugs.winehq.org/attachment.cgi?id=35520) Patch from forum to fix bugs in WS2_recv_base()
I grabbed the patch from the forum and attached it here.
The author should send it to wine-patches, though.
http://bugs.winehq.org/show_bug.cgi?id=27762
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hans@meelstraat.net, | |wylda@volny.cz
--- Comment #5 from Wylda wylda@volny.cz 2011-07-11 10:42:33 CDT --- Few points: * no need to add yourself to CC * that comit fixed bug 19491 - just for reference * Han's email added to CC
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #6 from Anton Vorobyov phoenix@mail.ru 2011-07-11 10:49:28 CDT --- I didn't say that commit is evil by itself and never meant any offence, i just pointed at the fact that it introduced regression :)
Thanks for the other two points.
http://bugs.winehq.org/show_bug.cgi?id=27762
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #7 from Hans Leidekker hans@meelstraat.net 2011-07-11 12:17:59 CDT --- (In reply to comment #6)
I didn't say that commit is evil by itself and never meant any offence, i just pointed at the fact that it introduced regression :)
Eve online previously got an error from WSASend (which perhaps it was able to recover from since you suggest that Eve Online worked before that commit). So the fix for WSASend exposes the crash in WS2_recv_base, and it looks like this function needs similar treatment.
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #8 from Anton Vorobyov phoenix@mail.ru 2011-07-11 12:29:49 CDT --- Actually reverting discussed commit fixed only crash on startup. CCP re-deployed their new networking stuff back to the test server (they had it reverted for some time), so client was unable to connect to server like discussed in that bug report.
Anyway, from user's perspective these two are completely different bugs, so i decided and went on with creating new one.
http://bugs.winehq.org/show_bug.cgi?id=27762
Marco D moonbane@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #9 from Marco D moonbane@gmx.net 2011-07-26 07:53:33 CDT --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=27762
keiouu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |keiouu@gmail.com
--- Comment #10 from keiouu@gmail.com 2011-08-06 11:57:00 CDT --- The attached patch fixes the issue for me, logged into SISI fine after applying it.
http://bugs.winehq.org/show_bug.cgi?id=27762
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |3581d2c6d176fe922ee4c8b0576 | |8f18c59c93008
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #11 from Anton Vorobyov phoenix@mail.ru 2011-08-26 03:42:08 CDT --- Just for the reference - after 30th aug this is going to affect all eve players, as patch will be installed to the live server.
http://bugs.winehq.org/show_bug.cgi?id=27762
Ilya Konovalov aragaer@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |aragaer@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=27762
evanh evanh@clear.net.nz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |evanh@clear.net.nz
--- Comment #12 from evanh evanh@clear.net.nz 2011-09-02 21:52:12 CDT --- Not this time ... http://www.eveonline.com/ingameboard.asp?a=topic&threadID=1521316&pa...
I think Merende Macaco has nailed it. CCP would appear to be waiting on Transgaming to implement this same fix in Cider ... which presumably is relying quite heavily on Winelib.
I've never heard much as to whether there is clear cooperation between Codeweavers and Transgaming or not?
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #13 from evanh evanh@clear.net.nz 2011-09-02 21:56:36 CDT --- PS: Here's the reverted CarbonIO from the deployment patchnotes (Scroll down to Technical section) of Eve - http://www.eveonline.com/updates/patchnotes.asp?patchlogID=233
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #14 from Anton Vorobyov phoenix@mail.ru 2011-09-03 05:23:19 CDT --- Seems like you're right, i'm also seeing multiple reports that EVE Incarna 1.1 is launched successfully on unpatched wine.
What should we do in this case with bug? Close until it reappears?
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #15 from evanh evanh@clear.net.nz 2011-09-03 05:42:41 CDT --- Hell no! It is a Wine bug.
The question is will Transgaming implement a fix and then contribute that to the Wine project? Or maybe Codeweavers or someone else is already working on it and Transgaming knows this and is waiting for it to be done.
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #16 from evanh evanh@clear.net.nz 2011-09-03 05:49:10 CDT --- Or did you create a new bug report for the other part of the problem? If you have then you forgot to attach it to Eve in the AppDB.
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #17 from Henri Verbeet hverbeet@gmail.com 2011-09-03 09:50:29 CDT --- Contributions by Transgaming are fairly rare. See e.g. "git shortlog -s -n --since=5years --author=transgaming" for reference.
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #18 from Anton Vorobyov phoenix@mail.ru 2011-09-03 13:08:09 CDT --- Other part of problem IIRC was described in another bug, but unfortunately i can't find it (could it happen that bug just have been deleted?) - so let's just keep discussion here.
As for keeping bug open - agree, completely forgot that all linked patches are still available. Btw, as for repro steps, here's updated variant:
1) Get latest full client installer at http://content.eveonline.com/EVE_Premium_Setup_267203_m.exe and install it 2) Get intermediate patch http://content.eveonline.com/test/evepremiumpatch267203-273475_m.exe and apply it 3) Get Tranquility (live server) -> Singularity (test server) patch at http://content.eveonline.com/test/evepremiumpatch273475-276337_test_m.exe and apply it 4) Attempt to launch client ./wine "C:\Program Files\CCP\Singularity\eve.exe" /server:singularity
I had to rewrite them because CCP doesn't provide full bundled clients anymore. Besides, due to other bugs it may be necessary to install vc2005 via wineticks.
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #19 from Hans Leidekker hans@meelstraat.net 2011-09-08 07:23:37 CDT --- Can somebody please attach a backtrace?
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #20 from Stephen Smith stephenmsmith@blueyonder.co.uk 2011-09-09 06:16:27 CDT --- Created an attachment (id=36290) --> (http://bugs.winehq.org/attachment.cgi?id=36290) backtrace as requested
http://bugs.winehq.org/show_bug.cgi?id=27762
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com
--- Comment #21 from Bruno Jesus 00cpxxx@gmail.com 2011-09-14 13:10:44 CDT --- Hans Leidekker patch got in:
http://source.winehq.org/git/wine.git/commit/94f431e3eebe44a88752be72a795baf...
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #22 from evanh evanh@clear.net.nz 2011-10-18 08:08:01 CDT --- Low and behold CCP have now deployed CarbonIO on the client - http://www.eveonline.com/updates/patchnotes.asp
Thank you Hans.
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #23 from Hans Leidekker hans@meelstraat.net 2011-10-18 14:49:17 CDT --- (In reply to comment #22)
Low and behold CCP have now deployed CarbonIO on the client - http://www.eveonline.com/updates/patchnotes.asp
Thank you Hans.
So is this bug fixed now?
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #24 from evanh evanh@clear.net.nz 2011-10-18 20:58:29 CDT --- Yep, using Wine 1.3.30, I've not had any of the above listed problems.
I haven't really been testing a great deal though. All I've done is start up a trial account on Eve Online, login and fly around a bit. I believe that covers this bug.
http://bugs.winehq.org/show_bug.cgi?id=27762
Anton Vorobyov phoenix@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #25 from Anton Vorobyov phoenix@mail.ru 2011-10-20 15:52:46 CDT --- As linked patches are no longer available, there's no reasonable way to check it.
http://bugs.winehq.org/show_bug.cgi?id=27762
Anton Vorobyov phoenix@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #26 from Anton Vorobyov phoenix@mail.ru 2011-10-20 15:53:19 CDT --- Closing resolved bug
http://bugs.winehq.org/show_bug.cgi?id=27762
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |RESOLVED
--- Comment #27 from Austin English austinenglish@gmail.com 2011-10-20 16:29:09 CDT --- (In reply to comment #26)
Closing resolved bug
Please don't, it will be closed when the next release is made.
http://bugs.winehq.org/show_bug.cgi?id=27762
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #28 from Alexandre Julliard julliard@winehq.org 2011-10-21 13:49:15 CDT --- Closing bugs fixed in 1.3.31.
http://bugs.winehq.org/show_bug.cgi?id=27762
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |94f431e3eebe44a88752be72a79 | |5baf33e55a213
http://bugs.winehq.org/show_bug.cgi?id=27762
--- Comment #29 from evanh evanh@clear.net.nz 2013-07-07 16:34:34 CDT --- For completeness: Here's the exact 18 Oct 2011 Eve patch notes where CCP deployed the CarbonIO feature - http://community.eveonline.com/news/patch-notes/patch-notes-for-incarna-1.1....
-
wine-bugs＠winehq.org