[Bug 54748] New: Greenshot GDI+ status: PropertyNotFound

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54748

Bug ID: 54748
           Summary: Greenshot GDI+ status: PropertyNotFound
           Product: Wine
           Version: 8.3
          Hardware: x86-64
               URL: https://objects.githubusercontent.com/github-productio
                    n-release-asset-2e65be/36756917/23e6800e-7d29-11e7-8ac
                    5-aa92e5646973?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-
                    Credential=AKIAIWNJYAX4CSVEH53A%2F20230328%2Fus-east-1
                    %2Fs3%2Faws4_request&X-Amz-Date=20230328T165105Z&X-Amz
                    -Expires=300&X-Amz-Signature=311e88c8da4b8ba0ff5ac6008
                    cf054338cd6e18afcf64471443530ddae088db0&X-Amz-SignedHe
                    aders=host&actor_id=0&key_id=0&repo_id=36756917&respon
                    se-content-disposition=attachment%3B%20filename%3DGree
                    nshot-NO-INSTALLER-1.2.10.6-RELEASE.zip&response-conte
                    nt-type=application%2Foctet-stream
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdiplus
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Steps to reproduce:
1) unpack Greenshot-NO-INSTALLER-1.2.10.6-RELEASE.zip
2) wine Greenshot.exe
3) RMB on Greenshot icon in the system tray
4) LMB on "Capture region"
5) Draw a rectangel on your screen

Behavior:
Error window with contents as below.

Expected behavior:
No error window.

Error window contents:
Software version: 1.2.10.6-RELEASE-c2414cf0149a1475ea00520effc01b40087c225c (32
bit)
.NET runtime version: 4.0.30319.42000+
Time: 2023-03-28 18:59:01 +02:00
OS: unknown   (x32)  10.0 build 2600 revision 30000
GDI object count: 0
User object count: 0

Exception: System.Exception
Message: Unknown Error [GDI+ status: PropertyNotFound]

Stack:
  at System.Drawing.GDIPlus.CheckStatus (System.Drawing.Status status)
[0x0022b] in <fc2ea6474c6d4315858618f13de6e72a>:0 
  at System.Drawing.Image.get_PropertyItems () [0x00017] in
<fc2ea6474c6d4315858618f13de6e72a>:0 
  at (wrapper remoting-invoke-with-check)
System.Drawing.Image.get_PropertyItems()
  at GreenshotPlugin.Core.ImageHelper.CloneArea (System.Drawing.Image
sourceImage, System.Drawing.Rectangle sourceRect,
System.Drawing.Imaging.PixelFormat targetFormat) [0x00172] in
<68959698d73243a09b84293d02c00b84>:0 
  at GreenshotPlugin.Core.ImageHelper.Crop (System.Drawing.Image& image,
System.Drawing.Rectangle& cropRectangle) [0x00046] in
<68959698d73243a09b84293d02c00b84>:0 
  at GreenshotPlugin.Core.Capture.Crop (System.Drawing.Rectangle cropRectangle)
[0x0001a] in <68959698d73243a09b84293d02c00b84>:0 
  at Greenshot.Helpers.CaptureHelper.CaptureWithFeedback () [0x00085] in
<64ca337812514938b5bb8fc98fce780b>:0 
  at Greenshot.Helpers.CaptureHelper.MakeCapture () [0x008a0] in
<64ca337812514938b5bb8fc98fce780b>:0 
  at Greenshot.Helpers.CaptureHelper.CaptureRegion (System.Boolean
captureMouse) [0x00008] in <64ca337812514938b5bb8fc98fce780b>:0 
  at Greenshot.MainForm+<>c.<CaptureAreaToolStripMenuItemClick>b__52_0 ()
[0x00000] in <64ca337812514938b5bb8fc98fce780b>:0 
  at System.Windows.Forms.Control.InvokeMarshaledCallbackDo
(System.Windows.Forms.Control+ThreadMethodEntry tme) [0x000c0] in
<d22f8be2dd674c49bd49b314423240b8>:0 
  at System.Windows.Forms.Control.InvokeMarshaledCallbackHelper (System.Object
obj) [0x00029] in <d22f8be2dd674c49bd49b314423240b8>:0 
  at System.Threading.ExecutionContext.RunInternal
(System.Threading.ExecutionContext executionContext,
System.Threading.ContextCallback callback, System.Object state, System.Boolean
preserveSyncCtx) [0x00071] in <e70d6e9587d64cb3abb4b3f99bbf5a0d>:0 
  at System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext
executionContext, System.Threading.ContextCallback callback, System.Object
state, System.Boolean preserveSyncCtx) [0x00000] in
<e70d6e9587d64cb3abb4b3f99bbf5a0d>:0 
  at System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext
executionContext, System.Threading.ContextCallback callback, System.Object
state) [0x0002b] in <e70d6e9587d64cb3abb4b3f99bbf5a0d>:0 
  at System.Windows.Forms.Control.InvokeMarshaledCallback
(System.Windows.Forms.Control+ThreadMethodEntry tme) [0x0004d] in
<d22f8be2dd674c49bd49b314423240b8>:0 
  at System.Windows.Forms.Control.InvokeMarshaledCallbacks () [0x0008a] in
<d22f8be2dd674c49bd49b314423240b8>:0

Terminal output:
0024:fixme:dwmapi:DwmGetWindowAttribute (0003008E 9 0021DA80 16) stub
0024:fixme:uiautomation:UiaClientsAreListening ()
0024:fixme:dwmapi:DwmGetWindowAttribute (00050086 9 0021D620 16) stub
0024:fixme:dwmapi:DwmGetWindowAttribute (00050070 9 0021C850 16) stub

Additional info:
seems to happen on NET 4.5 and Mono as well

[Bug 54748] Greenshot GDI+ status: PropertyNotFound

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54748

Bartosz  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Bartosz  ---
Please check if:

winetricks gdiplus

is resolving the issue for you.

[Bug 54748] Greenshot crashes when drawing rectangle to make screenshot ("GDI+ status: PropertyNotFound")

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54748

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Greenshot GDI+ status:      |Greenshot crashes when
                   |PropertyNotFound            |drawing rectangle to make
                   |                            |screenshot ("GDI+ status:
                   |                            |PropertyNotFound")
           Keywords|                            |download

[Bug 54748] Greenshot crashes when drawing rectangle to make screenshot ("GDI+ status: PropertyNotFound")

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54748

--- Comment #2 from Esme Povirk  ---
Wine's GdipGetAllPropertyItems returns PropertyNotFound for formats other than
GIF or PNG, rather than an empty list as I'd have expected.

[Bug 54748] Greenshot crashes when drawing rectangle to make screenshot ("GDI+ status: PropertyNotFound")

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54748

--- Comment #3 from Bartosz  ---
Unfortunately the previous link is not working correctly.
Here is working download:
https://github.com/greenshot/greenshot/releases/download/Greenshot-RELEASE-1...

You need to also install DotNet 3.5:

$ winetricks dotnet35

[Bug 54748] Greenshot crashes when drawing rectangle to make screenshot ("GDI+ status: PropertyNotFound")

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54748

NSLW  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://objects.githubuserc |https://github.com/greensho
                   |ontent.com/github-productio |t/greenshot/releases/downlo
                   |n-release-asset-2e65be/3675 |ad/Greenshot-RELEASE-1.2.10
                   |6917/23e6800e-7d29-11e7-8ac |.6/Greenshot-NO-INSTALLER-1
                   |5-aa92e5646973?X-Amz-Algori |.2.10.6-RELEASE.zip
                   |thm=AWS4-HMAC-SHA256&X-Amz- |
                   |Credential=AKIAIWNJYAX4CSVE |
                   |H53A%2F20230328%2Fus-east-1 |
                   |%2Fs3%2Faws4_request&X-Amz- |
                   |Date=20230328T165105Z&X-Amz |
                   |-Expires=300&X-Amz-Signatur |
                   |e=311e88c8da4b8ba0ff5ac6008 |
                   |cf054338cd6e18afcf644714435 |
                   |30ddae088db0&X-Amz-SignedHe |
                   |aders=host&actor_id=0&key_i |
                   |d=0&repo_id=36756917&respon |
                   |se-content-disposition=atta |
                   |chment%3B%20filename%3DGree |
                   |nshot-NO-INSTALLER-1.2.10.6 |
                   |-RELEASE.zip&response-conte |
                   |nt-type=application%2Foctet |
                   |-stream                     |

[Bug 54748] Greenshot crashes when drawing rectangle to make screenshot ("GDI+ status: PropertyNotFound")

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54748

Jeff Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Jeff Smith  ---
It appears that when GdipGetPropertySize was called on an image with no
properties,
wine was returning an error that it should not.
System.Drawing.Image.get_PropertyItems was failing on this result:

https://github.com/mono/mono/blob/main/mcs/class/System.Drawing/System.Drawi...

I have submitted a fix for this in
https://gitlab.winehq.org/wine/wine/-/merge_requests/3302

[Bug 54748] Greenshot crashes when drawing rectangle to make screenshot ("GDI+ status: PropertyNotFound")

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54748

--- Comment #5 from Esme Povirk  ---
The MR was merged as b48a37f450ed17d45130ec56eddafd18b36a3187, can someone
retest?

[Bug 54748] Greenshot crashes when drawing rectangle to make screenshot ("GDI+ status: PropertyNotFound")

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54748

David Kahurani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from David Kahurani  ---
(In reply to Esme Povirk from comment #5)
> The MR was merged as b48a37f450ed17d45130ec56eddafd18b36a3187, can someone
> retest?

I'm not sure about this but I tried looking into this maybe one or two weeks
ago. It looks like application had removed the code that was breaking. It
worked perfectly for me following the steps in the first comment.

[Bug 54748] Greenshot crashes when drawing rectangle to make screenshot ("GDI+ status: PropertyNotFound")

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54748

NSLW  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #7 from NSLW  ---
Works. Thanks Jeff Smith.

[Bug 54748] Greenshot crashes when drawing rectangle to make screenshot ("GDI+ status: PropertyNotFound")

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54748

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 8.14.