[Bug 11763] New: Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file .c.

http://bugs.winehq.org/show_bug.cgi?id=11763

Summary: Bug fix and small improvement of function MSVCRT_fputc
                    in dlls/msvcrt/file.c.
           Product: Wine
           Version: CVS/GIT
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: msvcrt
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=11023)
 --> (http://bugs.winehq.org/attachment.cgi?id=11023)
Proposed solution

Bug fix:
In Function MSVCRT_fputc from dlls/msvcrt/file.c, if there are no errors, the
same character that has been written should be returned, but the value should
be converted to an 'unsigned char' before will be returned. Otherwise e.g. if
input character = 0xffffffff, the returned value will not equal to 0xff, we
will 
get EOF instead.

Small improvement:
In my opinion, the function MSVCRT_fputc flushes a buffer when get '\n' and it
is OK, but when the file is opened in binary mode this behaviour is unnecessary
and decrease efficiency.

[Bug 11763] Bug fix and small improvement of function MSVCRT_fputc in dlls/ msvcrt/file.c.

http://bugs.winehq.org/show_bug.cgi?id=11763

Pawel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 11763] Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file.c.

http://bugs.winehq.org/show_bug.cgi?id=11763

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #1 from Austin English   2008-06-12 11:03:58 ---
Is this still an issue in current (1.0-rc4 or newer) wine? Please submit
patches to [e-mail]

[Bug 11763] Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file.c.

http://bugs.winehq.org/show_bug.cgi?id=11763

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |ABANDONED

--- Comment #2 from Austin English   2008-12-11 11:14:25 ---
Abandoned.

[Bug 11763] Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file.c.

http://bugs.winehq.org/show_bug.cgi?id=11763

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Austin English   2008-12-11 11:18:04 ---
Closing.

[Bug 11763] Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file.c.

http://bugs.winehq.org/show_bug.cgi?id=11763

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

[Bug 11763] Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file.c.

http://bugs.winehq.org/show_bug.cgi?id=11763

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other
         OS/Version|All                         |other

--- Comment #4 from Austin English  2012-02-23 15:03:19 CST ---
Removing deprecated 'All' Platform/OS.