https://bugs.winehq.org/show_bug.cgi?id=57293
Bug ID: 57293 Summary: Helicon Focus 8.2.0 regression: open images hangs the application Product: Wine Version: 9.18 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comdlg32 Assignee: wine-bugs@winehq.org Reporter: l.jirkovsky@gmail.com CC: cpabst@codeweavers.com Regression SHA1: b5cbb5562ca1aaf023a588bdc6ccb89220637fc4 Distribution: ArchLinux
Created attachment 77234 --> https://bugs.winehq.org/attachment.cgi?id=77234 console output from wine 9.17 (working)
Using File -> Open Images dialog and selecting images hangs the application since wine 9.18.
The console output of running wine HeliconFocus.exe shows a stack overflow (see the attached logs) which wasn't present before.
I did git bisect and found the following commit as the first bad commit:
b5cbb5562ca1aaf023a588bdc6ccb89220637fc4 is the first bad commit commit b5cbb5562ca1aaf023a588bdc6ccb89220637fc4 Author: Charlotte Pabst cpabst@codeweavers.com Date: Wed Sep 4 13:20:53 2024 +0200
comdlg32: Allow entering a filter in the itemdlg file name field.
Current filter is initially empty and can be set by typing a filter into the file name field or selecting an entry from the file type menu.
Selecting a file type entry with an empty spec leaves the current filter unchanged.
This behavior matches windows more closely and fixes applications that rely on SetFileName() for filtering.
Signed-off-by: Charlotte Pabst cpabst@codeweavers.com
dlls/comdlg32/itemdlg.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 59 insertions(+), 31 deletions(-)
https://bugs.winehq.org/show_bug.cgi?id=57293
--- Comment #1 from Lukas Jirkovsky l.jirkovsky@gmail.com --- Created attachment 77235 --> https://bugs.winehq.org/attachment.cgi?id=77235 console output from wine 9.19 (broken, hangs)
https://bugs.winehq.org/show_bug.cgi?id=57293
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
--- Comment #2 from Fabian Maurer dark.shadow4@web.de --- Similar to bug 57240 (same SHA1) but since it doesn't work in 9.19 it must be different.
I guess it would be helpful being able to reproduce this, is this freely available?
https://bugs.winehq.org/show_bug.cgi?id=57293
--- Comment #3 from Charlotte Pabst cpabst@codeweavers.com --- FYI, I can reproduce the bug and I'm working on it.
https://bugs.winehq.org/show_bug.cgi?id=57293
--- Comment #4 from Fabian Maurer dark.shadow4@web.de --- Ah, never mind then. Thank you!
https://bugs.winehq.org/show_bug.cgi?id=57293
--- Comment #5 from Charlotte Pabst cpabst@codeweavers.com --- My fix was merged as 885cb333. https://gitlab.winehq.org/wine/wine/-/merge_requests/6657
https://bugs.winehq.org/show_bug.cgi?id=57293
Lukas Jirkovsky l.jirkovsky@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #6 from Lukas Jirkovsky l.jirkovsky@gmail.com --- This is awesome, thank you Charlotte! I can confirm Helicon Focus open dialog works perfectly with current wine git (g7ce580d1fa0)
https://bugs.winehq.org/show_bug.cgi?id=57293
Lukas Jirkovsky l.jirkovsky@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |885cb3336304aa6a184efb6a93d | |514f8800075a6
https://bugs.winehq.org/show_bug.cgi?id=57293
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.20.
https://bugs.winehq.org/show_bug.cgi?id=57293
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ralf.habacker@freenet.de
--- Comment #8 from Ralf Habacker ralf.habacker@freenet.de --- (In reply to Charlotte Pabst from comment #5)
My fix was merged as 885cb333. https://gitlab.winehq.org/wine/wine/-/merge_requests/6657
The commit https://gitlab.winehq.org/wine/wine/-/commit/7ce580d1fa0bb3acf98edbc4171ddbc... added by this merge request let build to fail with gcc 7.5 (detected on openSUSE Leap):
[ 264s] gcc -m64 -c -o dlls/coml2/stg_prop.o dlls/coml2/stg_prop.c -Idlls/coml2 -Iinclude -Iinclude/msvcrt -D_UCRT -D__WINESRC__ \ [ 264s] -DWINOLE32API= -Wall -pipe -fvisibility=hidden -fno-stack-protector -fno-strict-aliasing \ [ 264s] -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Winit-self -Wlogical-op \ [ 264s] -Wpointer-arith -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter \ [ 264s] -Wvla -Wwrite-strings -gdwarf-4 -fPIC -fasynchronous-unwind-tables -D_WIN32 -fno-builtin \ [ 264s] -fshort-wchar -Wno-format -mabi=ms -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -g -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 [ 264s] dlls/comdlg32/tests/itemdlg.c: In function 'test_filename': [ 264s] dlls/comdlg32/tests/itemdlg.c:1545:18: error: initializer element is not constant [ 264s] { desc2, long_ext } [ 264s] ^~~~~~~~ [ 264s] dlls/comdlg32/tests/itemdlg.c:1545:18: note: (near initialization for 'filterspec_long[0].pszSpec')
According to https://gitlab.winehq.org/wine/wine/-/wikis/Building-Wine, a minimum gcc version 4.4 is required, which is why it should also be buildable with gcc 7.5.
https://bugs.winehq.org/show_bug.cgi?id=57293
--- Comment #9 from Fabian Maurer dark.shadow4@web.de --- Sure, created a MR here: https://gitlab.winehq.org/wine/wine/-/merge_requests/6707
-
WineHQ Bugzilla