http://bugs.winehq.org/show_bug.cgi?id=17987
Summary: Regression : Autocad toolbars mis-sized Product: Wine Version: unspecified Platform: PC-x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: comctl32 AssignedTo: wine-bugs@winehq.org ReportedBy: max@veneto.com CC: tarasov.igor@gmail.com
Following patch :
2d751ee56afced908d0788b936fa4aac1b29f1a1 is first bad commit commit 2d751ee56afced908d0788b936fa4aac1b29f1a1 Author: Igor Tarasov tarasov.igor@gmail.com Date: Mon Mar 30 21:08:18 2009 +0500
comctl32: Correct handling of toolbar separators size.
:040000 040000 e6b2c5fbb8f61bebfa986286ec302ff2fc7dee7e 74cdeeec62833cd80f9a885599b46a9c7ef6e9e9 M dlls
broke some AutoCAD toolbars, which becomes too small sized horizontally (in particular, layer toolbar).
Ciao
Max
http://bugs.winehq.org/show_bug.cgi?id=17987
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Keywords| |regression Summary|Regression : Autocad |Autocad toolbars mis-sized |toolbars mis-sized | Version|unspecified |1.1.18
--- Comment #1 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-09 19:51:33 --- Screen shot showing the problem will be helpful.
http://bugs.winehq.org/show_bug.cgi?id=17987
--- Comment #2 from Igor Tarasov tarasov.igor@gmail.com 2009-04-10 01:10:34 --- Created an attachment (id=20356) --> (http://bugs.winehq.org/attachment.cgi?id=20356) test patch
Try this patch with latest git.
Not sure if this is the source of problem, but this is where it might be, since msdn states that it should return only cx parameter, and nothing else, and tests.
Another source might be in undocumented buggy behaviour, that was removed with that patch. In case this patch won't help, I'll do another one, trying to reproduce that undocumented behaviour as precise as possible.
http://bugs.winehq.org/show_bug.cgi?id=17987
--- Comment #3 from max@veneto.com 2009-04-10 03:17:35 --- Created an attachment (id=20359) --> (http://bugs.winehq.org/attachment.cgi?id=20359) Screenshot showing bad and correct behaviour
Here the screenshot. As you can see, the layer toolbar is too small in size horizontally and following toolbars are missing.
Your patch didn't solve the problem.
Ciao
Max
http://bugs.winehq.org/show_bug.cgi?id=17987
--- Comment #4 from Igor Tarasov tarasov.igor@gmail.com 2009-04-10 03:23:07 --- Yep, I see. Screenshot shows that the problem is in undocumented behaviour. I'll make the patch later today.
http://bugs.winehq.org/show_bug.cgi?id=17987
max@veneto.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal
--- Comment #5 from max@veneto.com 2009-04-10 03:25:24 --- Putting severity to normal, as it prevents usage of application.
Ciao
Max
http://bugs.winehq.org/show_bug.cgi?id=17987
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hufux@gmx.de
--- Comment #6 from Jeff Zaroyko jeffz@jeffz.name 2009-04-11 19:45:35 --- *** Bug 18008 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=17987
Igor Tarasov tarasov.igor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20356|0 |1 is obsolete| |
--- Comment #7 from Igor Tarasov tarasov.igor@gmail.com 2009-04-12 07:57:33 --- Created an attachment (id=20397) --> (http://bugs.winehq.org/attachment.cgi?id=20397) Toolbar regression fix
Here is a working simple patch.
Better version (that copies native comctl32 behavior closer) is on it's way.
http://bugs.winehq.org/show_bug.cgi?id=17987
NSLW lukasz.wojnilowicz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lukasz.wojnilowicz@gmail.com
--- Comment #8 from NSLW lukasz.wojnilowicz@gmail.com 2009-04-12 09:43:40 --- I encounter the same regression with AutoCAD 2008. I didn't tested above patch. I will wait for better version.
http://bugs.winehq.org/show_bug.cgi?id=17987
--- Comment #9 from Igor Tarasov tarasov.igor@gmail.com 2009-04-17 21:12:56 --- Patch sent: http://www.winehq.org/pipermail/wine-patches/2009-April/071998.html
http://bugs.winehq.org/show_bug.cgi?id=17987
--- Comment #10 from NSLW lukasz.wojnilowicz@gmail.com 2009-04-18 06:14:36 --- (In reply to comment #9) Patch tested and indeed it works.
http://bugs.winehq.org/show_bug.cgi?id=17987
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=17987
--- Comment #11 from Igor Tarasov tarasov.igor@gmail.com 2009-04-20 11:51:26 --- Fix committed: http://source.winehq.org/git/wine.git/?a=commit;h=c037b333c889729b5c1dd5150f...
http://bugs.winehq.org/show_bug.cgi?id=17987
--- Comment #12 from max@veneto.com 2009-04-20 12:19:00 --- (In reply to comment #11)
Fix committed: http://source.winehq.org/git/wine.git/?a=commit;h=c037b333c889729b5c1dd5150f...
Don't you have also some stuff for bugs 4627 / 17743 ? :-)
Ciao
Max
http://bugs.winehq.org/show_bug.cgi?id=17987
max@veneto.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #13 from max@veneto.com 2009-04-20 12:21:11 --- Fixed on current git.
http://bugs.winehq.org/show_bug.cgi?id=17987
--- Comment #14 from NSLW lukasz.wojnilowicz@gmail.com 2009-04-20 13:12:54 --- (In reply to comment #12)
[...] Don't you have also some stuff for bugs 4627 / 17743 ? :-) [...]
It would be great because it touches at least eight tested by myself AutoCAD versions and who knows what else.
http://bugs.winehq.org/show_bug.cgi?id=17987
--- Comment #15 from Igor Tarasov tarasov.igor@gmail.com 2009-04-20 20:29:54 --- I am currently working on several bugs in toolbars code. There's a lot of stuff to be fixed ;)
http://bugs.winehq.org/show_bug.cgi?id=17987
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #16 from Alexandre Julliard julliard@winehq.org 2009-04-24 12:21:59 --- Closing bugs fixed in 1.1.20.
http://bugs.winehq.org/show_bug.cgi?id=17987
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |scallegari@arces.unibo.it
--- Comment #17 from Nikolay Sivov bunglehead@gmail.com 2009-05-12 10:06:52 --- *** Bug 18058 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=17987
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://web.archive.org/web | |/20110711021857/http://cdn0 | |1.foxitsoftware.com/pub/fox | |it/reader/desktop/win/3.x/3 | |.0/enu/FoxitReader30_enu_Se | |tup.exe CC| |focht@gmx.net Regression SHA1| |2d751ee56afced908d0788b936f | |a4aac1b29f1a1 Summary|Autocad toolbars mis-sized |Multiple applications have | |broken toolbars (AutoCAD, | |Foxit Reader 3.0) Keywords| |download Fixed by SHA1| |c037b333c889729b5c1dd5150fd | |c6310d676cd62