http://bugs.winehq.org/show_bug.cgi?id=27829
Summary: Band-in-Box 9 Pro: Regression - corrupted bitmaps Product: Wine Version: unspecified Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: winebugreport@musictechnology.co.za
Toolbar items (icons and radio buttons) render and function incorrectly after the commit below.
f76a3b965c5c5440e2302b86e6b705d590cd23d1 is the first bad commit commit f76a3b965c5c5440e2302b86e6b705d590cd23d1 Author: Wolfram Sang wolfram@the-dreams.de Date: Mon May 10 03:36:27 2010 +0200
user32: Honor bfOffBits in BITMAP_Load.
:040000 040000 153c3db45bd09807ff8d1284af3394bc9605831c 7fd49e8a27b2d17069bc5c09fd8c6712ad554679 M dlls
http://bugs.winehq.org/show_bug.cgi?id=27829
Mark Brand winebugreport@musictechnology.co.za changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wolfram@the-dreams.de
http://bugs.winehq.org/show_bug.cgi?id=27829
--- Comment #1 from Wolfram Sang wolfram@the-dreams.de 2011-07-19 02:29:08 CDT --- Thanks for reporting and bisecting. Can you point me to a freely downloadable demo which shows this bug?
http://bugs.winehq.org/show_bug.cgi?id=27829
--- Comment #2 from Mark Brand winebugreport@musictechnology.co.za 2011-07-19 05:01:18 CDT --- Thanks for acknowledging my post. Sorry, no. This is a Win95 era app, so current demo versions are irrelevant (couple of bbw9demo.exe downloads on the 'net are 194Kb stubs to something else). Further, the installer has never worked on any version of Wine ('file not found error'), so mine runs from a folder copied straight from a WinXP install. I'm surprised this issue hasn't surfaced in respect of other legacy apps, though. Perhaps someone with more insight might be able to link this to other open issues? In any case, f76a3b965c5c5440e2302b86e6b705d590cd23d1 looks straight forward enough, and with guidance I'll happily patch, test and report back. However, I found this while hunting another bug (see ID 27830), whose commit I understand a lot less of. Whatever I can do to help, please let me know.
http://bugs.winehq.org/show_bug.cgi?id=27829
--- Comment #3 from Wolfram Sang wolfram@the-dreams.de 2011-07-19 07:16:12 CDT --- Ok. Then, for starters, can you attach screenshots showing the "good" and "bad" case?
http://bugs.winehq.org/show_bug.cgi?id=27829
--- Comment #4 from Mark Brand winebugreport@musictechnology.co.za 2011-07-19 11:00:39 CDT --- Created an attachment (id=35602) --> (http://bugs.winehq.org/attachment.cgi?id=35602) commit 8ea1f3385a8035477c14997ac37ac511e5c9c7da
http://bugs.winehq.org/show_bug.cgi?id=27829
--- Comment #5 from Mark Brand winebugreport@musictechnology.co.za 2011-07-19 11:02:41 CDT --- Created an attachment (id=35603) --> (http://bugs.winehq.org/attachment.cgi?id=35603) commit f76a3b965c5c5440e2302b86e6b705d590cd23d1
It seems like its a just a vertical offset, and both toolbar icons and radio buttons seem to be fully functional.
http://bugs.winehq.org/show_bug.cgi?id=27829
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Severity|normal |trivial
http://bugs.winehq.org/show_bug.cgi?id=27829
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |user32
http://bugs.winehq.org/show_bug.cgi?id=27829
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |f76a3b965c5c5440e2302b86e6b | |705d590cd23d1
http://bugs.winehq.org/show_bug.cgi?id=27829
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
--- Comment #6 from Jerome Leclanche adys.wh@gmail.com 2011-10-08 17:22:27 CDT --- (In reply to comment #3) What is the update on this bug, please, Wolfram?
http://bugs.winehq.org/show_bug.cgi?id=27829
--- Comment #7 from Wolfram Sang wolfram@the-dreams.de 2011-10-12 14:59:49 CDT --- Well, there is no testcase so I can't reproduce. I also can't find anything suspicious in my patch. From the screenshot, I see that even standard windows icons (e.g. folder up) show the offset, so I wonder if something somewhere else caused the bitmaps to be corrupted and my patch just makes this error visible? Are the bitmaps still corrupted in current wine?
http://bugs.winehq.org/show_bug.cgi?id=27829
--- Comment #8 from Mark Brand winebugreport@musictechnology.co.za 2011-10-13 03:35:58 CDT --- The regression is only visible / testable from f76a3b965c5c5440e2302b86e6b705d590cd23d1 to just before 922e15cbd04fde3d9d4fbb98600f5471420c2daa (see Bug 27830, now marked as a duplicate of Bug 25929). After that, the app doesn't run at all (including latest git wine), so *this* bug might well have been resolved in the meantime - I can't tell. Perhaps I can report back once 25929's been dealt with?
http://bugs.winehq.org/show_bug.cgi?id=27829
Mark Brand winebugreport@musictechnology.co.za changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WORKSFORME
--- Comment #9 from Mark Brand winebugreport@musictechnology.co.za 2011-10-29 07:24:02 CDT --- After the fix to Bug 25929, BiaB is running again - with no sign of the rendering problem referred to in this bug report. Thank you all for your help and patience.
http://bugs.winehq.org/show_bug.cgi?id=27829
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |FIXED
--- Comment #10 from Jerome Leclanche adys.wh@gmail.com 2011-10-29 07:36:29 CDT --- Fixed is the correct resolution.
http://bugs.winehq.org/show_bug.cgi?id=27829
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #11 from Alexandre Julliard julliard@winehq.org 2011-11-04 14:14:06 CDT --- Closing bugs fixed in 1.3.32.
-
wine-bugs＠winehq.org