http://bugs.winehq.org/show_bug.cgi?id=22558
Summary: Harbinger (demo) graphical issue: green artefacts around objects Product: Wine Version: 1.1.43 Platform: x86 URL: http://www.gamershell.com/download_1499.shtml OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d AssignedTo: wine-bugs@winehq.org ReportedBy: gyebro69@gmail.com CC: thunderbird2k@gmail.com
Created an attachment (id=27669) --> (http://bugs.winehq.org/attachment.cgi?id=27669) screenshot showing the issue
In Harbinger (at least the demo is showing the issue) objects are surrounded by green squares in Wine-1.1.43. This was not the case prior to 1.1.43.
Regression testing resulted the following commit:
9fec1a02b9e13969f929a3eed249e67773286033 is the first bad commit commit 9fec1a02b9e13969f929a3eed249e67773286033 Author: Roderick Colenbrander thunderbird2k@gmail.com Date: Mon Apr 5 20:05:15 2010 +0200
wined3d: Disable paletted texture support. It was only offered on a few cards, so can be missed.
:040000 040000 b11ffa7bd20131ea4a3416c5b5b07e0263847c66 71fb12b39fd165362923aa34f5e5283568e688e9 M dlls
Reverting the patch on top of wine-1.1.43-408-g3317fc3 was successful and fixed the issue.
Author of the patch added to CC.
Fedora 12 x86 Nvidia 7xxx series card with driver 195.36.24
http://bugs.winehq.org/show_bug.cgi?id=22558
GyB gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #1 from Roderick Colenbrander thunderbird2k@gmail.com 2010-05-02 16:33:14 --- I'll try to look at this bug tomorrow. Looking at the screenshot I think the game is luckily not using P8 textures anymore but the issue you are seeing is something alpha blending / color keying related.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #2 from Roderick Colenbrander thunderbird2k@gmail.com 2010-05-07 12:48:29 --- Do you have Windows around? If so what does the game look like there? Bug 22559 which is related to this one has a link to an nvidia forum entry about Final Fantasy which shows similar screen shots as you are now. Depending on whether the app is falling back to a non-8bit backend or not these two bugs have to be merged but I guess they aren't the same 'issue'.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #3 from GyB gyebro69@gmail.com 2010-05-07 12:58:58 --- I can't verify what the game looks like under Win because I have no Windows ;)
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #4 from Wylda wylda@volny.cz 2010-05-09 10:36:14 --- Created an attachment (id=27825) --> (http://bugs.winehq.org/attachment.cgi?id=27825) Harbinger demo has graphical problem with blitting
I can't verify what the game looks like under Win because I have no Windows ;)
Hi GyB!
i just did that. WinXP works like charm, i.e. confirming as regression.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #5 from Roderick Colenbrander thunderbird2k@gmail.com 2010-05-09 12:17:12 --- What gpu + drivers did you test this on using XP? On older cards P8 textures are supported while not on newer ones. Not sure if this issue is P8 related or not (likely not).
http://bugs.winehq.org/show_bug.cgi?id=22558
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wylda@volny.cz
--- Comment #6 from Wylda wylda@volny.cz 2010-05-09 13:44:24 ---
What gpu + drivers did you test this on using XP?
Hi Roderick, it's dual boot machine, so HW is the same for wine & winxp.
WinXP: nvidia 8600GT v197.13 (2010-03-25) Linux: nvidia 8600GT v195.36.24 (2010-04-28)
No problem for any traces, if it helps you to look, where wine slip a side.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #7 from Wylda wylda@volny.cz 2010-05-09 13:55:11 ---
OK, i did +wined3d without asking ;)
wine-1.1.42: ============ fixme:win:EnumDisplayDevicesW ((null),0,0x33f0fc,0x00000000), stub! fixme:d3d:swapchain_init Add OpenGL context recreation support to context_validate_onscreen_formats fixme:dsalsa:IDsDriverBufferImpl_SetVolumePan (0x16b30c0,0x16b2fe0): stub fixme:dsalsa:IDsDriverBufferImpl_SetVolumePan (0x16b30c0,0x16b2fe0): stub fixme:dsalsa:IDsDriverBufferImpl_SetVolumePan (0x16b30c0,0x16b2fe0): stub fixme:d3d_shader:gen_color_correction Complex fixup (0x4) not supported
wine-1.1.43: ============ fixme:win:EnumDisplayDevicesW ((null),0,0x33f0cc,0x00000000), stub! fixme:d3d:swapchain_init Add OpenGL context recreation support to context_validate_onscreen_formats err:ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 58 err:ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 64 fixme:dsalsa:IDsDriverBufferImpl_SetVolumePan (0xe26168,0xe260c8): stub fixme:dsalsa:IDsDriverBufferImpl_SetVolumePan (0xe26168,0xe260c8): stub fixme:dsalsa:IDsDriverBufferImpl_SetVolumePan (0xe653b8,0xe260c8): stub
I see obvious "...Can't translate..."
Vitaliy, excuse my direct pasting. I considered attaching, but when it's quite short log...
http://bugs.winehq.org/show_bug.cgi?id=22558
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #8 from Austin English austinenglish@gmail.com 2010-05-09 14:06:57 --- Confirming per comment #4
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #9 from Roderick Colenbrander thunderbird2k@gmail.com 2010-05-09 14:32:20 --- The log indicates that the game attempts to use a different code path which is as expected. The formats shown in the log don't make sense for this game though. Could you make a +ddraw,+d3d_surface log?
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #10 from Wylda wylda@volny.cz 2010-05-09 14:44:52 --- Created an attachment (id=27832) --> (http://bugs.winehq.org/attachment.cgi?id=27832) OK - console log from wine-1.1.44-19-gd2a0188 with reverted commit
The formats shown in the log don't make sense for this game though.
Maybe the difference is because it was taken from different wine versions. So now i attach two log from same version (wine-1.1.44-19-gd2a0188), because i'm still able to revert the 9fec1a02b9e13969f929a3eed249e67773286033 on top of wine-1.1.44-19-gd2a0188.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #11 from Wylda wylda@volny.cz 2010-05-09 14:45:17 --- Created an attachment (id=27833) --> (http://bugs.winehq.org/attachment.cgi?id=27833) BAD - console log from wine-1.1.44-19-gd2a0188
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #12 from Wylda wylda@volny.cz 2010-05-09 14:58:14 ---
Maybe i could spare few bytes to bugzilla. vimdiff shows the relevant part nicely, isn't it?
Roderick, BTW what do you use to visually compare two logs? vimdiff seems to be good enough, but just in case there is something better... ;)
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #13 from Roderick Colenbrander thunderbird2k@gmail.com 2010-05-20 09:02:13 --- The game seems to be using WINED3DFMT_B8G8R8A8_UNORM textures and has a color key set on it with green and alpha at 0xff. I don't know much about classic D3D but I think it doesn't make much sense to set a color key when you have alpha. The code in state.c has various pieces of code to get color keying working. I have the feeling something is wrong there (there are a lot of comments on what piece helps which game). I would have to ask Stefan if he has a suggestion.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #14 from Wylda wylda@volny.cz 2010-06-19 22:58:00 ---
This regression (bisected) is still present in wine-1.2-rc4.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #15 from Wylda wylda@volny.cz 2010-08-20 20:03:53 ---
This regression (bisected) is still present in wine-1.3.1.
PS: Needs reverted commit from bug 23902, otherwise HarbingerDemo won't start.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #16 from Wylda wylda@volny.cz 2010-12-30 19:53:46 CST ---
This regression (bisected) is still present in wine-1.3.10-159-gf284719.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #17 from Wylda wylda@volny.cz 2011-06-20 16:04:06 CDT ---
This regression (bisected) is still present in wine-1.3.22-255-g4c0c0d3.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #18 from Wylda wylda@volny.cz 2011-07-15 15:38:42 CDT ---
This regression (bisected) is still present in wine-1.3.24-174-g4b4dd30.
http://bugs.winehq.org/show_bug.cgi?id=22558
GyB gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |9fec1a02b9e13969f929a3eed24 | |9e67773286033
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #19 from Austin English austinenglish@gmail.com 2011-10-17 18:53:58 CDT --- Still in wine-1.3.30-205-g472a8f7
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #20 from Wylda wylda@volny.cz 2011-12-09 17:53:21 CST ---
Still in wine-1.3.34-202-gb0f704d.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #21 from Henri Verbeet hverbeet@gmail.com 2012-02-15 12:17:23 CST --- Created attachment 38892 --> http://bugs.winehq.org/attachment.cgi?id=38892 patch
The attached patch seems to help for me. Needs tests.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #22 from GyB gyebro69@gmail.com 2012-02-17 09:32:58 CST --- (In reply to comment #21)
Created attachment 38892 [details] patch
The attached patch seems to help for me. Needs tests.
The patch fixes the problem here as well. If that helps I keep testing the patch with other games as well, to see if it causes any regressions.
http://bugs.winehq.org/show_bug.cgi?id=22558
--- Comment #23 from Henri Verbeet hverbeet@gmail.com 2012-02-17 09:45:40 CST --- (In reply to comment #22)
If that helps I keep testing the patch with other games as well, to see if it causes any regressions.
It's probably relatively safe, but some testing never hurts.
http://bugs.winehq.org/show_bug.cgi?id=22558
Michael Curran curran.michaelp@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |curran.michaelp@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=22558
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |9c2575865625360b12b74360a06 | |52199b299934f Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #24 from Austin English austinenglish@gmail.com 2012-02-29 14:16:48 CST --- (In reply to comment #22)
(In reply to comment #21)
Created attachment 38892 [details] patch
The attached patch seems to help for me. Needs tests.
The patch fixes the problem here as well. If that helps I keep testing the patch with other games as well, to see if it causes any regressions.
http://source.winehq.org/git/wine.git/commitdiff/9c2575865625360b12b74360a06...
http://bugs.winehq.org/show_bug.cgi?id=22558
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #25 from Alexandre Julliard julliard@winehq.org 2012-03-02 13:01:35 CST --- Closing bugs fixed in 1.4-rc6.
-
wine-bugs＠winehq.org