[Bug 54368] New: ::DrawGeometry doesn't respect stroke style

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54368

Bug ID: 54368
           Summary: ::DrawGeometry doesn't respect stroke style
           Product: Wine
           Version: 8.0
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: d2d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 73938
  --> https://bugs.winehq.org/attachment.cgi?id=73938
thick lines

There's an application that uses d2d1 to draw its UI, and when the app scales
its workspace the lines get very thick shapes. This seems to be related to
00d8:fixme:d2d:d2d_stroke_style_init transformType 1 is not supported
00d8:fixme:d2d:d2d_device_context_DrawGeometry Ignoring stroke style
000000001F3D8C80.
According to MSDN transformType 1 refers to D2D1_STROKE_TRANSFORM_TYPE_FIXED:
The stroke does not respect the world transform but it does respect the dpi and
stroke width.

[Bug 54368] ::DrawGeometry doesn't respect stroke style

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54368

--- Comment #1 from Dmitry Timoshkov  ---
Created attachment 73939
  --> https://bugs.winehq.org/attachment.cgi?id=73939
Tentative patch

This patch for ::DrawGeometry() seems to fix the bug, probably other drawing
methods need a similar treatment.

[Bug 54368] ::DrawGeometry doesn't respect stroke style

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54368

--- Comment #2 from Dmitry Timoshkov  ---
Created attachment 73940
  --> https://bugs.winehq.org/attachment.cgi?id=73940
good lines

How the lines look like with the patch. This seems to match Windows behaviour.

[Bug 54368] ::DrawGeometry doesn't respect stroke style

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54368

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |6dd11426e0a1083366760e3834a
                   |                            |7098ffc0b1b1b
         Resolution|---                         |FIXED

--- Comment #3 from Dmitry Timoshkov  ---
Fix committed as 6dd11426e0a1083366760e3834a7098ffc0b1b1b.

[Bug 54368] ::DrawGeometry doesn't respect stroke style

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54368

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 8.16.