http://bugs.winehq.org/show_bug.cgi?id=21608
Summary: EVE Online ship icon rendering broken Product: Wine Version: 1.1.38 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d AssignedTo: wine-bugs@winehq.org ReportedBy: reboot@gmx.ch
Created an attachment (id=26080) --> (http://bugs.winehq.org/attachment.cgi?id=26080) Screenshot of Missing Icons
EVE Online does not render ship icons anymore in some places, for example the market window or the show info window (see attached screenshot).
I bisected the problem with git with the following result:
af7dfcd378739127c50aa95ce40b13eb3d1950cf is the first bad commit commit af7dfcd378739127c50aa95ce40b13eb3d1950cf Author: Henri Verbeet hverbeet@codeweavers.com Date: Wed Feb 3 18:17:58 2010 +0100
wined3d: Do not preload surfaces when attaching them to an FBO.
Just make sure the texture is allocated, so we have something to attach. Note also that context_apply_attachment_filter_states() runs under the GL lock, so preloading resources is actually unsafe there.
:040000 040000 a5b33a88b1083522cd572e82b6cd2d8ad8a61929 e0f98f84e49335d45deea11a36598e052e9e02d5 M dlls
http://bugs.winehq.org/show_bug.cgi?id=21608
Christoph Hohmann reboot@gmx.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=21608
Christoph Korn c_korn@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |c_korn@gmx.de, | |hverbeet@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #1 from Christoph Korn c_korn@gmx.de 2010-02-06 07:05:51 --- CCing the author.
I hope this is the correct email address.
http://bugs.winehq.org/show_bug.cgi?id=21608
evanh evanh@clear.net.nz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #2 from evanh evanh@clear.net.nz 2010-02-11 19:00:59 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=21608
Anton Vorobyov phoenix@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |phoenix@mail.ru
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #3 from Anton Vorobyov phoenix@mail.ru 2010-02-12 05:40:01 --- Just confirming that revert of the bisected commit fixes problem.
http://bugs.winehq.org/show_bug.cgi?id=21608
Octavian Voicu octavian.voicu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |octavian.voicu@gmail.com
--- Comment #4 from Octavian Voicu octavian.voicu@gmail.com 2010-02-13 21:56:32 --- Did you try with the latest git version and did you delete the cache folder?
I used to have a similar problem (some of the icons had a white background), but latest version seems to work fine -- I have icons and they have the correct background.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #5 from Anton Vorobyov phoenix@mail.ru 2010-02-14 03:35:23 --- Yes i did.
http://bugs.winehq.org/show_bug.cgi?id=21608
Kaczor mrkaczor@interia.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mrkaczor@interia.pl
--- Comment #6 from Kaczor mrkaczor@interia.pl 2010-02-23 08:30:15 --- On wine 1.1.38 Debian 5.0 i got crash when clicking "show info" on ship and when I focus on stations fe. - are there any solutions for now?
I have error: "wine: Unhandled page fault on read access to 0x00000000 at address 0x3d5fbac (thread 001c), starting debugger..."
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #7 from Kaczor mrkaczor@interia.pl 2010-02-23 10:19:43 --- Ok, Ive installed 1.1.39 and now game don't crash but I can confirm no icon.
http://bugs.winehq.org/show_bug.cgi?id=21608
Timo tr@gtnw.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tr@gtnw.de
--- Comment #8 from Timo tr@gtnw.de 2010-02-25 10:25:30 --- I have the same issue, maybe some light can be shed, by providing some system information:
ubuntu lucid 2.6.32-14-generic-pae NVIDIA-Linux-x86-190.53-pkg1 wine-1.1.39
GeForce 9600M GS Asus Laptop
Thanks for the works on this. If you need any more info, let me know.
http://bugs.winehq.org/show_bug.cgi?id=21608
Bas Koopmans winebugs@badako.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winebugs@badako.nl
--- Comment #9 from Bas Koopmans winebugs@badako.nl 2010-03-03 07:53:02 --- Confirming this bug. The update to wine 1.1.39 (from 1.1.36) has caused some of the icons depicting ships to stay black. Removing cache does not solve this issue.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #10 from Anton Vorobyov phoenix@mail.ru 2010-03-03 12:45:18 --- Is Henri aware of this issue? When i've sent my previous comment his gmail was excluded from subscription list. His email mentioned in commit cannot be added to cc list.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #11 from Henri Verbeet hverbeet@gmail.com 2010-03-03 12:58:39 --- (In reply to comment #10)
Is Henri aware of this issue?
Yeah. I'm fairly certain it's not a simple flaw in the patch though, so it would need some proper debugging. I'm pretty busy at the moment though. If someone else wants to look at this though, a good place to start would probably be to look at for which of the callers the preload makes a difference. color_fill_fbo() would be at the top of my list of suspects, although for no particular reason.
http://bugs.winehq.org/show_bug.cgi?id=21608
Karsten Elfenbein kelfe@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kelfe@gmx.de
http://bugs.winehq.org/show_bug.cgi?id=21608
N3o diafoirus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |diafoirus@gmail.com
--- Comment #12 from N3o diafoirus@gmail.com 2010-03-06 12:53:55 --- ****** Reporting fixed on Wine 1.1.40 ********
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #13 from Henri Verbeet hverbeet@gmail.com 2010-03-06 13:02:36 --- (In reply to comment #12)
****** Reporting fixed on Wine 1.1.40 ********
That's nice to hear, but also somewhat suspicious, since no commits went in between 1.1.39 and 1.1.40 that look likely to have fixed this. If it's not too much trouble, would you (or anyone else affected by this) mind running a (reverse) regression test to determine the commit that fixed this?
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #14 from Karsten Elfenbein kelfe@gmx.de 2010-03-06 13:20:48 --- still broken
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #15 from N3o diafoirus@gmail.com 2010-03-07 00:27:45 --- Created an attachment (id=26654) --> (http://bugs.winehq.org/attachment.cgi?id=26654) Wine 1.1.40 fixed the icons render on market
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #16 from N3o diafoirus@gmail.com 2010-03-07 00:28:34 --- (In reply to comment #14)
still broken
I did again a fresh install, clean .wine directory, etc... I used full client EVE_Premium_Setup_127381_m.exe, my setup is:
Phenom X4 9950 Black Edition, 4GB Dominator 1066Mhz Corsair, EVGA 9800 GTX+ in PCI-e 2.0 slot, Wine 1.1.40 compiled, NVIDIA UNIX x86 Kernel Module 190.32 compiled, Linux Kernel 2.6.29.6, Audigy 2 ZS Platinum
and all icons is rendered correctly, I did attach on this comment one screenshot (With the same ship name used on original reporter' screenshot), + another windows opened....
See Wine 1.1.40 fixed the icons render on market attachment
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #17 from N3o diafoirus@gmail.com 2010-03-07 00:31:43 --- (In reply to comment #13)
(In reply to comment #12)
****** Reporting fixed on Wine 1.1.40 ********
That's nice to hear, but also somewhat suspicious, since no commits went in between 1.1.39 and 1.1.40 that look likely to have fixed this. If it's not too much trouble, would you (or anyone else affected by this) mind running a (reverse) regression test to determine the commit that fixed this?
Anton Vorobyov confirmed the bisect on his coment: http://bugs.winehq.org/show_bug.cgi?id=21608#c3 :
Bisect :
af7dfcd378739127c50aa95ce40b13eb3d1950cf is the first bad commit commit af7dfcd378739127c50aa95ce40b13eb3d1950cf Author: Henri Verbeet hverbeet@codeweavers.com Date: Wed Feb 3 18:17:58 2010 +0100
wined3d: Do not preload surfaces when attaching them to an FBO.
Just make sure the texture is allocated, so we have something to attach. Note also that context_apply_attachment_filter_states() runs under the GL lock, so preloading resources is actually unsafe there.
:040000 040000 a5b33a88b1083522cd572e82b6cd2d8ad8a61929 e0f98f84e49335d45deea11a36598e052e9e02d5 M dlls
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #18 from N3o diafoirus@gmail.com 2010-03-07 00:36:30 ---
That's nice to hear, but also somewhat suspicious, since no commits went in between 1.1.39 and 1.1.40 that look likely to have fixed this. If it's not too much trouble, would you (or anyone else affected by this) mind running a (reverse) regression test to determine the commit that fixed this?
Ok Henry I'll help you... I'll do a reverse bisect... give me 2 days (I'm full currently)...
Fly safe
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #19 from Anton Vorobyov phoenix@mail.ru 2010-03-07 05:05:08 --- Still reproducible (ship icons in market, thumbs in actions pane, icons of locked targets). Check if you reverted that commit, most likely it's the explanation.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #20 from Octavian Voicu octavian.voicu@gmail.com 2010-03-07 06:27:44 --- I think there are multiple instances of this bug. For example, I could see the ship icons, but the wormhole icons in overview were black.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #21 from Christoph Hohmann reboot@gmx.ch 2010-03-07 06:52:58 --- Not working for me with 1.1.40. Not in hangar, market or target locks.
If you are testing different build, you have to make sure that you clear the cache before you make the client render any icons, otherwise it will just display the prerendered image from the last test.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #22 from N3o diafoirus@gmail.com 2010-03-07 13:04:02 --- (In reply to comment #19)
Still reproducible (ship icons in market, thumbs in actions pane, icons of locked targets). Check if you reverted that commit, most likely it's the explanation.
I'm using vanilla 1.1.40, not patches, not regression bisect, Full Fresh eve install, nothing special.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #23 from N3o diafoirus@gmail.com 2010-03-07 13:06:10 --- (In reply to comment #19)
Still reproducible (ship icons in market, thumbs in actions pane, icons of locked targets). Check if you reverted that commit, most likely it's the explanation.
What locked target is viewing with black box ?... I'll test the same locked targets only for check...
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #24 from N3o diafoirus@gmail.com 2010-03-07 13:08:10 --- (In reply to comment #21)
Not working for me with 1.1.40. Not in hangar, market or target locks.
If you are testing different build, you have to make sure that you clear the cache before you make the client render any icons, otherwise it will just display the prerendered image from the last test.
I'm using vanilla 1.1.40, not patches, not regression bisect, Full Fresh eve install (from creation of .wine directory to do an Eve Full install), nothing special.
http://bugs.winehq.org/show_bug.cgi?id=21608
evanh evanh@clear.net.nz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |evanh@clear.net.nz
--- Comment #25 from evanh evanh@clear.net.nz 2010-03-07 19:59:38 --- Have you also removed the old cache files? Anything that already has it's icon rendered doesn't get rerendered thereby not triggering the bug.
They are not with the main install of Eve.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #26 from N3o diafoirus@gmail.com 2010-03-07 20:02:39 --- (In reply to comment #25)
Have you also removed the old cache files? Anything that already has it's icon rendered doesn't get rerendered thereby not triggering the bug.
They are not with the main install of Eve.
I remove the .wine directory with all it contents (the best for test is delete the .wine directory and do all again: winecfg, and later install Eve)...not patches, not regression bisect, Full Fresh eve install (from creation of .wine directory to do an Eve Full install), nothing special.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #27 from N3o diafoirus@gmail.com 2010-03-07 20:03:21 --- (In reply to comment #25)
Have you also removed the old cache files? Anything that already has it's icon rendered doesn't get rerendered thereby not triggering the bug.
They are not with the main install of Eve.
I did remove the .wine directory with all it contents (the best for test is delete the .wine directory and do all again: winecfg, and later install Eve)...not patches, not regression bisect, Full Fresh eve install (from creation of .wine directory to do an Eve Full install), nothing special.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #28 from evanh evanh@clear.net.nz 2010-03-07 20:13:43 --- Maybe it's something winetricks is doing. I've had to use winetricks to get Eve to go since I got back this year (from using a Mac).
I gotta go to work. I'll give a fresh install a shot when I get home.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #29 from N3o diafoirus@gmail.com 2010-03-07 20:26:03 --- (In reply to comment #28)
Maybe it's something winetricks is doing. I've had to use winetricks to get Eve to go since I got back this year (from using a Mac).
I gotta go to work. I'll give a fresh install a shot when I get home.
Maybe, and I forget to add something to my comment : I'm not using dll overrrides, winetricks, or similar, only full wine muscle ....
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #30 from evanh evanh@clear.net.nz 2010-03-08 08:23:00 --- Okay, I don't think it's anything to do with winetricks. I just tried your procedure of delete .wine and fresh everything - and got an icon rendered :) but it also took out X when I tried to exit! ... reset computer ...
I've now loaded my normal prefs and bam! it's back to not rendering ship icons ...
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #31 from evanh evanh@clear.net.nz 2010-03-08 08:48:21 --- Holy crap - Shadows! Enabling shadows makes it work!
Jury's out on stability but it's going for the moment at least. :)
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #32 from N3o diafoirus@gmail.com 2010-03-09 00:12:55 --- ships, modules, and general market Icons (with show info window) is rendered correctly, but Planet Icons isn't rendered , Is necessary open a new bug with this description : "Planet icon rendering broken" and close this bug " EVE Online ship icon rendering broken"?...
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #33 from evanh evanh@clear.net.nz 2010-03-09 05:08:07 --- I don't think so. Enabling shadows shouldn't make the difference it does. It's still the same illness, just a new symptom is all. :P
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #34 from Henri Verbeet hverbeet@gmail.com 2010-03-10 19:17:35 --- Created an attachment (id=26742) --> (http://bugs.winehq.org/attachment.cgi?id=26742) patch
Try this.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #35 from Kaczor mrkaczor@interia.pl 2010-03-13 07:44:22 --- Found on EVE Onlien fourm:
"hello together! its true...you can get your ship icons back with wine 1.1.40 i explain you how:
1.exit game 2.go to the following directory -> cd ~/.wine/drive_c/users/%yourname%/Local\ Settings/Application\ Data/CCP/EVE/c_program_files_ccp_eve_tranquility/cache 3.delete all files and folders in this dir "cache" 4.start game BUT do not enter 5.click on settings and turn all on at graphics settings - shadows on - cache on - hdr on - bloom low - shader high - texture high - lod quality high 6.enter your password and enter game 7.go into stations and look if your ships icons are rendering now correct 8. if you have more stations with more ships, fly to all stations to render all icons one time 9.after you render all icons, press esc and set back your normal and favorite graphics settings 10.the icons stays.. :) have fun"
http://bugs.winehq.org/show_bug.cgi?id=21608
olanys@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |olanys@gmail.com
--- Comment #36 from olanys@gmail.com 2010-03-13 10:17:55 --- (In reply to comment #35)
As far as I can see, after testing a bit. Turning shader on high makes my ship icons work, and turning shader to low makes it not work again.
/ Ola
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #37 from evanh evanh@clear.net.nz 2010-03-13 23:03:16 --- Yep, shadows is part of the high quality shader.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #38 from Karsten Elfenbein kelfe@gmx.de 2010-03-14 05:34:32 --- the patch in comment #34 from Henri seems to work without enabling shadows (a reject needs to be applied manually)
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #39 from Henri Verbeet hverbeet@gmail.com 2010-03-14 06:58:36 --- (In reply to comment #38)
the patch in comment #34 from Henri seems to work without enabling shadows (a reject needs to be applied manually)
Oh right, I guess current git doesn't have context_set_pixel_format() yet.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #40 from Christoph Hohmann reboot@gmx.ch 2010-03-15 14:21:19 --- I did a test with the latest version from git (commit 693c991) and a clean wine prefix too now. I just created a link in the clean prefix to my other EVE installation folder and installed d3dx9 and corefonts using winetricks. After the first start with the default settings ship icon rendering was working, the default setting was high quality shaders with shadows. I then turned of shadows and cleared the cache. After that ship icon rendering was no longer working.
Then I applied the patch added to this bug and after that ship icon rendering was working fine with and without shadows in the ship hangar, the market and the combat logs.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #41 from evanh evanh@clear.net.nz 2010-03-17 08:03:39 --- Thanks Henri
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #42 from Henri Verbeet hverbeet@gmail.com 2010-03-18 12:01:07 --- Should be fixed by e5673ddbc3db1fcbec11979adad5cf7d64f271c2.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #43 from evanh evanh@clear.net.nz 2010-03-22 07:48:25 --- Yep, all good now. Running without shadows again and everything I click on is displaying it's icon now. Job well done. Thanks again Henri.
http://bugs.winehq.org/show_bug.cgi?id=21608
--- Comment #44 from N3o diafoirus@gmail.com 2010-04-02 16:20:35 --- --- Reporting fixed on 1.1.42 , please close this bug ---
http://bugs.winehq.org/show_bug.cgi?id=21608
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #45 from Dmitry Timoshkov dmitry@codeweavers.com 2010-04-05 04:07:03 --- Reported fixed.
http://bugs.winehq.org/show_bug.cgi?id=21608
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #46 from Alexandre Julliard julliard@winehq.org 2010-04-16 13:03:01 --- Closing bugs fixed in 1.1.43.
-
wine-bugs＠winehq.org