[Bug 42658] New: Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

Bug ID: 42658
           Summary: Playstation Now needs
                    msvcr120.dll.?Alloc@Concurrency@@YAPAXI@Z
           Product: Wine
           Version: 2.3
          Hardware: x86
               URL: https://www.playstation.com/en-us/explore/playstationn
                    ow/
                OS: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Gentoo

Follow up to bug 39685

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Gijs Vermeulen  ---
Created attachment 57594
  --> https://bugs.winehq.org/attachment.cgi?id=57594
stub test

Could you try this patch?

(it's my first, so if it doesn't work, please forgive me)

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57594|0                           |1
        is obsolete|                            |

--- Comment #2 from Gijs Vermeulen  ---
Created attachment 57595
  --> https://bugs.winehq.org/attachment.cgi?id=57595
stub test v2

The other patch was obviously wrong, I changed it a bit.
(Could still be wrong)

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #3 from Austin English  ---
(In reply to Gijs Vermeulen from comment #2)
> Created attachment 57595 [details]
> stub test v2
>
> The other patch was obviously wrong, I changed it a bit.
> (Could still be wrong)

Causes some compiler warnings:
../msvcrt/lock.c: In function 'Alloc':
../msvcrt/lock.c:616:5: warning: 'return' with a value, in function returning
void
     return p; 
     ^

but yes, it appears to work (at least, it gets to the same point as native now,
bug 42649)

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

--- Comment #4 from Gijs Vermeulen  ---
(In reply to Austin English from comment #3)
> (In reply to Gijs Vermeulen from comment #2)
> > Created attachment 57595 [details]
> > stub test v2
> >
> > The other patch was obviously wrong, I changed it a bit.
> > (Could still be wrong)
>
> Causes some compiler warnings:
> ../msvcrt/lock.c: In function 'Alloc':
> ../msvcrt/lock.c:616:5: warning: 'return' with a value, in function
> returning void
>      return p; 
>      ^
>
> but yes, it appears to work (at least, it gets to the same point as native
> now, bug 42649)

According to MSDN the function is void, but returns a pointer.
I don't know how I could fix the warning.
https://msdn.microsoft.com/en-us/library/dd492420(vs.100).aspx

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

--- Comment #5 from Bruno Jesus  ---
(In reply to Gijs Vermeulen from comment #4)
> According to MSDN the function is void, but returns a pointer.
> I don't know how I could fix the warning.
> https://msdn.microsoft.com/en-us/library/dd492420(vs.100).aspx

The function returns void pointer, not void.

_CRTIMP void * __cdecl Alloc(    size_t _NumBytes );

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57595|0                           |1
        is obsolete|                            |

--- Comment #6 from Gijs Vermeulen  ---
Created attachment 57597
  --> https://bugs.winehq.org/attachment.cgi?id=57597
stub test v3

(In reply to Bruno Jesus from comment #5)
> The function returns void pointer, not void.
>
> _CRTIMP void * __cdecl Alloc(    size_t _NumBytes );

Thank you, I changed this but reverted it like an idiot.
This patch should take care of the warning.

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

--- Comment #7 from Austin English  ---
(In reply to Gijs Vermeulen from comment #6)
> Created attachment 57597 [details]
> stub test v3
>
> (In reply to Bruno Jesus from comment #5)
> > The function returns void pointer, not void.
> >
> > _CRTIMP void * __cdecl Alloc(    size_t _NumBytes );
>
> Thank you, I changed this but reverted it like an idiot.
> This patch should take care of the warning.

Yep, warnings are gone, thanks.

But then it has a different failure:
msvcr120.dll.?_NewCollection@_AsyncTaskCollection@details@Concurrency@@SAPAV123@PAV_CancellationTokenState@23@@Z

Others it needs:
./psnowlauncher.exe imports following stub symbols:
  msvcr120:??0invalid_operation@Concurrency@@QAE@PBD@Z
  msvcr120:?Free@Concurrency@@YAXPAX@Z
  msvcr120:?GetCurrentThreadId@platform@details@Concurrency@@YAJXZ
  msvcr120:?_Cancel@_TaskCollection@details@Concurrency@@QAEXXZ
  msvcr120:?_GetCurrentInlineDepth@_StackGuard@details@Concurrency@@CAAAIXZ

msvcr120:?_NewCollection@_AsyncTaskCollection@details@Concurrency@@SAPAV123@PAV_CancellationTokenState@23@@Z
  msvcr120:?_Oversubscribe@_Context@details@Concurrency@@SAX_N@Z
  msvcr120:?_ReportUnobservedException@details@Concurrency@@YAXXZ

msvcr120:?_RunAndWait@_TaskCollection@details@Concurrency@@QAG?AW4_TaskCollectionStatus@23@PAV_UnrealizedChore@23@@Z

msvcr120:?_Schedule@_TaskCollection@details@Concurrency@@QAEXPAV_UnrealizedChore@23@@Z

msvcr120:?_ScheduleTask@_CurrentScheduler@details@Concurrency@@SAXP6AXPAX@Z0@Z
  msvcr120:?__ExceptionPtrAssign@@YAXPAXPBX@Z
  msvcr120:__crtUnhandledException

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

--- Comment #8 from Gijs Vermeulen  ---
This bug should be fixed by:
https://source.winehq.org/git/wine.git/commit/32a4bec9099676ce1ade3fbd287119...

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

--- Comment #9 from Austin English  ---
(In reply to Gijs Vermeulen from comment #8)
> This bug should be fixed by:
> https://source.winehq.org/git/wine.git/commit/
> 32a4bec9099676ce1ade3fbd2871195f9596686c

Yep, thanks. Next is bug 42680.

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |32a4bec9099676ce1ade3fbd287
                   |                            |1195f9596686c
         Resolution|---                         |FIXED

--- Comment #10 from Austin English  ---
(In reply to Austin English from comment #9)
> (In reply to Gijs Vermeulen from comment #8)
> > This bug should be fixed by:
> > https://source.winehq.org/git/wine.git/commit/
> > 32a4bec9099676ce1ade3fbd2871195f9596686c
>
> Yep, thanks. Next is bug 42680.

Fixed.

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  ---
Closing bugs fixed in 2.5.

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.0.x

[Bug 42658] Playstation Now needs msvcr120.dll.? Alloc@Concurrency@@YAPAXI@Z

https://bugs.winehq.org/show_bug.cgi?id=42658

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2.0.x                       |---

--- Comment #12 from Michael Stefaniuc  ---
Removing the 2.0.x milestone from bugs included in 2.0.2.