[Bug 39099] New: Wine's msiexec crashes when invoking Nvidia Physx maintenance tool via 'wine uninstaller -> Modify...'

https://bugs.winehq.org/show_bug.cgi?id=39099

Bug ID: 39099
           Summary: Wine's msiexec crashes when invoking Nvidia Physx
                    maintenance tool via 'wine uninstaller -> Modify...'
           Product: Wine
           Version: 1.7.48
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 268cdbbfb627dd64e527bb8603d9f8d8d788f0ae
      Distribution: Fedora

Created attachment 52093
  --> https://bugs.winehq.org/attachment.cgi?id=52093
terminal output

Steps to reproduce the problem:
1. create a new prefix, install Nvidia Physx: 'winetricks physx'
2. start 'wine uninstaller', select Nvidia Physx entry and click on the
<Modify...> button below --> msiexec crashes

Expected result: the Nvidia maintenance tool should appear, offering to
repair(reinstall) or remove Physx.

The crash was introduced by

commit 268cdbbfb627dd64e527bb8603d9f8d8d788f0ae
Author: Dmitry Timoshkov 
Date:   Fri Jul 17 17:23:24 2015 +0800

user32: SystemParametersInfo(SPI_GETNONCLIENTMETRICS) should return real
font names.

Reverting the commit on current git or installing Tahoma fonts via winetricks
makes the crash go away for me.

wine-1.7.49-41-g36a39ce
Fedora 22 32-bit

[Bug 39099] Wine's msiexec crashes when invoking Nvidia Physx maintenance tool via 'wine uninstaller -> Modify...'

https://bugs.winehq.org/show_bug.cgi?id=39099

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] ---
I cant reproduce the crash

gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
wine-1.7.49-41-g36a39ce

[Bug 39099] Wine's msiexec crashes when invoking Nvidia Physx maintenance tool via 'wine uninstaller -> Modify...'

https://bugs.winehq.org/show_bug.cgi?id=39099

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Béla Gyebrószki  ---
(In reply to super_man from comment #1)
> I cant reproduce the crash

Nor do I, after rebooting..marking invalid.

[Bug 39099] Wine's msiexec crashes when invoking Nvidia Physx maintenance tool via 'wine uninstaller -> Modify...'

https://bugs.winehq.org/show_bug.cgi?id=39099

--- Comment #3 from Béla Gyebrószki  ---
Created attachment 52097
  --> https://bugs.winehq.org/attachment.cgi?id=52097
+relay,+seh,+tid,+msi log (uncompressed 12 MB)

This morning, after a fresh boot and in a newly created prefix this bug struck
me again.
I logged out and in several times, but the crash remained.
Now it's reproducible after a complete system reboot.
Dmitry asked me to create a +relay,+seh,+tid,+msi log if the crash pops up
again.

When the crash is reproducible, I confirmed that either reverting that commit
or installing tahoma.ttf/tahomabd.ttf makes the crash go away.

I don't want to waste your time dealing with such a heisenbug hence I'm not
reopening. Yet it annoys me that I'm the only one having this problem.

Fedora 22 32-bit
wine-1.7.49-104-gbd7f43d

[Bug 39099] Wine's msiexec crashes when invoking Nvidia Physx maintenance tool via 'wine uninstaller -> Modify...'

https://bugs.winehq.org/show_bug.cgi?id=39099

--- Comment #4 from Dmitry Timoshkov  ---
Created attachment 52104
  --> https://bugs.winehq.org/attachment.cgi?id=52104
patch

Does the attached patch help?

[Bug 39099] Wine's msiexec crashes when invoking Nvidia Physx maintenance tool via 'wine uninstaller -> Modify...'

https://bugs.winehq.org/show_bug.cgi?id=39099

--- Comment #5 from Béla Gyebrószki  ---
(In reply to Dmitry Timoshkov from comment #4)
> Created attachment 52104 [details]
> patch
>
> Does the attached patch help?

Yes, it does.

[Bug 39099] Wine's msiexec crashes when invoking Nvidia Physx maintenance tool via 'wine uninstaller -> Modify...'

https://bugs.winehq.org/show_bug.cgi?id=39099

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
          Component|user32                      |msi
         Resolution|INVALID                     |---

--- Comment #6 from Dmitry Timoshkov  ---
(In reply to Béla Gyebrószki from comment #5)
> Yes, it does.

https://www.winehq.org/pipermail/wine-patches/2015-August/141653.html

[Bug 39099] Wine's msiexec crashes when invoking Nvidia Physx maintenance tool via 'wine uninstaller -> Modify...'

https://bugs.winehq.org/show_bug.cgi?id=39099

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |2ad9312f02b86591073532737f8
                   |                            |afac20aed8a9b
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Dmitry Timoshkov  ---
The patch was committed.

[Bug 39099] Wine's msiexec crashes when invoking Nvidia Physx maintenance tool via 'wine uninstaller -> Modify...'

https://bugs.winehq.org/show_bug.cgi?id=39099

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.50.