[Bug 27115] New: Wild Earth: Photo Safari Demo: launcher screen is not functional without native ie7
http://bugs.winehq.org/show_bug.cgi?id=27115
Summary: Wild Earth: Photo Safari Demo: launcher screen is not functional without native ie7 Product: Wine Version: 1.3.19 Platform: x86 URL: http://www.gamefront.com/files/5018404/wildearthdemose tup_english.exe OS/Version: Linux Status: NEW Keywords: download, regression Severity: minor Priority: P2 Component: mshtml AssignedTo: wine-bugs@winehq.org ReportedBy: austinenglish@gmail.com Blocks: 8284
Created an attachment (id=34570) --> (http://bugs.winehq.org/attachment.cgi?id=34570) terminal output
Jacek, let me know if you really need the regression test, it worked for me a couple years ago, but it's been broken since at least 1.2, and compiling really old wine will be a pain..
In wine-1.3.19-203-gf555c2d, the launcher screen is non-functional, instead showing the raw html code. Native ie7 gets a working launcher.
Terminal output attached.
http://bugs.winehq.org/show_bug.cgi?id=27115
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |paulc@voip.null.ro Regression SHA1| |0825f4b3ff3718752b5f6addd95 | |bc30c10f75d24
--- Comment #1 from Austin English austinenglish@gmail.com 2011-11-01 23:35:52 CDT --- austin@aw25 ~/wine-blah $ git bisect bad 0825f4b3ff3718752b5f6addd95bc30c10f75d24 is the first bad commit commit 0825f4b3ff3718752b5f6addd95bc30c10f75d24 Author: Paul Chitescu paulc@voip.null.ro Date: Thu Jul 1 13:17:42 2010 +0300
mshtml: Pass the data read from resource to FindMimeFromData.
:040000 040000 17e41cd68cb0b3ca866675f1a72ba677fd6295f2 dc70ef6bf1b78b3ef490e077eb16f811e878b94b M dlls
The patch is small: - hres = FindMimeFromData(NULL, url_file, NULL, 0, NULL, 0, &mime, 0); + hres = FindMimeFromData(NULL, url_file, This->data, This->data_len, NULL, 0, &mime, 0);
changing This->data back to NULL allows it to work. The same applies in wine-1.3.31-261-g3f74c58. Seems simple enough, though I suppose that needs tests..
http://bugs.winehq.org/show_bug.cgi?id=27115
--- Comment #2 from Austin English austinenglish@gmail.com 2011-11-02 00:10:24 CDT --- A bit more info, apparently it's embedding an htm file in an exe: trace:mshtml:ResProtocol_Start (0x16bab8)->(L"res://wildearth.exe/demointro.htm" 0x16b968 0x16b95c 00000000 0) ... trace:mshtml:ResProtocolInfo_ParseUrl 0x7d6c7590)->(L"res://wildearth.exe/demointro.htm" 7 0 0x16bad8 49 0x33c010 0) ... trace:mshtml:ResProtocol_Start trying to find resource type #0017, name L"demointro.htm"
http://bugs.winehq.org/show_bug.cgi?id=27115
--- Comment #3 from Austin English austinenglish@gmail.com 2011-11-02 00:10:39 CDT --- Created attachment 37254 --> http://bugs.winehq.org/attachment.cgi?id=37254 testcases + fix
http://bugs.winehq.org/show_bug.cgi?id=27115
--- Comment #4 from Paul Chitescu paulc@voip.null.ro 2011-11-02 07:26:07 CDT --- (In reply to comment #3)
Created attachment 37254 [details] testcases + fix
Fixing by no longer providing the actual data to FindMimeFromData is a workaround that would break other programs that store images in resources or files with no distinctive extension.
Changelog: mshtml: Pass the data read from resource to FindMimeFromData Since the resources have arbitrary - often numeric - names, the actual data is the only way to detect image types.
The correct solution is to fix the FindMimeFromData detection. I guess the HTML we are talking about is so bad it's guessed as text/plain.
http://bugs.winehq.org/show_bug.cgi?id=27115
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com 2012-01-29 13:30:32 CST --- Created attachment 38596 --> http://bugs.winehq.org/attachment.cgi?id=38596 patch
Try this one please.
http://bugs.winehq.org/show_bug.cgi?id=27115
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|mshtml |urlmon
http://bugs.winehq.org/show_bug.cgi?id=27115
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #6 from Austin English austinenglish@gmail.com 2012-01-30 13:30:53 CST --- (In reply to comment #5)
Created attachment 38596 [details] patch
Try this one please.
Works, thanks!
http://bugs.winehq.org/show_bug.cgi?id=27115
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |f2dfe86ac442839ed93d71c1d96 | |b36aa1d0c25b0 Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #7 from Nikolay Sivov bunglehead@gmail.com 2012-01-30 14:20:25 CST --- Fixed then, f2dfe86ac442839ed93d71c1d96b36aa1d0c25b0.
http://bugs.winehq.org/show_bug.cgi?id=27115
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org 2012-02-02 13:37:51 CST --- Closing bugs fixed in 1.4-rc2.
-
wine-bugs＠winehq.org