https://bugs.winehq.org/show_bug.cgi?id=52105
Bug ID: 52105 Summary: Handle to \Device\NamedPipe\ cannot be used as the RootDirectory for NtCreateNamedPipeFile Product: Wine Version: 6.22 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: wineserver Assignee: wine-bugs@winehq.org Reporter: jinoh.kang.kr@gmail.com CC: jacek@codeweavers.com Regression SHA1: 2600ecd4edfdb71097105c74312f83845305a4f2 Distribution: ---
Commit 2600ecd4edf (server: Use a separated object for each opened named pipe device file., 2018-10-29) split the role of the named pipe device and the named pipe file.
However, in doing so, it changed the semantics of opening \Device\NamedPipe. In particular, it is no longer possible to use a handle to \Device\NamedPipe\ as RootDirectory when creating a named pipe.
This bug makes Cygwin's named pipe creation (https://github.com/cygwin/cygwin/blob/4f47e64b11ed8d47c62fa89e9b971f44b7e9ab...) loop forever.
https://bugs.winehq.org/show_bug.cgi?id=52105
--- Comment #1 from Jinoh Kang jinoh.kang.kr@gmail.com --- Patch submitted: https://source.winehq.org/patches/data/220602
https://bugs.winehq.org/show_bug.cgi?id=52105
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com Summary|Handle to |Handle to \Device\NamedPipe |\Device\NamedPipe\ cannot |cannot be used as the |be used as the |RootDirectory for |RootDirectory for |NtCreateNamedPipeFile |NtCreateNamedPipeFile |
--- Comment #2 from Zebediah Figura z.figura12@gmail.com --- In the patch you refer to \Device\NamedPipe (without the trailing backslash); note that there is a difference. Editing title accordingly.
https://bugs.winehq.org/show_bug.cgi?id=52105
Jinoh Kang jinoh.kang.kr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Handle to \Device\NamedPipe |Handle to |cannot be used as the |\Device\NamedPipe\ cannot |RootDirectory for |be used as the |NtCreateNamedPipeFile |RootDirectory for | |NtCreateNamedPipeFile
--- Comment #3 from Jinoh Kang jinoh.kang.kr@gmail.com --- I'm afraid you might have mistaken, since the patch (particulary the test) refers to *both* unsuffixed (\Device\NamedPipe) and suffixed (\Device\NamedPipe) versions of the named pipe device path.
Also note that it is not possible to use \Device\NamedPipe (no trailing backslash) as RootDirectory for new named pipes at all (it will fail with STATUS_OBJECT_NAME_INVALID).
https://bugs.winehq.org/show_bug.cgi?id=52105
--- Comment #4 from Jinoh Kang jinoh.kang.kr@gmail.com --- Ideally \Device\NamedPipe shall be implemented as a fully fledged filesystem (with NtQueryDirectoryFile support, etc.) But this isn't implemented with plain volumes either, so I left that part for now. This also implies that Sysinternals Pipelist.exe won't still work.
https://bugs.winehq.org/show_bug.cgi?id=52105
Bernhard Übelacker bernhardu@mailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |52159
https://bugs.winehq.org/show_bug.cgi?id=52105
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=52105
Bernhard Übelacker bernhardu@mailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bernhardu@mailbox.org
--- Comment #5 from Bernhard Übelacker bernhardu@mailbox.org --- Still visible in wine-7.4-185-g47b02e8c1ea. Causes cygwin 32-bit setup to hang when it tries to execute post installation scripts, with two dash.exe processes visible.
Adding on top the mentioned .../patches/data/220601 and .../patches/data/220602 makes the installation succeed.
https://bugs.winehq.org/show_bug.cgi?id=52105
Christopher Degawa ccom@randomderp.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ccom@randomderp.com
https://bugs.winehq.org/show_bug.cgi?id=52105
Michal Suchanek hramrach@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hramrach@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=52105
--- Comment #6 from Michal Suchanek hramrach@gmail.com --- Created attachment 72609 --> https://bugs.winehq.org/attachment.cgi?id=72609 console log
Applying https://source.winehq.org/patches/data/220601 and https://source.winehq.org/patches/data/220602 to Wine 7.10 staging hangs wineboot -u
https://bugs.winehq.org/show_bug.cgi?id=52105
--- Comment #7 from Michal Suchanek hramrach@gmail.com --- building wine without the staging patches works so this probably conflicts with other change that is in staging.
Is there some specific reason why this patch is not applied?
https://bugs.winehq.org/show_bug.cgi?id=52105
Michal Suchanek hramrach@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #72609|0 |1 is obsolete| |
https://bugs.winehq.org/show_bug.cgi?id=52105
Joel Holdsworth joel@airwebreathe.org.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |joel@airwebreathe.org.uk
https://bugs.winehq.org/show_bug.cgi?id=52105
--- Comment #8 from Bernhard Übelacker bernhardu@mailbox.org --- Bug# 53155 and bug# 54938 got reported about hangs in MSYS2 installer. The hang can be avoided by applying the not yet committed: https://source.winehq.org/patches/data/220602
https://bugs.winehq.org/show_bug.cgi?id=52105
Jinoh Kang jinoh.kang.kr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://cygwin.com/setup-x8 | |6_64.exe Keywords| |download, source, testcase
--- Comment #9 from Jinoh Kang jinoh.kang.kr@gmail.com --- The test case for this is already upstreamed; what's left is to figure out a cleaner way to teach wineserver about "virtual" (NPFS) filesystems.
In particular, wineserver should recognize \Device\NamedPipe as the FS device itself while treating \Device\NamedPipe\ as the root directory. The current object_ops interface does not allow distinguishing between the two.
https://bugs.winehq.org/show_bug.cgi?id=52105
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Handle to |Cygwin setup hangs (handle |\Device\NamedPipe\ cannot |to \Device\NamedPipe\ used |be used as the |as the RootDirectory for |RootDirectory for |NtCreateNamedPipeFile) |NtCreateNamedPipeFile |
https://bugs.winehq.org/show_bug.cgi?id=52105
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
--- Comment #10 from Fabian Maurer dark.shadow4@web.de --- This might be related to bug 54511 (Cygwin installer hangs during postprocessing step), but even with MR https://gitlab.winehq.org/wine/wine/-/merge_requests/498 I get the hang with dash.exe.
https://bugs.winehq.org/show_bug.cgi?id=52105
manschwetus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |manschwetus@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=52105
--- Comment #11 from Fabian Maurer dark.shadow4@web.de --- MR is committed, is this all that is required or is there something missing? FWIW, even with wine-9.21 I still get the dash.exe hang.
https://bugs.winehq.org/show_bug.cgi?id=52105
Jinoh Kang jinoh.kang.kr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |663bc966535f3150be01b1839e4 | |9265277396147
--- Comment #12 from Jinoh Kang jinoh.kang.kr@gmail.com --- Fixed in 663bc966535f3150be01b1839e49265277396147. Sorry for the late update.
https://bugs.winehq.org/show_bug.cgi?id=52105
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #13 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.22.