[Bug 37086] New: Assassin's Creed: wrong colors in the menus and in-game with built-in d3dx9_36

http://bugs.winehq.org/show_bug.cgi?id=37086

Bug ID: 37086
           Summary: Assassin's Creed: wrong colors in the menus and
                    in-game with built-in d3dx9_36
           Product: Wine
           Version: 1.7.13
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: minor
          Priority: P2
         Component: directx-d3dx9
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 596bb77862dff8868fa191f6aefcdfe48dd054f5

Created attachment 49291
  --> http://bugs.winehq.org/attachment.cgi?id=49291
screenshot - pink sky

The sky is pink in the game and you can observe the same color elsewhere in the
game (main menu) when running the game with the built-in d3dx9_36.dll.

The only related messages in the terminal until I get to the main menu where
the problem can be observed:
> fixme:d3d:debug_d3dformat Unrecognized 0x42563252 (as fourcc: R2VB) WINED3DFORMAT!
> fixme:d3d:wined3d_get_format Can't find format unrecognized (0x42563252) in the format lookup table

The problem is present since
596bb77862dff8868fa191f6aefcdfe48dd054f5 is the first bad commit
commit 596bb77862dff8868fa191f6aefcdfe48dd054f5
Author: Matteo Bruni 
Date:   Tue Feb 18 22:17:00 2014 +0100

d3dx9: Add some more float pixel formats.

:040000 040000 3c7009e003991f4342ed13ee6a2e70d480955ad5
17013b0efa701bcb57465c3afc4e38c50ee754cb M    dlls

Reverting the patch on 1.7.24 fixes the issue.

Tested with Nvidia binary drivers 331.89 and 340.24 and with the open source
Nouveau driver.

Wine 1.7.24
Fedora 20
Geforce 250 gfx card

[Bug 37086] Assassin's Creed: wrong colors in the menus and in-game with built-in d3dx9_36

http://bugs.winehq.org/show_bug.cgi?id=37086

--- Comment #1 from Béla Gyebrószki  ---
Created attachment 49292
  --> http://bugs.winehq.org/attachment.cgi?id=49292
+d3dx log (uncompressed 31 MB)

[Bug 37086] Assassin's Creed: wrong colors in the menus and in-game with built-in d3dx9_36

https://bugs.winehq.org/show_bug.cgi?id=37086

--- Comment #2 from Matteo Bruni  ---
Created attachment 49390
  --> https://bugs.winehq.org/attachment.cgi?id=49390
Possible fix

Thank you, that trace is exactly what I needed.
Does the attached patch fix the issue?

[Bug 37086] Assassin's Creed: wrong colors in the menus and in-game with built-in d3dx9_36

https://bugs.winehq.org/show_bug.cgi?id=37086

--- Comment #3 from Béla Gyebrószki  ---
(In reply to Matteo Bruni from comment #2)
> Created attachment 49390 [details]
> Possible fix
>
> Thank you, that trace is exactly what I needed.
> Does the attached patch fix the issue?

Thanks Matteo, the patch indeed fixes the issue.

[Bug 37086] Assassin's Creed: wrong colors in the menus and in-game with built-in d3dx9_36

https://bugs.winehq.org/show_bug.cgi?id=37086

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |770eaec561c8920b64c07b51526
                   |                            |11c55a7038eb9
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Béla Gyebrószki  ---
Fixed by 770eaec561c8920b64c07b5152611c55a7038eb9.

wine-1.7.25-21-gc87901d

[Bug 37086] Assassin's Creed: wrong colors in the menus and in-game with built-in d3dx9_36

https://bugs.winehq.org/show_bug.cgi?id=37086

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.26.