http://bugs.winehq.org/show_bug.cgi?id=33001
Bug #: 33001 Summary: TREEVIEW_GetItemT crashes when getting item from different tree Product: Wine Version: unspecified Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 AssignedTo: wine-bugs@winehq.org ReportedBy: plr.vincent@gmail.com Classification: Unclassified
Created attachment 43599 --> http://bugs.winehq.org/attachment.cgi?id=43599 Crash log
Triggered using AXE3 (hex editor): http://advanced-hex-editor-a-x-e.en.softonic.com/ Crashes on program start, after "evaluation period expired" warning and before displaying the main window. Does not happen systematically, but with a high probability (~8 out of 10 runs). See attachment for error details.
This is a regression. Looking at the short change history of dlls/comctl32/treeview.c I identified the commit introducing the regression as 95a15a3482ba47c1b84fd77a63f95d5cd784a97a , and re-introducing a "return FALSE" in the "if (!TREEVIEW_ValidItem(infoPtr, item))" code branch indeed cures the crash.
http://bugs.winehq.org/show_bug.cgi?id=33001
--- Comment #1 from Vincent Pelletier plr.vincent@gmail.com 2013-02-17 15:53:39 CST --- Created attachment 43600 --> http://bugs.winehq.org/attachment.cgi?id=43600 Crash log with WINEDEBUG=trace+treeview
Crash location changes when using WINEDEBUG=trace+treeview as it then occurs in the trace added in mentioned commit. See second attachment.
http://bugs.winehq.org/show_bug.cgi?id=33001
Vincent Pelletier plr.vincent@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |95a15a3482ba47c1b84fd77a63f | |95d5cd784a97a
http://bugs.winehq.org/show_bug.cgi?id=33001
Vincent Pelletier plr.vincent@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression URL| |http://advanced-hex-editor- | |a-x-e.en.softonic.com/
http://bugs.winehq.org/show_bug.cgi?id=33001
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|TREEVIEW_GetItemT crashes |TREEVIEW_GetItemT crashes |when getting item from |on invalid item pointer |different tree |
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com 2013-02-17 22:52:02 CST --- This is about handling garbage pointer value as item pointer, it could be fixed with exception handler of course, but it needs tests.
http://bugs.winehq.org/show_bug.cgi?id=33001
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com 2013-02-22 01:52:52 CST --- I sent a patch for this http://www.winehq.org/pipermail/wine-patches/2013-February/122396.html.
http://bugs.winehq.org/show_bug.cgi?id=33001
--- Comment #4 from Nikolay Sivov bunglehead@gmail.com 2013-02-22 05:25:42 CST --- Is there a saner way to download this thing than using intermediate downloader from this site that doesn't work in wine?
http://bugs.winehq.org/show_bug.cgi?id=33001
--- Comment #5 from Bruno Jesus 00cpxxx@gmail.com 2013-02-22 06:44:39 CST --- Is version 3 ok? The last version was 3.4. http://www.datahelper.com/download/misc/installAXE.exe
http://bugs.winehq.org/show_bug.cgi?id=33001
--- Comment #6 from Vincent Pelletier plr.vincent@gmail.com 2013-02-23 14:18:58 CST --- (In reply to comment #4)
Is there a saner way to download this thing than using intermediate downloader from this site that doesn't work in wine?
Sorry for not checking the download source. I've downloaded this program long ago. I followed what seemed the sanest source I could fine, which is http://jbwyatt.com/axe.html and links to the url I pasted.
I applied the proposed patch, and I confirm it fixes the crash (judging by the patch, it would be surprising if it didn't fix it :) ) and - more importantly I guess - that the application doesn't crash later either.
http://bugs.winehq.org/show_bug.cgi?id=33001
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |turbolad995@hotmail.co.uk
--- Comment #7 from Rosanne DiMesio dimesio@earthlink.net 2013-08-11 14:32:35 CDT --- *** Bug 34223 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=33001
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #8 from Ken Sharp kennybobs@o2.co.uk 2013-08-11 17:41:37 CDT --- Confirmed by multiple people.
https://bugs.winehq.org/show_bug.cgi?id=33001
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #9 from super_man@post.com --- patching file dlls/comctl32/tests/treeview.c Hunk #1 succeeded at 905 (offset 96 lines). patching file dlls/comctl32/treeview.c Hunk #2 succeeded at 2071 (offset -31 lines).
Nikolay's patch still applies.
wine 1.7.51
https://bugs.winehq.org/show_bug.cgi?id=33001
Michael Müller michael@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED CC| |michael@fds-team.de, | |sebastian@fds-team.de Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/comctl32-TVM_G | |ETITEM
https://bugs.winehq.org/show_bug.cgi?id=33001
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net Version|unspecified |1.5.24 Summary|TREEVIEW_GetItemT crashes |AXE3 (hex editor) crashes |on invalid item pointer |in TREEVIEW_GetItemT on | |invalid item pointer
https://bugs.winehq.org/show_bug.cgi?id=33001
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |60fedd23f95c66f4dce06c5c447 | |de9ec99ebefa5 Status|STAGED |RESOLVED Resolution|--- |FIXED
--- Comment #10 from Nikolay Sivov bunglehead@gmail.com --- Fixed with 60fedd23f95c66f4dce06c5c447de9ec99ebefa5.
https://bugs.winehq.org/show_bug.cgi?id=33001
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #11 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.55.
-
wine-bugs＠winehq.org