https://bugs.winehq.org/show_bug.cgi?id=43411
Bug ID: 43411 Summary: The Sims -> White models frozen on the screen Product: Wine Version: 2.10 Hardware: x86-64 OS: FreeBSD Status: UNCONFIRMED Severity: minor Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: adrien_fernandes2@hotmail.com
The Sims isn't playable since all the characters are in white and are frozen, sometimes the screen refresh when you call for the interaction menu but they will be stuck elsewhere.
https://appdb.winehq.org/appimage.php?iId=44824
https://bugs.winehq.org/show_bug.cgi?id=43411
Alexandr Oleynikov sashok.olen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sashok.olen@gmail.com
--- Comment #1 from Alexandr Oleynikov sashok.olen@gmail.com --- Can confirm in wine-staging 2.21. Attaching terminal output.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #2 from Alexandr Oleynikov sashok.olen@gmail.com --- Created attachment 59803 --> https://bugs.winehq.org/attachment.cgi?id=59803 Sims.exe terminal output
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #3 from Alexandr Oleynikov sashok.olen@gmail.com --- Created attachment 59841 --> https://bugs.winehq.org/attachment.cgi?id=59841 3D objects are not being rendered properly
Attaching screenshot of the bug.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #4 from Alexandr Oleynikov sashok.olen@gmail.com --- Possibly a duplicate of #42572.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #5 from Alexandr Oleynikov sashok.olen@gmail.com --- whoops, Bug 42572
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #6 from Alexandr Oleynikov sashok.olen@gmail.com --- The severity should be normal not minor. Also, it would be nice to mark it as duplicate.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #7 from Alexandr Oleynikov sashok.olen@gmail.com --- Created attachment 62174 --> https://bugs.winehq.org/attachment.cgi?id=62174 apitrace
I've apitraced the game (d3d7). If there's anything else needed to fix this, please ask.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #8 from Alexandr Oleynikov sashok.olen@gmail.com --- Created attachment 62881 --> https://bugs.winehq.org/attachment.cgi?id=62881 +d3d
Attaching +d3d log.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #9 from Alexandr Oleynikov sashok.olen@gmail.com --- Created attachment 62882 --> https://bugs.winehq.org/attachment.cgi?id=62882 +ddraw
Attaching +ddraw log. Sorry that they are separate, the game just locks up when using both options.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #10 from Alexandr Oleynikov sashok.olen@gmail.com --- I should point out that I ran the game using wine 3.7 as it seems that it has regressed in newer version (will need to bisect that) and doesn't launch even with -skip_intro -skip_verify flags.
https://bugs.winehq.org/show_bug.cgi?id=43411
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|The Sims -> White models |The Sims (Complete |frozen on the screen |Collection) white models | |frozen on the screen Status|UNCONFIRMED |NEW Severity|minor |normal Ever confirmed|0 |1
--- Comment #11 from Gijs Vermeulen gijsvrm@gmail.com --- Confirming, setting severity to "normal".
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #12 from Alexandr Oleynikov sashok.olen@gmail.com --- Disregard the d3d7 apitrace, it is just 1 frame.
https://bugs.winehq.org/show_bug.cgi?id=43411
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |haakobja@gmail.com
--- Comment #13 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- *** Bug 46884 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=43411
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick@piezo-forte.be Summary|The Sims (Complete |The Sims - white models |Collection) white models |frozen on the screen |frozen on the screen |
--- Comment #14 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Affects 'Double Deluxe' too.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #15 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- For clarification, let's make this bug about the issue of the game not redrawing properly, and bug 42572 about the white/black character models.
https://bugs.winehq.org/show_bug.cgi?id=43411
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|The Sims - white models |Older directx games (The |frozen on the screen |Sims, revenant) - screen | |not redrawing properly | |(d3d_device7_Set/GetClipSta | |tus stub?)
https://bugs.winehq.org/show_bug.cgi?id=43411
pattietreutel katyaberezyaka@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |katyaberezyaka@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=43411
Paul Gofman gofmanp@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gofmanp@gmail.com
--- Comment #16 from Paul Gofman gofmanp@gmail.com --- Created attachment 63990 --> https://bugs.winehq.org/attachment.cgi?id=63990 Test patch
Can someone please test if possible if this patch changes anything in respect to sims redraw? This is not a fix but rather an attempt to verify if the bug is related to missing Set / GetClipStatus or anything else.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #17 from Alexandr Oleynikov sashok.olen@gmail.com --- The patch seems to solve the redrawing issue for me. However, characters are still drawn over the top of everything without any regard to walls or furniture.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #18 from Paul Gofman gofmanp@gmail.com --- (In reply to Alexandr Oleynikov from comment #17)
The patch seems to solve the redrawing issue for me. However, characters are still drawn over the top of everything without any regard to walls or furniture.
Thanks for testing see. So I guess this is now confirmed that this particular bug is about missing d3d_device7_Set/GetClipStatus implementation. The patch is not an implementation, it just always returns something like "nothing is clipped" from GetClipStatus(). It is likely that drawing characters on top of everything might be related to this and proper implementation is needed to really fix it.
https://bugs.winehq.org/show_bug.cgi?id=43411
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |directx-d3d Summary|Older directx games (The |Older directx games (The |Sims, revenant) - screen |Sims, Revenant) - Screen |not redrawing properly |not redrawing properly |(d3d_device7_Set/GetClipSta |(needs Set/GetClipStatus |tus stub?) |implementation)
--- Comment #19 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Confirming that the patch 'fixes' the redrawing issue in Revenant Demo too.
https://bugs.winehq.org/show_bug.cgi?id=43411
Bruni newdell338@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |newdell338@gmail.com
--- Comment #20 from Bruni newdell338@gmail.com --- @Alexandr Oleynikov
Hello.
For me, it's pretty strange that you could even launch sims in plain wine-4.4 at all.
Did you use dgvoodoo2 or DXVK?
I ve'got stuck into bug 43709 in plain wine
BTW, you wrote the game leaves "dirt" in https://www.vogons.org/viewtopic.php?f=59&t=62148 when using dgvoodoo2
Does it look the same way as it showed Håkon in video https://bugs.winehq.org/attachment.cgi?id=63959
Could you please attach screenshot?
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #21 from Alexandr Oleynikov sashok.olen@gmail.com --- I actually used Wine-Staging and ran the game with -skip_intro and -skip_verify (forces game to not run in 16 bit colors) as instruced on AppDB page for the game. The dirt issue with dgvoodoo2 was distantly similar but it was really minor compared to what we have in Wine and it has already been fixed. You can watch how the game used to run with dgvoodoo2 before the bug was fixed here: https://youtu.be/2elGldbhrGo
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #22 from Alexandr Oleynikov sashok.olen@gmail.com --- I should note that you only need arguments if you are trying to use use wined3d. With dgvoodoo2+DXVK it will work even with plain Wine.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #23 from Paul Gofman gofmanp@gmail.com --- Created attachment 64033 --> https://bugs.winehq.org/attachment.cgi?id=64033 Test patch
(In reply to Alexandr Oleynikov from comment #17)
The patch seems to solve the redrawing issue for me. However, characters are still drawn over the top of everything without any regard to walls or furniture.
Does this patch fix the drawing on top of everything as well? The patch is the same GetClipStatus() change plus a change in depth surface creation.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #24 from Alexandr Oleynikov sashok.olen@gmail.com --- Created attachment 64035 --> https://bugs.winehq.org/attachment.cgi?id=64035 screenshot of deluxe edition with the v2 patch
Yes, the redrawing issue is completely gone, and Deluxe Edition is now actually kinda playable if you don't mind broken plumbob (it seems to have the same rendering issues from bug 42572 as characters in Complete Collection) and occasional random lockups (not caused by the patch, I was getting them without it too). Attached a screenshot to demonstrate.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #25 from Håkon haakobja@gmail.com --- (In reply to Alexandr Oleynikov from comment #24)
Created attachment 64035 [details] screenshot of deluxe edition with the v2 patch
Yes, the redrawing issue is completely gone, and Deluxe Edition is now actually kinda playable if you don't mind broken plumbob (it seems to have the same rendering issues from bug 42572 as characters in Complete Collection) and occasional random lockups (not caused by the patch, I was getting them without it too). Attached a screenshot to demonstrate.
Which git commit did you try with? I've tried with the latest git master (commit c6ff0e01224e86c7baa31d019fcb0a7bf03e2f96) and I get the following message when trying git apply: $ git apply ../test.patch error: patch failed: dlls/ddraw/surface.c:6198 error: dlls/ddraw/surface.c: patch does not apply
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #26 from Paul Gofman gofmanp@gmail.com --- (In reply to Håkon from comment #25)
error: patch failed: dlls/ddraw/surface.c:6198 error: dlls/ddraw/surface.c: patch does not apply
2 / 3 fixes from here werea committed to Wine git, but one was left behind. If you want to test the Sims now and understand which (undiscovered) issues are left, I suggest you take latest staging (rebased to 4.5) and apply the following 2 patches: - https://source.winehq.org/patches/data/161816 - https://bugs.winehq.org/attachment.cgi?id=63990
All the other patches tested around this and adjacent Sims bug are committed either to Wine git or to Staging.
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #27 from Håkon haakobja@gmail.com --- Created attachment 64046 --> https://bugs.winehq.org/attachment.cgi?id=64046 Video of the Sims
(In reply to Paul Gofman from comment #26)
(In reply to Håkon from comment #25)
error: patch failed: dlls/ddraw/surface.c:6198 error: dlls/ddraw/surface.c: patch does not apply2 / 3 fixes from here werea committed to Wine git, but one was left behind. If you want to test the Sims now and understand which (undiscovered) issues are left, I suggest you take latest staging (rebased to 4.5) and apply the following 2 patches:
All the other patches tested around this and adjacent Sims bug are committed either to Wine git or to Staging.
Wow, those patches really did it. I've attached a video that shows the state of the game, and it really looks good. I'm looking forward to spend some quality time with The Sims on Linux :)
https://bugs.winehq.org/show_bug.cgi?id=43411
--- Comment #28 from Paul Gofman gofmanp@gmail.com --- The improved stub for GetClipStatus() similar to what was tested here has been committed to Wine git (38bdd6fc5c36c61a2b8edbb8fe52ba858d4c32c8). The remaining issues that were reported after applying such a patch were attributed to distinct problems which are already fixed either in mainstream Wine or in Staging.
As the games concerned by this bug are confirmed to be fixed with it, I suggest to close this big. If games requiring a complete implementation will be discovered that can probably go as a separate bug.
https://bugs.winehq.org/show_bug.cgi?id=43411
Józef Kucia joseph.kucia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |38bdd6fc5c36c61a2b8edbb8fe5 | |2ba858d4c32c8 CC| |joseph.kucia@gmail.com Resolution|--- |FIXED
--- Comment #29 from Józef Kucia joseph.kucia@gmail.com --- Fixed by 38bdd6fc5c36c61a2b8edbb8fe52ba858d4c32c8
https://bugs.winehq.org/show_bug.cgi?id=43411
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #30 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 4.6.
https://bugs.winehq.org/show_bug.cgi?id=43411
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x
https://bugs.winehq.org/show_bug.cgi?id=43411
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |---
--- Comment #31 from Michael Stefaniuc mstefani@winehq.org --- Removing the 4.0.x milestone from bug fixes included in 4.0.2.
-
wine-bugs＠winehq.org