[Bug 48364] New: Clifford Thinking Adventures fails to start in some configurations

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48364

Bug ID: 48364
           Summary: Clifford Thinking Adventures fails to start in some
                    configurations
           Product: Wine
           Version: 5.0-rc2
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: patch
          Severity: normal
          Priority: P2
         Component: gdi32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 66108
  --> https://bugs.winehq.org/attachment.cgi?id=66108
gdi32: Return the current display frequency from GetDeviceCaps(VREFRESH).

It spews out a message box saying: "This program cannot be run with your
current monitor settings. Please reset your monitor to a minimum of 256 colors
before running Clifford."

In fact an 8-bit display device isn't necessary. What is necessary is for
EnumDisplaySettings() to return at least one device with a refresh rate equal
to the number returned by GetDeviceCaps(VREFRESH). Under normal circumstances
the latter returns 1, but the former may return e.g. 60.

The attached patch fixes this, and makes the game completely playable for me.

[Bug 48364] Clifford Thinking Adventures fails to start: "This program cannot be run with your current monitor settings."

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48364

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Clifford Thinking           |Clifford Thinking
                   |Adventures fails to start   |Adventures fails to start:
                   |in some configurations      |"This program cannot be run
                   |                            |with your current monitor
                   |                            |settings."

[Bug 48364] Clifford Thinking Adventures fails to start: "This program cannot be run with your current monitor settings."

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48364

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 48364] Clifford Thinking Adventures fails to start: "This program cannot be run with your current monitor settings."

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48364

--- Comment #1 from Zhiyi Zhang  ---
Looks good to me. There is one small problem though. The DC could be from a
device other than the primary adapter. But Wine currently create DCs covering
the whole virtual screen regardless of the specified device, so we could worry
about it later.

[Bug 48364] Clifford Thinking Adventures fails to start: "This program cannot be run with your current monitor settings."

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48364

--- Comment #2 from Zebediah Figura  ---
(In reply to Zhiyi Zhang from comment #1)
> Looks good to me. There is one small problem though. The DC could be from a
> device other than the primary adapter. But Wine currently create DCs
> covering the whole virtual screen regardless of the specified device, so we
> could worry about it later.

I figured so, yeah. But our implementation of e.g. HORZRES also is
indiscriminate in that respect, so I figured I should just follow that example.