[Bug 15281] New: PROFILE_Load and friends doesn't handle ini files with CR-only line endings

http://bugs.winehq.org/show_bug.cgi?id=15281

Summary: PROFILE_Load and friends doesn't handle ini files with
                    CR-only line endings
           Product: Wine
           Version: 1.1.4
          Platform: PC
               URL: http://www.widescreengamingforum.com/wiki/index.php/UniW
                    S
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: kernel32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=16083)
 --> (http://bugs.winehq.org/attachment.cgi?id=16083)
+profile debug log

UniWS is a universal widescreen patcher used for multiple games.

At launch, wine fails to parse its .ini file correctly and uniws emits the
error message: "Your PATCHES.INI file is for a different patcher version. A new
version of Universal Widescreen Patcher may be available for download."

It turns out that patches.ini is in Mac format (CR-only line endings).
Converting it to CRLF allows the application to start and work.

This works out of the box on windows, only wine users have reported this error
message on message boards.

The shortcoming is in the kernel32:PROFILE_* set of functions. Ought to be
pretty straightforward to fix in PROFILE_Load. The +profile debug log shows the
bug quite clearly.

[Bug 15281] PROFILE_Load and friends doesn't handle ini files with CR-only line endings

http://bugs.winehq.org/show_bug.cgi?id=15281

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 15281] PROFILE_Load and friends doesn't handle ini files with CR-only line endings

http://bugs.winehq.org/show_bug.cgi?id=15281

--- Comment #1 from [e-mail]  2008-09-13 19:29:34 ---
Created an attachment (id=16088)
 --> (http://bugs.winehq.org/attachment.cgi?id=16088)
minimal fix + testcase

Patch + test. Testcase sent to wine-devel for native testing.

[Bug 15281] PROFILE_Load and friends doesn't handle ini files with CR-only line endings

http://bugs.winehq.org/show_bug.cgi?id=15281

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 15281] PROFILE_Load and friends doesn't handle ini files with CR-only line endings

http://bugs.winehq.org/show_bug.cgi?id=15281

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase

[Bug 15281] PROFILE_Load and friends doesn't handle ini files with CR-only line endings

http://bugs.winehq.org/show_bug.cgi?id=15281

--- Comment #2 from [e-mail]  2008-09-14 07:50:10 ---
Patch sent.

http://www.winehq.org/pipermail/wine-patches/2008-September/061540.html

[Bug 15281] PROFILE_Load and friends doesn't handle ini files with CR-only line endings

http://bugs.winehq.org/show_bug.cgi?id=15281

--- Comment #3 from Vijay Kamuju   2008-09-16 12:51:28 ---
test with latest git a fix might be in place

[Bug 15281] PROFILE_Load and friends doesn't handle ini files with CR-only line endings

http://bugs.winehq.org/show_bug.cgi?id=15281

--- Comment #4 from [e-mail]  2008-09-20 19:30:55 ---
Another try.

http://www.winehq.org/pipermail/wine-patches/2008-September/061879.html

[Bug 15281] PROFILE_Load and friends doesn't handle ini files with CR-only line endings

http://bugs.winehq.org/show_bug.cgi?id=15281

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from [e-mail]  2008-09-23 12:10:33 ---
Patch is in, fixed in git post-1.1.5.

[Bug 15281] PROFILE_Load and friends doesn't handle ini files with CR-only line endings

http://bugs.winehq.org/show_bug.cgi?id=15281

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2008-10-10 10:10:57 ---
Closing bugs fixed in 1.1.6.