[Bug 23362] New: The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

Summary: The Starcraft 2 Editor crashes when you open the
                    terrain view after opening and closing the previewer.
           Product: Wine
           Version: 1.2-rc4
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=29118)
 --> (http://bugs.winehq.org/attachment.cgi?id=29118)
Crash backtrace.

Steps to reproduce:
1.) Set the registry key
"HKEY_CURRENT_USER\Software\Blizzard
Entertainment\StarCraft II Editor Beta\Preferences\StartupModules" to 0
I do this because the terrain editor would open else instantly and usually when
the terrain editor opens it freeze for me(see bug 22588).
2.) Start the editor and select the "Overview Manager" (right most icon)
3.) Start the previewer using the menu Window/Previewer
4.) Close the previewer window
5.) Attach a debugger if you want a backtrace
6.) Start the Terrain Module using the menu Modules/Terrain

It crashes as surface->container is nil when surface_is_offscreen gets called.

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

--- Comment #1 from Florian   2010-06-25 09:30:12 ---
The following hack makes the editor stop crashing for me. Instead it freezes
like described in bug 22588.
@@ -1182,10 +1182,12 @@ static void WINAPI
IWineD3DSurfaceImpl_UnLoad(IWineD3DSurface *iface) {

* and all flags get lost
          */
+        if (This->container == NULL)
+            return;
         surface_init_sysmem(This);
     }

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

Florian  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P5
           Severity|normal                      |minor

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

--- Comment #2 from Henri Verbeet   2010-06-25 09:41:26 ---
Is that a surface that is/was on a swapchain?

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

--- Comment #3 from Florian   2010-06-25 09:54:41 ---
Both types play a role: "This" is a surface (IWineD3DSurfaceImpl) which has a
field "container" of type swapchain (IWineD3DSwapChainImpl).

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

--- Comment #4 from Florian   2010-07-03 13:44:28 ---
As described in bug 22588 the editor crashes with the same backtrace if you
switch to the terrain layer of the terrain editor. See comments 31 and 32 of
bug 22588:
http://bugs.winehq.org/show_bug.cgi?id=22588#c31

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

--- Comment #5 from Florian   2010-07-03 13:56:52 ---
This bug doesn't occur if you set
HKEY_CURRENT_USER/Software/Wine/Direct3D/OffscreenRenderingMode to backbuffer.
The same workaround works for bug 22588.

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

--- Comment #6 from [e-mail] 2013-06-21 15:28:13 CDT ---
This ticket has not been updated for over 900 days.

Is this still an issue in wine version 1.6-rc3 or higher or is this to be
closed as abandoned ?

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

--- Comment #7 from Florian  2013-06-29 15:06:53 CDT ---
I tested it again with wine-1.5.25: No crash, it works fine.

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Dan Kegel  2013-06-29 18:26:21 CDT ---
So bug 22588 is also fixed for you in current wine?

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

--- Comment #9 from Florian  2013-06-30 08:31:11 CDT ---
Yes, like I stated in my last comment of bug 22588.

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

--- Comment #10 from Dan Kegel  2013-06-30 08:45:39 CDT ---
That reply was pretty old, and had caveats; I was asking about the current
status with wine-1.6-rc4 (wine-1.5.25 is recent enough, too).

Assuming you agree both bugs are fixed... let's mark them fixed tomorrow.

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Ken Sharp  2013-08-04 11:16:22 CDT ---
(In reply to comment #7)
> I tested it again with wine-1.5.25: No crash, it works fine.

If it's fixed then mark the bug as resolved.

[Bug 23362] The Starcraft 2 Editor crashes when you open the terrain view after opening and closing the previewer.

http://bugs.winehq.org/show_bug.cgi?id=23362

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2013-08-30 13:05:13 CDT ---
Closing bugs fixed in 1.7.1.