[Bug 21104] New: 16-bit app crashes in X11DRV_XRender_CopyBrush when using vncserver

http://bugs.winehq.org/show_bug.cgi?id=21104

Summary: 16-bit app crashes in X11DRV_XRender_CopyBrush when
                    using vncserver
           Product: Wine
           Version: 1.1.34
          Platform: x86
               URL: http://193.219.43.130/~winetester/bin/win16/ledw2.tar.
                    bz2
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=25331)
 --> (http://bugs.winehq.org/attachment.cgi?id=25331)
Crash log for Wine-1.1.32+

It is a regression made by commit 00bbab491bb7d74f71d5855a8140f3188f438026 [1].
 The app is abandonware called WinLED.

To run it correctly before the regression you will need some patch [2] from bug
2332.  But when regression is in, it can be noticed even w/o the patch applied.

[1]http://source.winehq.org/git/wine.git/?a=commit;h=00bbab491bb7d74f71d5855a81...
[2]http://bugs2.winehq.org/attachment.cgi?id=13965

[Bug 21104] 16-bit app crashes in X11DRV_XRender_CopyBrush when using vncserver

http://bugs.winehq.org/show_bug.cgi?id=21104

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Dmitry Timoshkov   2009-12-21 07:38:05 ---
Here is the culprit commit info:

Roderick Colenbrander 
Fri, 30 Oct 2009 10:05:29 +0000 (+0100)
winex11: Make sure the formats are the same instead of the depths since the bit
order...

winex11: Make sure the formats are the same instead of the depths since the bit
ordering can be different.

[Bug 21104] 16-bit app crashes in X11DRV_XRender_CopyBrush when using vncserver

http://bugs.winehq.org/show_bug.cgi?id=21104

--- Comment #2 from Roderick Colenbrander   2009-12-21 07:51:55 ---
Created an attachment (id=25332)
 --> (http://bugs.winehq.org/attachment.cgi?id=25332)
fix

Could you test if this patch fixes the issue?

[Bug 21104] 16-bit app crashes in X11DRV_XRender_CopyBrush when using vncserver

http://bugs.winehq.org/show_bug.cgi?id=21104

--- Comment #3 from Roderick Colenbrander   2009-12-21 09:05:57 ---
The patch should fix the crash but the app likely won't function well. I need
to think of a real solution.

[Bug 21104] 16-bit app crashes in X11DRV_XRender_CopyBrush when using vncserver

http://bugs.winehq.org/show_bug.cgi?id=21104

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25332|0                           |1
        is obsolete|                            |

--- Comment #4 from Roderick Colenbrander   2009-12-21 09:34:03 ---
Created an attachment (id=25339)
 --> (http://bugs.winehq.org/attachment.cgi?id=25339)
New fix

Try this fix instead.

[Bug 21104] 16-bit app crashes in X11DRV_XRender_CopyBrush when using vncserver

http://bugs.winehq.org/show_bug.cgi?id=21104

--- Comment #5 from Saulius K.   2009-12-21 09:43:37 ---
Roderick, super!  Second patch works OK for me (while the first one doesn't
even fix the crash).

Thanks :)

[Bug 21104] 16-bit app crashes in X11DRV_XRender_CopyBrush when using vncserver

http://bugs.winehq.org/show_bug.cgi?id=21104

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 21104] 16-bit app crashes in X11DRV_XRender_CopyBrush when using vncserver

http://bugs.winehq.org/show_bug.cgi?id=21104

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Roderick Colenbrander   2009-12-22 10:14:10 ---
A fix is in GIT, so marking this bug as fixed.

[Bug 21104] 16-bit app crashes in X11DRV_XRender_CopyBrush when using vncserver

http://bugs.winehq.org/show_bug.cgi?id=21104

Saulius K.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |win16

--- Comment #7 from Saulius K.   2009-12-22 10:25:37 ---
What's the current Bugzilla policy about closing fixed bugs -- is it only
Alexandre's (some script) prerogative or I am free to do this too?

[Bug 21104] 16-bit app crashes in X11DRV_XRender_CopyBrush when using vncserver

http://bugs.winehq.org/show_bug.cgi?id=21104

--- Comment #8 from Roderick Colenbrander   2009-12-22 10:30:28 ---
Alexandre closes them before a new release. Invalid bugs can be closed by
anyone.

[Bug 21104] 16-bit app crashes in X11DRV_XRender_CopyBrush when using vncserver

http://bugs.winehq.org/show_bug.cgi?id=21104

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Jeff Zaroyko   2010-01-09 04:44:01 ---
Closing bugs fixed in 1.1.36.