[Bug 23453] New: Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

Summary: Worms Armageddon cannot send text in WormNET
           Product: Wine
           Version: 1.2-rc5
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

After logging in to WormNET and joining a channel, one should be able to send a
message to the channel by typing some text and pressing enter. Pressing enter
has no effect.

This used to work.

Regression test to follow.

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |user32

--- Comment #1 from Vincent Povirk   2010-06-30 17:15:12 ---
f1f1c5053160777d0db89b1891706b0b960d3d48 is first bad commit
commit f1f1c5053160777d0db89b1891706b0b960d3d48
Author: Sergey Khodych 
Date:   Tue Aug 25 17:19:24 2009 +0300

user32: Use IDOK as default identifier in a template.

:040000 040000 ec277af366bead5d55f43d7fd8790c90b09a0fef
99d660168abb7fa82689691408113ac39339a863 M    dlls

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

--- Comment #2 from Dmitry Timoshkov   2010-07-01 00:10:10 ---
Bug 21295 suffers from the same commit.

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

Murray Colpman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Murray Colpman  2010-09-08 12:43:16 CDT ---
Wine 1.3.2 still contains this bug.

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

--- Comment #4 from Vladimir Panteleev  2010-09-10 06:40:51 CDT ---
Created an attachment (id=30675)
 --> (http://bugs.winehq.org/attachment.cgi?id=30675)
Simple MFC test case (executable and source)

Here is a very simple MFC application (created using the Visual Studio 2005
application wizard) which demonstrates this problem.

To reproduce, make sure that the edit control is focused and press Return. On
Windows a message box should pop up. Nothing happens on Wine.

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase
                 CC|                            |[e-mail]

--- Comment #5 from Wylda  2010-09-10 06:50:10 CDT ---

Hmmm... I know that commit ;) Although Sergey Khodych was the first breaker, it
was latter removed by Alexandre.

This helps in bug 21295:

--- orig/dlls/user32/dialog.c   2010-04-30 23:38:53.000000000 +0200
+++ new/dlls/user32/dialog.c    2010-04-30 23:39:44.000000000 +0200
@@ -672,6 +672,7 @@
     dlgInfo->hMenu       = hMenu;
     dlgInfo->xBaseUnit   = xBaseUnit;
     dlgInfo->yBaseUnit   = yBaseUnit;
+    dlgInfo->idResult    = 0;
     dlgInfo->flags       = flags;

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

Vladimir Panteleev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Vladimir Panteleev  2010-09-10 11:34:08 CDT ---
(In reply to comment #5)
> This helps in bug 21295:

Hmm... won't this make the test case attached to
f1f1c5053160777d0db89b1891706b0b960d3d48 fail?

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

--- Comment #7 from Vladimir Panteleev  2010-09-14 03:16:57 CDT ---
After a bit of research, I found that Wine's implementation of DM_GETDEFID, and
the mentioned commit, seem to be correct as far as this problem is concerned.
Windows behaves in the same way as Wine. The fact that DM_GETDEFID returning 0
used to allow MFC applications to function correctly seems to be a coincidence.

The problem probably presides in Wine's IsDialogMessage implementation. Windows
sends the WM_COMMAND message which triggers MFC's OnOK, while Wine does not. I
will continue my research.

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

--- Comment #8 from Vladimir Panteleev  2010-09-14 04:40:12 CDT ---
Actually, if you look at the IsDialogMessage implementation, it's quite clear
what's going on:

http://source.winehq.org/source/dlls/user32/dialog.c#L1224

DM_GETDEFID returns IDOK, but since there's no IDOK control on the dialog, Wine
decides to not do anything (instead of sending the IDOK like on line 1231).

I suppose I'll prepare a patch and testcase for the test suite.

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

--- Comment #9 from Vladimir Panteleev  2010-09-14 09:04:48 CDT ---
Created an attachment (id=30751)
 --> (http://bugs.winehq.org/attachment.cgi?id=30751)
Proposed fix and test

Here's the patch (and test). Comments are welcome.

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

--- Comment #10 from Juan Lang  2010-09-14 11:47:41 CDT ---
(In reply to comment #9)
> Here's the patch (and test). Comments are welcome.

At a quick glance this looks fine.  Please send to wine-patches.

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

--- Comment #11 from Vladimir Panteleev  2010-09-15 20:48:44 CDT ---
Thanks. The patch is now in:

http://source.winehq.org/git/wine.git/?a=commit;h=592d994f0077c19dc9fa2db988...

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

--- Comment #12 from Dmitry Timoshkov  2010-09-15 23:05:16 CDT ---
Fixed then?

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

--- Comment #13 from Vladimir Panteleev  2010-09-16 09:18:32 CDT ---
Well, as I specified on wine-patches, the patch fixes this bug as well as bug
21295 and bug 23936, at least according to my tests. Is a confirmation from
someone other than the patch author required?

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Dmitry Timoshkov  2010-09-16 09:32:00 CDT ---
Reported fixed.

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard  2010-09-18 13:06:19 CDT ---
Closing bugs fixed in 1.3.3.

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.2.x

[Bug 23453] Worms Armageddon cannot send text in WormNET

http://bugs.winehq.org/show_bug.cgi?id=23453

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.2.x                       |---

--- Comment #16 from Alexandre Julliard  2010-10-08 10:40:32 CDT ---
Removing 1.2.x milestone from bugs fixed in 1.2.1.