[Bug 52977] New: Build fails when passing --disable-vkd3d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52977

Bug ID: 52977
           Summary: Build fails when passing --disable-vkd3d
           Product: Wine
           Version: 7.8
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build-env
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hi all,

This is reproducible with Wine 7.8 but probably earlier versions too.

If you run ./configure with --disable-vkd3d, the build fails with the below
error:

Error with --with-mingw:

/usr/libexec/gcc/i686-w64-mingw32/ld: cannot find -lvkd3d
collect2: error: ld returned 1 exit status
winegcc: /usr/bin/i686-w64-mingw32-gcc failed
make: *** [Makefile:130204: dlls/wined3d/wined3d.dll] Error 2

Error with --without-mingw:

dlls/wined3d/wined3d.spec:319: function 'vkd3d_create_instance' not defined
dlls/wined3d/wined3d.spec:320: function 'vkd3d_instance_decref' not defined
... (other similar errors)
winegcc: ./tools/winebuild/winebuild failed
make: *** [Makefile:134505: dlls/wined3d/wined3d.dll.so] Error 2

If the configure log or build log will help let me know and I can attach it.

Thanks,
Sarnex

[Bug 52977] Build fails when passing --disable-vkd3d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52977

Chiitoo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 52977] Build fails when passing --disable-vkd3d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52977

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Zeb Figura  ---
Since vkd3d is bundled now, it's no longer optional for modules that depend on
it. You'll effectively need to disable all d3d modules.

What is the motivation for building without vkd3d support?

[Bug 52977] Build fails when passing --disable-vkd3d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52977

--- Comment #2 from [e-mail] ---
Thanks for the explanation.

In Gentoo the package manager exposes a configuration option to the user to
make this decision. They may choose to turn it off if they don't want to
compile their graphics driver with vulkan, or any other reason.

If vkd3d is bundled, what is https://source.winehq.org/git/vkd3d.git/ for?
Currently we package this library and depend on it if the user decides to
enable vkd3d. Do we not need to package and build this library?

Thanks,
Sarnex

[Bug 52977] Build fails when passing --disable-vkd3d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52977

Sveinar Søpler  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Sveinar Søpler  ---
(In reply to sarnex from comment #2)
> Thanks for the explanation.
>
> If vkd3d is bundled, what is https://source.winehq.org/git/vkd3d.git/ for?
> Currently we package this library and depend on it if the user decides to
> enable vkd3d. Do we not need to package and build this library?
>
> Thanks,
> Sarnex

It is the development branch of vkd3d. Then (hopefully) the wine git tree with
vkd3d will be updated for next release of vkd3d from git.

Atleast this is how i figure it works atm - Currently vkd3d release is at 1.3,
and ref to
https://gitlab.winehq.org/wine/wine/-/commit/97db56ab6146733141b3afc90252c06...
the included wine version is at 1.3

For those distro's providing only release versions of vkd3d, it is no longer
needed.

PS. I think there is a plan to have vkd3d/FAudio++ included with mingw-w64
eventually, but i guess there is some stuff to iron out still when it comes to
that... Sorry if i have misunderstood stuff :)

[Bug 52977] Build fails when passing --disable-vkd3d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52977

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #4 from [e-mail] ---
Ok thanks for the update, I guess our packaging is out of date. We'll stop
depending on the vkd3d development branch and remove the ability for the user
to disable vkd3d.

Sarnex

[Bug 52977] Build fails when passing --disable-vkd3d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52977

--- Comment #5 from Zeb Figura  ---
(In reply to sarnex from comment #2)
> If vkd3d is bundled, what is https://source.winehq.org/git/vkd3d.git/ for?

Sveinar is correct; that's the upstream source. We currently bundle stable
versions.
> Currently we package this library and depend on it if the user decides to
> enable vkd3d. Do we not need to package and build this library?

Packaging it the old way won't have any effect; we no longer depend on host
vkd3d.

It is possible to use external vkd3d, but it needs to be cross-compiled in PE
format, using the mingw-w64 cross-compiler and runtime. I would guess Gentoo
has no reason to be interested in this, but if they are, I can provide some
more concrete documentation.

[Bug 52977] Build fails when passing --disable-vkd3d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52977

--- Comment #6 from [e-mail] ---
Yeah I see no reason not to use the in-tree version of vkd3d. Thanks.

Sarnex

[Bug 52977] Build fails when passing --disable-vkd3d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52977

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Gijs Vermeulen  ---
Closing INVALID.