[Bug 26952] New: Taxman Spezial 2011 failed to install - netapi32.NetGetJoinInformation() returns success but contains no data

http://bugs.winehq.org/show_bug.cgi?id=26952

Summary: Taxman Spezial 2011 failed to install -
                    netapi32.NetGetJoinInformation() returns success but
                    contains no data
           Product: Wine
           Version: 1.3.18
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

I try to install Taxman Spezial 2011, the Installation fails after i accept the
software license and hit "continue installation". Then the installer crashs and
the window freezes.

focht on IRC told me that the problem might result of an the
NetGetJoinInformation() which returns success but does not contain any data.

[Bug 26952] Taxman Spezial 2011 failed to install - netapi32.NetGetJoinInformation() returns success but contains no data

http://bugs.winehq.org/show_bug.cgi?id=26952

--- Comment #1 from [e-mail] 2011-04-28 17:34:41 CDT ---
Created an attachment (id=34383)
 --> (http://bugs.winehq.org/attachment.cgi?id=34383)
output of wine

[Bug 26952] Taxman Spezial 2011 failed to install - netapi32.NetGetJoinInformation() returns success but contains no data

http://bugs.winehq.org/show_bug.cgi?id=26952

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34383|application/octet-stream    |text/plain
          mime type|                            |

[Bug 26952] Taxman Spezial 2011 failed to install - netapi32.NetGetJoinInformation() returns success but contains no data

http://bugs.winehq.org/show_bug.cgi?id=26952

--- Comment #2 from Juan Lang  2011-04-28 19:14:15 CDT ---
If that is the problem, then this is a dup of bug 26761.

[Bug 26952] Taxman Spezial 2011 failed to install - netapi32.NetGetJoinInformation() returns success but contains no data

http://bugs.winehq.org/show_bug.cgi?id=26952

--- Comment #3 from Austin English  2011-04-28 19:45:56 CDT ---
You could try returning an error instead of success in the stub, e.g.,
ERROR_CALL_NOT_IMPLEMENTED or ERROR_NOT_ENOUGH_MEMORY.

[Bug 26952] Taxman Spezial 2011 installer fails (netapi32.NetGetJoinInformation() should behave like a stub using ERROR_CALL_NOT_IMPLEMENTED retval)

http://bugs.winehq.org/show_bug.cgi?id=26952

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Installer
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
            Summary|Taxman Spezial 2011 failed  |Taxman Spezial 2011
                   |to install -                |installer fails
                   |netapi32.NetGetJoinInformat |(netapi32.NetGetJoinInforma
                   |ion() returns success but   |tion() should behave like a
                   |contains no data            |stub using
                   |                            |ERROR_CALL_NOT_IMPLEMENTED
                   |                            |retval)
     Ever Confirmed|0                           |1

--- Comment #4 from Anastasius Focht  2011-04-29 02:20:04 CDT ---
Hello,

well both approaches work.
Either return ERROR_CALL_NOT_IMPLEMENTED or provide some fake "Workgroup" in
buffer allocated with NetApiBufferAllocate().
I tested with Taxman 2011 - the installer is happy with both.

Needs winetricks msxml3 prerequisite to work around initial msxml3 crash.

Maybe this bug could be about NetGetJoinInformation() to behave like at stub
and not lie using "success" retval but simply stating
ERROR_CALL_NOT_IMPLEMENTED.

Bug 26761 could be about extending NetGetJoinInformation() to return meaningful
information (not only partial).

Maybe "netapi32" could be added to list of avail bugzilla components (one day
some more work is done) which helps properly track the issues.

Regards

[Bug 26952] Taxman Spezial 2011 installer fails (netapi32.NetGetJoinInformation() should behave like a stub using ERROR_CALL_NOT_IMPLEMENTED retval)

http://bugs.winehq.org/show_bug.cgi?id=26952

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |netapi32

--- Comment #5 from Austin English  2011-04-29 11:47:23 CDT ---
(In reply to comment #4)
> Hello,
>
> well both approaches work.
> Either return ERROR_CALL_NOT_IMPLEMENTED or provide some fake "Workgroup" in
> buffer allocated with NetApiBufferAllocate().
> I tested with Taxman 2011 - the installer is happy with both.

http://www.winehq.org/pipermail/wine-patches/2011-April/101401.html
> Maybe "netapi32" could be added to list of avail bugzilla components (one day
> some more work is done) which helps properly track the issues.

Done.

[Bug 26952] Taxman Spezial 2011 installer fails (netapi32.NetGetJoinInformation() should behave like a stub using ERROR_CALL_NOT_IMPLEMENTED retval)

http://bugs.winehq.org/show_bug.cgi?id=26952

--- Comment #6 from Louis Lenders  2011-06-04 10:42:38 CDT ---
Created an attachment (id=35016)
 --> (http://bugs.winehq.org/attachment.cgi?id=35016)
return some useful fake values in NetGetJoinInformation

I think the attached patch should fix the bug; it doesn't fix the crash in
SIV32.EXE though, but afiacs this is due to another bug

[Bug 26952] Taxman Spezial 2011 installer fails (netapi32.NetGetJoinInformation() should behave like a stub using ERROR_CALL_NOT_IMPLEMENTED retval)

http://bugs.winehq.org/show_bug.cgi?id=26952

--- Comment #7 from Louis Lenders  2011-06-04 12:13:15 CDT ---
Created an attachment (id=35019)
 --> (http://bugs.winehq.org/attachment.cgi?id=35019)
 some simple tests for NetGetJoinInformation

i wrote small test for NetGetJoinInformation; i'll send to wine-patches lateron

[Bug 26952] Taxman Spezial 2011 installer fails (netapi32.NetGetJoinInformation() should behave like a stub using ERROR_CALL_NOT_IMPLEMENTED retval)

http://bugs.winehq.org/show_bug.cgi?id=26952

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Louis Lenders  2011-06-13 11:30:23 CDT ---
A better stub for NetGetJoinInformation is in git now. Does the app start now
in current git (new release?))

[Bug 26952] Taxman Spezial 2011 installer fails (netapi32.NetGetJoinInformation() should behave like a stub using ERROR_CALL_NOT_IMPLEMENTED retval)

http://bugs.winehq.org/show_bug.cgi?id=26952

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Anastasius Focht  2011-06-13 13:06:00 CDT ---
Hello Louis,

--- quote ---
A better stub for NetGetJoinInformation is in git now. Does the app start now
in current git (new release?))
--- quote ---

the Lexware installers partly work now (with some workarounds like msxml3
and/or .NET).
The apps suffer from different bugs.

This bug was fixed by commit:
http://source.winehq.org/git/wine.git/commitdiff/ed28cab62488d58a8e2d6d4c675...

Thanks!

Regards

[Bug 26952] Taxman Spezial 2011 installer fails (netapi32.NetGetJoinInformation() should behave like a stub using ERROR_CALL_NOT_IMPLEMENTED retval)

http://bugs.winehq.org/show_bug.cgi?id=26952

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  2011-06-24 17:43:23 CDT ---
Closing bugs fixed in 1.3.23.

[Bug 26952] Taxman Spezial 2011 installer fails (netapi32.NetGetJoinInformation() should behave like a stub using ERROR_CALL_NOT_IMPLEMENTED retval)

http://bugs.winehq.org/show_bug.cgi?id=26952

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |ed28cab62488d58a8e2d6d4c675
                   |                            |b548512f1f230