http://bugs.winehq.org/show_bug.cgi?id=30308
Bug #: 30308 Summary: Property sheet fails to display Page Title Product: Wine Version: 1.5.0 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: comctl32 AssignedTo: wine-bugs@winehq.org ReportedBy: leslie_alistair@hotmail.com Classification: Unclassified
Created attachment 39609 --> http://bugs.winehq.org/attachment.cgi?id=39609 Screenshot of PropertySheet - Left Windows, Right WINE.
When a header bitmap isn't passed to PropertySheet. The Title text is not display on the dialog.
http://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #1 from Vitaliy Margolen vitaliy-bugzilla@kievinfo.com 2012-03-29 21:34:55 CDT --- Does it work with native comctl32?
http://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #2 from Alistair Leslie-Hughes leslie_alistair@hotmail.com 2012-03-30 06:10:15 CDT --- Yes, it works correctly with native comctl32.
http://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com 2012-05-16 13:20:06 CDT --- It's a dialogue from Enterprise Architect I suppose? Could you attach +propsheet,+tid for that?
http://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #4 from Alistair Leslie-Hughes leslie_alistair@hotmail.com 2012-05-17 17:48:57 CDT --- Created attachment 40212 --> http://bugs.winehq.org/attachment.cgi?id=40212 +propsheet,+tid
http://bugs.winehq.org/show_bug.cgi?id=30308
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
--- Comment #5 from Jerome Leclanche adys.wh@gmail.com 2012-09-12 14:09:01 CDT --- Was this fixed?
http://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #6 from Alistair Leslie-Hughes leslie_alistair@hotmail.com 2012-09-12 17:54:29 CDT --- This issue still occurs in 1.5.12.
https://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #7 from Austin English austinenglish@gmail.com --- This is your friendly reminder that there has been no bug activity for 2 years. Is this still an issue in current (1.7.28 or newer) wine? If so, please attach the terminal output in 1.7.28 (see http://wiki.winehq.org/FAQ#get_log).
https://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #8 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Still an issue with 1.7.28.
https://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #9 from Nikolay Sivov bunglehead@gmail.com --- Hi, Alistair.
Could you produce a test case application that only displays this wizard with missing header?
https://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #10 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Created attachment 56861 --> https://bugs.winehq.org/attachment.cgi?id=56861 Example project
This is a example of when the title fails to be displayed.
https://bugs.winehq.org/show_bug.cgi?id=30308
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase
https://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #11 from Nikolay Sivov bunglehead@gmail.com --- Created attachment 56875 --> https://bugs.winehq.org/attachment.cgi?id=56875 patch
Thanks.
Could you test this patch? In particular it's interesting to see how it's supposed to work if there's more than one page, and some have title/subtitle strings and some don't. Should it hide header for some pages and show for others, or is it always on.
https://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #12 from Alistair Leslie-Hughes leslie_alistair@hotmail.com ---
Could you test this patch? In particular it's interesting to see how it's supposed to work if there's more than one page, and some have title/subtitle strings and some don't. Should it hide header for some pages and show for others, or is it always on.
Thanks,
The patch works as expected.
After a quick test. When multiple pages are used the title is always displayed when any of them have strings.
https://bugs.winehq.org/show_bug.cgi?id=30308
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs@winehq.org |bunglehead@gmail.com
--- Comment #13 from Nikolay Sivov bunglehead@gmail.com --- Thanks.
Another difference from Windows is header background color. With Wine it's always white, while on Windows it's only white when bitmap is set, otherwise it's using window color like the rest of the dialog.
https://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #14 from Nikolay Sivov bunglehead@gmail.com --- Created attachment 56879 --> https://bugs.winehq.org/attachment.cgi?id=56879 patch2
Additional patch for header painting issue.
https://bugs.winehq.org/show_bug.cgi?id=30308
--- Comment #15 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- (In reply to Nikolay Sivov from comment #14)
Created attachment 56879 [details] patch2
Additional patch for header painting issue.
Thanks. Its appears to work the same as windows now ;)
https://bugs.winehq.org/show_bug.cgi?id=30308
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #16 from winetest@luukku.com --- Patches got merged.
https://bugs.winehq.org/show_bug.cgi?id=30308
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |34dd326060e7458661aa0644e3a | |a81503cc5097d
--- Comment #17 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Fixed by http://source.winehq.org/git/wine.git/?a=commit;h=34dd326060e7458661aa0644e3... http://source.winehq.org/git/wine.git/?a=commit;h=6eafebedb88ccd00aac6b838fd...
https://bugs.winehq.org/show_bug.cgi?id=30308
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #18 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 2.1.
https://bugs.winehq.org/show_bug.cgi?id=30308
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|bunglehead@gmail.com |wine-bugs@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=30308
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.0.x
https://bugs.winehq.org/show_bug.cgi?id=30308
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.0.x |---
--- Comment #19 from Michael Stefaniuc mstefani@winehq.org --- Removing the 2.0.x milestone from bugs included in 2.0.1.