[Bug 44229] New: Visual C++ 1.51 can't add files to project ( GetOpenFileName16() doesn't support custom templates or hooks)

https://bugs.winehq.org/show_bug.cgi?id=44229

Bug ID: 44229
           Summary: Visual C++ 1.51 can't add files to project
                    (GetOpenFileName16() doesn't support custom templates
                    or hooks)
           Product: Wine
           Version: 3.0-rc3
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comdlg32
          Assignee: [e-mail]
          Reporter: [e-mail]
   Regression SHA1: 424472c20d8059057277ae13a0ffe5c51a818e52
      Distribution: ---

The Project -> Edit menu is missing the "Files in Project" box as well as the
Add / Add All / Delete buttons. This is because we don't support custom
templates or hooks anymore:

0031:fixme:commdlg:GetOpenFileName16 custom templates no longer supported,
using default
0031:fixme:commdlg:GetOpenFileName16 custom hook 0x16670010 no longer supported

While hooks would probably be simple enough to implement, templates will be
much more difficult and will probably require significant duplication of code
from user.exe16:dialog.c. Is there a reason to implement commdlg on top of
comdlg32 besides avoiding duplication?

[Bug 44229] Visual C++ 1.51 can't add files to project (GetOpenFileName16( ) doesn't support custom templates or hooks)

https://bugs.winehq.org/show_bug.cgi?id=44229

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression, win16

[Bug 44229] Visual C++ 1.51 can't add files to project (GetOpenFileName16( ) doesn't support custom templates or hooks)

https://bugs.winehq.org/show_bug.cgi?id=44229

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 44229] Visual C++ 1.51 can't add files to project (GetOpenFileName16( ) doesn't support custom templates or hooks)

https://bugs.winehq.org/show_bug.cgi?id=44229

--- Comment #1 from Alexandre Julliard  ---
Avoiding duplication is one reason, the other is that we don't want to export a
whole bunch of 16-bit functionality from user32.

[Bug 44229] Visual C++ 1.51 can't add files to project (GetOpenFileName16( ) doesn't support custom templates or hooks)

https://bugs.winehq.org/show_bug.cgi?id=44229

--- Comment #2 from Zebediah Figura  ---
(In reply to Alexandre Julliard from comment #1)
> Avoiding duplication is one reason, the other is that we don't want to
> export a whole bunch of 16-bit functionality from user32.

How should custom templates be implemented, while avoiding both of these
things?

[Bug 44229] Visual C++ 1.51 can't add files to project (GetOpenFileName16( ) doesn't support custom templates or hooks)

https://bugs.winehq.org/show_bug.cgi?id=44229

--- Comment #3 from Alexandre Julliard  ---
(In reply to Zebediah Figura from comment #2)
> (In reply to Alexandre Julliard from comment #1)
> > Avoiding duplication is one reason, the other is that we don't want to
> > export a whole bunch of 16-bit functionality from user32.
>
> How should custom templates be implemented, while avoiding both of these
> things?

I doubt that's possible.

[Bug 44229] Visual C++ 1.51 can't add files to project (GetOpenFileName16( ) doesn't support custom templates or hooks)

https://bugs.winehq.org/show_bug.cgi?id=44229

--- Comment #4 from Alexandre Julliard  ---
FWIW I've implemented custom templates in
0e9cb103400c58480778894cb0e4a3d2dec9a3b4. It probably won't do much good
without hooks though.

[Bug 44229] Visual C++ 1.51 can't add files to project (GetOpenFileName16( ) doesn't support custom templates or hooks)

https://bugs.winehq.org/show_bug.cgi?id=44229

--- Comment #5 from Zebediah Figura  ---
(In reply to Alexandre Julliard from comment #4)
> FWIW I've implemented custom templates in
> 0e9cb103400c58480778894cb0e4a3d2dec9a3b4. It probably won't do much good
> without hooks though.

Thanks. I'll take a look at implementing hooks; I was mostly just unsure of
what design direction to take regarding this.

[Bug 44229] Visual C++ 1.51 can't add files to project (GetOpenFileName16( ) doesn't support custom templates or hooks)

https://bugs.winehq.org/show_bug.cgi?id=44229

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |59df6651b88456b38ac816de0a0
                   |                            |7a544aae346e8
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Alexandre Julliard  ---
Hooks reimplemented in 59df6651b88456b38ac816de0a07a544aae346e8.

[Bug 44229] Visual C++ 1.51 can't add files to project (GetOpenFileName16( ) doesn't support custom templates or hooks)

https://bugs.winehq.org/show_bug.cgi?id=44229

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 4.0-rc2.

[Bug 44229] Visual C++ 1.51 can't add files to project (GetOpenFileName16( ) doesn't support custom templates or hooks)

https://bugs.winehq.org/show_bug.cgi?id=44229

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.0.x

[Bug 44229] Visual C++ 1.51 can't add files to project (GetOpenFileName16( ) doesn't support custom templates or hooks)

https://bugs.winehq.org/show_bug.cgi?id=44229

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.0.x                       |---

--- Comment #8 from Michael Stefaniuc  ---
Removing the 3.0.x milestone from bug fixes included in 3.0.5.