[Bug 48119] New: The tests sometimes trigger "critical section is not acquired" errors

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48119

Bug ID: 48119
           Summary: The tests sometimes trigger "critical section is not
                    acquired" errors
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: kernel32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

The logs of most test runs, WineTest and others, contain critical section
errors complaining that the critical section was not acquired before being
released.
Most are caused by the following two tests:

msvcp120:msvcp120 intentionally triggers one such error in test_threads__Mtx().
It's easy to identify because it follows a bunch of CreateSymbolicLinkA()
fixmes:

0044:fixme:file:CreateSymbolicLinkA ("tr2_test_dir/f1_symlink"
"tr2_test_dir/f1" 0): stub
0044:fixme:msvcp:_Mtx_init_in_situ unknown flags ignored: beef
0044:err:ntdll:RtlLeaveCriticalSection section 0x622088 is not acquired

ntdll:rtl intentionally triggers two such errors in
test_RtlLeaveCriticalSection(). They stand alone but would typically follow a
bunch of RtlGetCompressionWorkSpaceSize fixmes from previous tests:
https://testbot.winehq.org/JobDetails.pl?Key=60096

0009:err:ntdll:RtlLeaveCriticalSection section 0x7bfd88 is not acquired
0009:err:ntdll:RtlLeaveCriticalSection section 0x7bfd88 is not acquired

But there are other logs that contain this error with no identified source. For
instance in task 60103/4/2 (wow64) which is for an unrelated patch and only
runs kernel32 tests which do not normally trigger this error:
https://testbot.winehq.org/JobDetails.pl?Key=60103#k402

[...]
Extracting: Done (1 of 1)
Running tests
003e:err:ntdll:RtlLeaveCriticalSection section 0x14c80 is not acquired
002e:fixme:console:GetConsoleProcessList ((nil),0): stub
[...]

Or task 59774/4/1 (win32) which only ran comctl32 tests:
https://testbot.winehq.org/JobDetails.pl?Key=59774#k401

Or task 59426/1/1 (wow32) which only ran user32 tests:
https://testbot.winehq.org/JobDetails.pl?Key=59426

Or task 59176/3/1 (wow32/wow64?) which, again, only ran user32 tests:
https://testbot.winehq.org/JobDetails.pl?Key=59176#k301

Or task 59042/1/1 (wow32/wow64?) which, again,  only ran user32 tests:
https://testbot.winehq.org/JobDetails.pl?Key=59042#k101

[Bug 48119] The tests sometimes trigger "critical section is not acquired" errors

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48119

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from François Gouget  ---
If I remember correctly this was caused by some bug on exit of a Wine helper
process such as explorer.exe or winedevice.exe or similar which has been fixed
since. In any case a grep of the TestBot logs does not find any occurrence so I
think this is fixed.

[Bug 48119] The tests sometimes trigger "critical section is not acquired" errors

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48119

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard  ---
Closing bugs fixed in 6.23.