[Bug 25116] New: Fiddler crashes due to OutOfMemoryException

http://bugs.winehq.org/show_bug.cgi?id=25116

Summary: Fiddler crashes due to OutOfMemoryException
           Product: Wine
           Version: 1.3.6
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=31855)
 --> (http://bugs.winehq.org/attachment.cgi?id=31855)
backtrace and log

Using dotnet20 from winetricks enables Fiddler
(http://appdb.winehq.org/objectManager.php?sClass=version&iId=19766) to run but
soon crashes with out of memory exception.

[Bug 25116] Fiddler crashes due to OutOfMemoryException

http://bugs.winehq.org/show_bug.cgi?id=25116

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
             Status|UNCONFIRMED                 |NEW
                URL|                            |http://www.fiddler2.com/fid
                   |                            |dler2/version.asp
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #1 from Louis Lenders  2010-11-11 14:59:29 CST ---
Confirming.
> From a debug log it looks like the error occurs here:

0009:Call user32.GetWindowTextLengthW(0001006e) ret=00c0af56
.
.
.
.
0009:Ret  user32.GetWindowTextLengthW() retval=10000000 ret=00c0af56
0009:Call user32.GetSystemMetrics(0000002a) ret=00c0a482
0009:Ret  user32.GetSystemMetrics() retval=00000000 ret=00c0a482
0009:Call KERNEL32.VirtualAlloc(00000000,20800000,00202000,00000004)
ret=00554a2b
0009:Ret  KERNEL32.VirtualAlloc() retval=00000000 ret=00554a2b
0009:Call KERNEL32.ResetEvent(000000d0) ret=00554b94
0009:Ret  KERNEL32.ResetEvent() retval=00000001 ret=00554b94
0009:Call KERNEL32.GetLastError() ret=005543db
0009:Ret  KERNEL32.GetLastError() retval=00000008 ret=005543db

AFAICS GetWindowTextLengthW returns a ridiculous high textlength. I guess
that's why the VirtualAlloc fails. A quick hack in GetWindowTextLengthW like
below makes the application start fine for me.

--- a/dlls/user32/win.c
+++ b/dlls/user32/win.c
@@ -2589,8 +2589,10 @@ INT WINAPI GetWindowTextLengthA( HWND hwnd )
  *             GetWindowTextLengthW (USER32.@)
  */
 INT WINAPI GetWindowTextLengthW( HWND hwnd )
-{
-    return SendMessageW( hwnd, WM_GETTEXTLENGTH, 0, 0 );
+{ int l;
+
+    l = SendMessageW( hwnd, WM_GETTEXTLENGTH, 0, 0 );
+    if (l>50000) return 0; else return l;
 }

[Bug 25116] Fiddler crashes due to OutOfMemoryException

http://bugs.winehq.org/show_bug.cgi?id=25116

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 25116] Fiddler crashes due to OutOfMemoryException

http://bugs.winehq.org/show_bug.cgi?id=25116

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from André H.  2011-12-28 19:09:57 CST ---
i suspect
http://source.winehq.org/git/wine.git/blob?f=dlls/comctl32/status.c#l559 does
removing that line helps?

[Bug 25116] Fiddler crashes due to OutOfMemoryException

http://bugs.winehq.org/show_bug.cgi?id=25116

--- Comment #3 from André H.  2012-01-01 11:22:52 CST ---
http://source.winehq.org/patches/data/82290

[Bug 25116] Fiddler crashes due to OutOfMemoryException

http://bugs.winehq.org/show_bug.cgi?id=25116

--- Comment #4 from André H.  2012-01-20 13:34:58 CST ---
try 2:
http://source.winehq.org/patches/data/83007

[Bug 25116] Fiddler crashes due to OutOfMemoryException

http://bugs.winehq.org/show_bug.cgi?id=25116

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Bruno Jesus  2012-01-23 16:41:32 CST ---
Patch commited:
http://source.winehq.org/git/wine.git/commit/80d9017e037b580e7736cf984151da3...

[Bug 25116] Fiddler crashes due to OutOfMemoryException

http://bugs.winehq.org/show_bug.cgi?id=25116

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |comctl32

[Bug 25116] Fiddler crashes due to OutOfMemoryException

http://bugs.winehq.org/show_bug.cgi?id=25116

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |80d9017e037b580e7736cf98415
                   |                            |1da3a89005403
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from André H.  2012-01-24 05:21:49 CST ---
fixed

[Bug 25116] Fiddler crashes due to OutOfMemoryException

http://bugs.winehq.org/show_bug.cgi?id=25116

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2012-01-27 14:18:21 CST ---
Closing bugs fixed in 1.4-rc1.