[Bug 19081] New: Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19081

Summary: Force closing winhlp32 without a file loaded pops up
                    an error dialog (appinstall)
           Product: Wine
           Version: 1.1.24
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: minor
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=22023)
 --> (http://bugs.winehq.org/attachment.cgi?id=22023)
ahk test

A bit hard to explain...but launching 'wine winhlp32' with no arguments open
wine help, along with a file open dialog. That's all well and good, same as
windows. Now, let's get tricky. Force the winhlp32 window to close (not the
file open dialog). On windows, exits with no problems. On wine, pops up a
dialog:
ERROR
Cannot find ''. Do you want to find this file yourself?

I'll attach an AHK script to show what I mean...If you want to verify on
windows, change 'Wine' to 'Windows'.

[Bug 19081] Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19081

--- Comment #1 from Owen Rudge   2009-07-21 22:28:57 ---
Created an attachment (id=22519)
 --> (http://bugs.winehq.org/attachment.cgi?id=22519)
Patch to ensure Open window has an owner

I could not reproduce this bug specifically with current git (Wine 1.1.26) on
Mac OS X (I don't currently have access to a Linux box), although I did find
that the Open dialog would stay open despite the main winhelp window having
closed, which may be related. The attached patch gives the open dialog an owner
- for me now, the Open window closes when AutoHotKey tells the winhelp window
to close (as it does when using the standard Windows winhlp32). Does this fix
your issue?

[Bug 19081] Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19081

Owen Rudge  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 19081] Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19081

--- Comment #2 from Austin English   2009-07-22 17:33:18 ---
(In reply to comment #1)
> Created an attachment (id=22519)

--> (http://bugs.winehq.org/attachment.cgi?id=22519) [details]
> Patch to ensure Open window has an owner
>
> I could not reproduce this bug specifically with current git (Wine 1.1.26) on
> Mac OS X (I don't currently have access to a Linux box), although I did find
> that the Open dialog would stay open despite the main winhelp window having
> closed, which may be related. The attached patch gives the open dialog an owner
> - for me now, the Open window closes when AutoHotKey tells the winhelp window
>
> to close (as it does when using the standard Windows winhlp32). Does this fix
> your issue?

There are actually three bugs here, which I should've more fully explained.

1) Launching 'winhlp32' then closing 'Wine/Windows Help' not the open dialog
should close winhelp and the open dialog. Your patch fixes that.
2) On wine, the "ERROR: Cannot find ''...." dialog comes up after closing. This
doesn't happen on windows.
3) Just found this one, but on windows, run 'winhlp32'. Now close the open
dialog. winhlp32 goes with it.

You patches fixes issue 1. 2&3 remain with/without your patch.

[Bug 19081] Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19081

--- Comment #3 from Owen Rudge   2009-07-22 17:41:05 ---
(In reply to comment #2)
> - On wine, the "ERROR: Cannot find ''...." dialog comes up after closing. This
>
> doesn't happen on windows.

Hmm, that doesn't happen for me on OS X with the Wine winhlp32. I may try to
look into it when I get back to a Linux machine.
> - Just found this one, but on windows, run 'winhlp32'. Now close the open
>
> dialog. winhlp32 goes with it.

I guess it could be argued that that is a 'design difference' rather than a
'bug'. :) Should be relatively straightforward to have the behaviour match that
of the Windows winhlp32, though.

[Bug 19081] Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19081

--- Comment #4 from Austin English   2009-07-22 20:33:22 ---
(In reply to comment #3)
> (In reply to comment #2)
> > - On wine, the "ERROR: Cannot find ''...." dialog comes up after closing. This
> >
> > doesn't happen on windows.
>
> Hmm, that doesn't happen for me on OS X with the Wine winhlp32. I may try to
> look into it when I get back to a Linux machine.

It only happens under AutoHotKey, when force closing the parent window. I don't
know how to force the parent to close without using AHK.

[Bug 19081] Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19081

--- Comment #5 from Owen Rudge   2009-07-22 20:38:33 ---
(In reply to comment #4)
> It only happens under AutoHotKey, when force closing the parent window. I don't
> know how to force the parent to close without using AHK.

Yep, I am using AutoHotKey to test. No message pops up for me on OS X.

[Bug 19081] Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19081

nathan.n  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 19081] Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19081

--- Comment #6 from [e-mail] 2013-06-27 12:26:11 CDT ---
This ticket has not been updated for over 900 days.

Is this still an issue in wine version 1.6-rc3 or higher or is this to be
closed as abandoned ?

[Bug 19081] Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

https://bugs.winehq.org/show_bug.cgi?id=19081

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 19081] Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

https://bugs.winehq.org/show_bug.cgi?id=19081

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #7 from Anastasius Focht  ---
Hello folks,

please retest using recent Wine version, preferably 1.7.55 or later.

Regards

[Bug 19081] Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

https://bugs.winehq.org/show_bug.cgi?id=19081

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Austin English  ---
Working in wine-1.9.6-195-gd04a548.

[Bug 19081] Force closing winhlp32 without a file loaded pops up an error dialog (appinstall)

https://bugs.winehq.org/show_bug.cgi?id=19081

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.7.