[Bug 24699] New: Explorer++ crashes when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

Summary: Explorer++ crashes when closing a tab
           Product: Wine
           Version: 1.3.4
          Platform: x86-64
               URL: http://www.explorerplusplus.com/download
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=31210)
 --> (http://bugs.winehq.org/attachment.cgi?id=31210)
Terminal output w/ backtrace

Steps to reproduce:

1. Start Explorer++ and make another tab by double-clicking an empty space on
the tab bar
2. Click the close icon on the right side of the tab bar (supposed to be an X,
but right now it looks more like a square)

Instead of closing the active tab, the program crashes with an unhandled page
fault. I tried to test winetricks comctl32 as a potential workaround, but it
made the program crash on startup...

[Bug 24699] Explorer++ crashes when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

A Wine user  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

[Bug 24699] Explorer++ crashes when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

--- Comment #1 from Nikolay Sivov  2010-10-10 12:11:10 CDT ---
This one is harmless:

---
err:listview:LISTVIEW_WindowProc unknown msg 108a wp=00000000 lp=0032dbd8
---

and regarding a crash - I'll look into their sources next week.

[Bug 24699] Explorer++ crashes when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

--- Comment #2 from Nikolay Sivov  2010-10-10 13:29:20 CDT ---
Attach +tid,+toolbar,+tab please.

[Bug 24699] Explorer++ crashes when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

--- Comment #3 from A Wine user  2010-10-11 07:57:38 CDT ---
Created an attachment (id=31219)
 --> (http://bugs.winehq.org/attachment.cgi?id=31219)
+tid,+toolbar,+tab log

[Bug 24699] Explorer++ crashes when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

--- Comment #4 from A Wine user  2010-10-17 09:19:29 CDT ---
I got the program to work with native comctl32 (version 6) but it didn't
prevent this crash...

[Bug 24699] Explorer++ crashes when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

A Wine user  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |shell32

--- Comment #5 from A Wine user  2011-09-21 01:51:17 CDT ---
Still present in wine-1.3.28-421-gb615335.

This bug doesn't occur if native shell32, shlwapi, and comctl32 are used.
Native shell32 can't be tested here without the other two, but using only
native shlwapi and comctl32 brings back the bug, so it seems to be a shell32
problem.

That said, it might be worth noting that using only native comctl32 seems to
delay the crash. After clicking the close tab button, the program crashes
immediately while using builtin comctl32, but it switches to another tab before
crashing with native comctl32... the backtrace looks about the same either way,
though.

[Bug 24699] Explorer++ crashes when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Frédéric Delanoy  2013-05-16 03:10:46 CDT ---
Can't reproduce with wine 1.5.30 and explorer++ 1.3.5.

Can you please retry ?

[Bug 24699] Explorer++ crashes when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

--- Comment #7 from Bruno Jesus  2013-05-16 09:18:11 CDT ---
Created attachment 44482
  --> http://bugs.winehq.org/attachment.cgi?id=44482
crash in wine-1.5.30-88-g7559526

Judging by the date the most probably version the user was using is Explorer++
1.2 released in September 2010.
http://explorerplusplus.com/software/explorer++_1.2_x86.zip

I can still reproduce the issue, it's somewhat random. To reproduce it click on
My Computer in the left tree, click twice in Drive C in the right pane. This
will open a new tab. Try to go back to the My Computer tab. Now go back to C
and try to close it. If the problem does not happen switch tabs and try again.

[Bug 24699] Explorer++ crashes when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #8 from Frédéric Delanoy  2013-05-16 11:34:27 CDT ---
(In reply to comment #7)
> Created attachment 44482 [details]
> crash in wine-1.5.30-88-g7559526
>
> Judging by the date the most probably version the user was using is Explorer++
> 1.2 released in September 2010.
> http://explorerplusplus.com/software/explorer++_1.2_x86.zip
>
> I can still reproduce the issue, it's somewhat random. To reproduce it click on
> My Computer in the left tree, click twice in Drive C in the right pane. This
> will open a new tab. Try to go back to the My Computer tab. Now go back to C
> and try to close it. If the problem does not happen switch tabs and try again.

Can reproduce reliably using the procedure explained by the OP with
explorer++-1.2 and the same wine version (1.5.30-88-g7559526)

[Bug 24699] Explorer++ 1.2: crash when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://www.explorerplusplus |http://explorerplusplus.com
                   |.com/download               |/software/explorer++_1.2_x8
                   |                            |6.zip
            Summary|Explorer++ crashes when     |Explorer++ 1.2: crash when
                   |closing a tab               |closing a tab

[Bug 24699] Explorer++ 1.2: crash when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

--- Comment #9 from Nikolay Sivov  2013-05-16 12:38:05 CDT ---
Is it possible to make use of pdbs or whatever they use to build this program
to get debug info and crash location?

[Bug 24699] Explorer++ 1.2: crash when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

--- Comment #10 from Frédéric Delanoy  2013-05-16 14:03:58 CDT ---
(In reply to comment #9)
> Is it possible to make use of pdbs or whatever they use to build this program
> to get debug info and crash location?
> From the source code at

http://explorerplusplus.com/software/explorer++_1.2_src.zip, it looks like a
VC++ project using VS2010, but I've no VS available.

[Bug 24699] Explorer++ 1.2: crash when closing a tab

http://bugs.winehq.org/show_bug.cgi?id=24699

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from [e-mail] ---
This issue is still there

wine 1.7.22

[Bug 24699] Explorer++ 1.2: crash when closing a tab

https://bugs.winehq.org/show_bug.cgi?id=24699

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from [e-mail] ---
The program just fades away when you close a tab.

wine-1.7.49-41-g36a39ce

[Bug 24699] Explorer++ 1.2: crash when closing a tab

https://bugs.winehq.org/show_bug.cgi?id=24699

Michael Müller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Michael Müller  ---
Could you please test the following two patches which should fix the bug?

https://github.com/wine-compholio/wine-staging/tree/master/patches/shell32-I...

[Bug 24699] Explorer++ 1.2: crash when closing a tab

https://bugs.winehq.org/show_bug.cgi?id=24699

--- Comment #14 from [e-mail] ---
I tried with 2 different explorer versions. The patches work like they should
when you open a new tab(s) File --> New tab and close them. It works until you
close the last tab --> program fades away.

There is definitely improvement here.

applied top of wine-git.

[Bug 24699] Explorer++ 1.2: crash when closing a tab

https://bugs.winehq.org/show_bug.cgi?id=24699

Michael Müller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |STAGED
                 CC|                            |[e-mail]
    Staged patchset|                            |https://github.com/wine-com
                   |                            |pholio/wine-staging/tree/ma
                   |                            |ster/patches/shell32-IDragS
                   |                            |ourceHelper

[Bug 24699] Explorer++ 1.2: crash when closing a tab

https://bugs.winehq.org/show_bug.cgi?id=24699

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 24699] Explorer++ 1.2: crash when closing a tab

https://bugs.winehq.org/show_bug.cgi?id=24699

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |117c0dc5ba81fb44be2fb4a7910
                   |                            |6533d67135751
         Resolution|---                         |FIXED
             Status|STAGED                      |RESOLVED

--- Comment #15 from Nikolay Sivov  ---
Fixed with 117c0dc5ba81fb44be2fb4a79106533d67135751.

[Bug 24699] Explorer++ 1.2: crash when closing a tab

https://bugs.winehq.org/show_bug.cgi?id=24699

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard  ---
Closing bugs fixed in 2.0-rc1.