[Bug 43939] New: comctl32 cannot load its assembly on arm

https://bugs.winehq.org/show_bug.cgi?id=43939

Bug ID: 43939
           Summary: comctl32 cannot load its assembly on arm
           Product: Wine
           Version: 2.19
          Hardware: arm
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

../../../tools/runtest -q -P wine -T ../../.. -M comctl32.dll -p
comctl32_test.exe.so button && touch button.ok
fixme:actctx:parse_depend_manifests Could not find dependent assembly
L"microsoft.windows.common-controls" (6.0.0.0)
v6util.h:149: Test failed: failed to find comctl32.dll in active context, 14007
Makefile:218: recipe for target 'button.ok' failed
make: *** [button.ok] Error 1

Most of the comctl32 tests fail as a result.

The manifest is there, afaict:
(stretch)austin@localhost:~/.wine/drive_c/windows/winsxs/manifests$ ls -al
total 48
drwxr-xr-x.  2 austin austin 4096 Oct 28 15:56 .
drwxr-xr-x. 13 austin austin 4096 Oct 28 15:56 ..
-rw-r--r--.  1 austin austin  326 Oct 28 16:17
none_microsoft-windows-msxml30_31bf3856ad364e35_6.0.6000.16386_none_deadbeef.manifest
-rw-r--r--.  1 austin austin  326 Oct 28 16:17
none_microsoft-windows-msxml60_31bf3856ad364e35_6.0.6000.16386_none_deadbeef.manifest
-rw-r--r--.  1 austin austin  310 Oct 28 16:17
none_microsoft.msxml2_6bd6b9abf345378f_4.1.0.0_none_deadbeef.manifest
-rw-r--r--.  1 austin austin  318 Oct 28 16:17
none_microsoft.vc80.atl_1fc8b3b9a1e18e3b_8.0.50727.4053_none_deadbeef.manifest
-rw-r--r--.  1 austin austin  378 Oct 28 16:17
none_microsoft.vc80.crt_1fc8b3b9a1e18e3b_8.0.50727.4053_none_deadbeef.manifest
-rw-r--r--.  1 austin austin  318 Oct 28 16:17
none_microsoft.vc90.atl_1fc8b3b9a1e18e3b_9.0.30729.6161_none_deadbeef.manifest
-rw-r--r--.  1 austin austin  378 Oct 28 16:17
none_microsoft.vc90.crt_1fc8b3b9a1e18e3b_9.0.30729.6161_none_deadbeef.manifest
-rw-r--r--.  1 austin austin 1576 Oct 28 16:17
none_microsoft.windows.common-controls_6595b64144ccf1df_6.0.2600.2982_none_deadbeef.manifest
-rw-r--r--.  1 austin austin  327 Oct 28 16:17
none_microsoft.windows.gdiplus_6595b64144ccf1df_1.0.6000.16386_none_deadbeef.manifest
-rw-r--r--.  1 austin austin  310 Oct 28 16:17
none_microsoft.windows.gdiplus_6595b64144ccf1df_1.1.7601.23038_none_deadbeef.manifest

(stretch)austin@localhost:~/.wine/drive_c/windows/winsxs/manifests$ cat
none_microsoft.windows.common-controls_6595b64144ccf1df_6.0.2600.2982_none_deadbeef.manifest 
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
  <assemblyIdentity type="win32" name="Microsoft.Windows.Common-Controls"
version="6.0.2600.2982" processorArchitecture="none"
publicKeyToken="6595b64144ccf1df"/>
  <file name="comctl32.dll">
    <windowClass>Button</windowClass>
    <windowClass>ButtonListBox</windowClass>
    <windowClass>ComboBoxEx32</windowClass>
    <windowClass>ComboLBox</windowClass>
    <windowClass>Combobox</windowClass>
    <windowClass>Edit</windowClass>
    <windowClass>Listbox</windowClass>
    <windowClass>NativeFontCtl</windowClass>
    <windowClass>ReBarWindow32</windowClass>
    <windowClass>ScrollBar</windowClass>
    <windowClass>Static</windowClass>
    <windowClass>SysAnimate32</windowClass>
    <windowClass>SysDateTimePick32</windowClass>
    <windowClass>SysHeader32</windowClass>
    <windowClass>SysIPAddress32</windowClass>
    <windowClass>SysLink</windowClass>
    <windowClass>SysListView32</windowClass>
    <windowClass>SysMonthCal32</windowClass>
    <windowClass>SysPager</windowClass>
    <windowClass>SysTabControl32</windowClass>
    <windowClass>SysTreeView32</windowClass>
    <windowClass>ToolbarWindow32</windowClass>
    <windowClass>msctls_hotkey32</windowClass>
    <windowClass>msctls_progress32</windowClass>
    <windowClass>msctls_statusbar32</windowClass>
    <windowClass>msctls_trackbar32</windowClass>
    <windowClass>msctls_updown32</windowClass>
    <windowClass>tooltips_class32</windowClass>
  </file>
</assembly>

[Bug 43939] comctl32 cannot load its assembly on arm

https://bugs.winehq.org/show_bug.cgi?id=43939

--- Comment #1 from Alexandre Julliard  ---
Created attachment 59581
  --> https://bugs.winehq.org/attachment.cgi?id=59581
Add ARM arch

Something like this should help.

[Bug 43939] comctl32 cannot load its assembly on arm

https://bugs.winehq.org/show_bug.cgi?id=43939

--- Comment #2 from Austin English  ---
(In reply to Alexandre Julliard from comment #1)
> Created attachment 59581 [details]
> Add ARM arch
>
> Something like this should help.

Yep, all comctl32 tests now pass for me under XFCE/arm, thanks.

[Bug 43939] comctl32 cannot load its assembly on arm

https://bugs.winehq.org/show_bug.cgi?id=43939

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch, source,
                   |                            |testcase

[Bug 43939] comctl32 cannot load its assembly on arm

https://bugs.winehq.org/show_bug.cgi?id=43939

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |35719665d79bc1cc3be19628021
                   |                            |a154f563daa51
       Distribution|---                         |Debian
         Resolution|---                         |FIXED

--- Comment #3 from Austin English  ---
Fixed by
https://source.winehq.org/git/wine.git/commitdiff/35719665d79bc1cc3be1962802...

[Bug 43939] comctl32 cannot load its assembly on arm

https://bugs.winehq.org/show_bug.cgi?id=43939

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 2.21.

[Bug 43939] comctl32 cannot load its assembly on arm

https://bugs.winehq.org/show_bug.cgi?id=43939

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.0.x

[Bug 43939] comctl32 cannot load its assembly on arm

https://bugs.winehq.org/show_bug.cgi?id=43939

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2.0.x                       |---

--- Comment #5 from Michael Stefaniuc  ---
Removing the 2.0.x milestone from bugs included in 2.0.5.